Skip to content

Commit 342a049

Browse files
committed
test: fixes for precision and fragile tests from jax-galsim PR
1 parent 897c92b commit 342a049

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

tests/test_draw.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1097,22 +1097,22 @@ def test_shoot():
10971097
# in exact arithmetic. We had an assert there which blew up in a not very nice way.
10981098
obj = galsim.Gaussian(sigma=0.2398318) + 0.1*galsim.Gaussian(sigma=0.47966352)
10991099
obj = obj.withFlux(100001)
1100-
image1 = galsim.ImageF(32,32, init_value=100)
1100+
image1 = galsim.ImageD(32,32, init_value=100)
11011101
rng = galsim.BaseDeviate(1234)
11021102
obj.drawImage(image1, method='phot', poisson_flux=False, add_to_image=True, rng=rng,
11031103
maxN=100000)
11041104

11051105
# The test here is really just that it doesn't crash.
11061106
# But let's do something to check correctness.
1107-
image2 = galsim.ImageF(32,32)
1107+
image2 = galsim.ImageD(32,32)
11081108
rng = galsim.BaseDeviate(1234)
11091109
obj.drawImage(image2, method='phot', poisson_flux=False, add_to_image=False, rng=rng,
11101110
maxN=100000)
11111111
image2 += 100
1112-
np.testing.assert_almost_equal(image2.array, image1.array, decimal=12)
1112+
np.testing.assert_almost_equal(image2.array, image1.array, decimal=10)
11131113

11141114
# Also check that you get the same answer with a smaller maxN.
1115-
image3 = galsim.ImageF(32,32, init_value=100)
1115+
image3 = galsim.ImageD(32,32, init_value=100)
11161116
rng = galsim.BaseDeviate(1234)
11171117
obj.drawImage(image3, method='phot', poisson_flux=False, add_to_image=True, rng=rng, maxN=1000)
11181118
# It's not exactly the same, since the rngs are realized in a different order.

tests/test_noise.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ def test_variable_gaussian_noise():
321321
print('variance = ',var)
322322
print('getVar = ',big_vgn.var_image.array.mean())
323323
np.testing.assert_almost_equal(
324-
var, big_vgn.var_image.array.mean(), 1,
324+
var, big_vgn.var_image.array.mean(), 0,
325325
err_msg='Realized variance for VariableGaussianNoise did not match var_image')
326326

327327
# Check realized variance in each mask
@@ -338,7 +338,7 @@ def test_variable_gaussian_noise():
338338
gal.withFlux(-1.e4).drawImage(image=big_im, add_to_image=True)
339339
var = np.var(big_im.array)
340340
np.testing.assert_almost_equal(
341-
var, big_vgn.var_image.array.mean(), 1,
341+
var, big_vgn.var_image.array.mean(), 0,
342342
err_msg='VariableGaussianNoise wrong when already an object drawn on the image')
343343

344344
# Check picklability

0 commit comments

Comments
 (0)