Fix: Add missing ensurePublicKeySignatureIsValid method to PublicKeyService (#677)

Author: dzikowski

chain-api/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gala-chain/api",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "description": "Common types, DTOs (Data Transfer Objects), APIs, signatures, and utils for GalaChain.",
   "license": "Apache-2.0",
   "dependencies": {

chain-cli/README.md

@@ -20,7 +20,7 @@ $ npm install -g @gala-chain/cli
 $ galachain COMMAND
 running command...
 $ galachain (--version)
-@gala-chain/cli/2.5.0 linux-x64 node-v18.20.8
+@gala-chain/cli/2.5.1 linux-x64 node-v18.20.8
 $ galachain --help [COMMAND]
 USAGE
   $ galachain COMMAND

chain-cli/chaincode-template/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@galachain/product",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "description": "Product Chaincode",
   "main": "lib/src/index.js",
   "types": "lib/src/index.d.ts",
@@ -24,17 +24,17 @@
     "update-snapshot": "jest --updateSnapshot"
   },
   "dependencies": {
-    "@gala-chain/api": "2.5.0",
-    "@gala-chain/chaincode": "2.5.0",
+    "@gala-chain/api": "2.5.1",
+    "@gala-chain/chaincode": "2.5.1",
     "@grpc/grpc-js": "1.10.10",
     "dotenv": "^16.0.1",
     "fabric-contract-api": "2.5.6",
     "fabric-shim": "2.5.6"
   },
   "devDependencies": {
-    "@gala-chain/cli": "2.5.0",
-    "@gala-chain/client": "2.5.0",
-    "@gala-chain/test": "2.5.0",
+    "@gala-chain/cli": "2.5.1",
+    "@gala-chain/client": "2.5.1",
+    "@gala-chain/test": "2.5.1",
     "@trivago/prettier-plugin-sort-imports": "^4.3.0",
     "@types/jest": "^29.5.12",
     "@types/node": "18.11.9",

chain-cli/chaincode-template/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gala-chain/cli",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "description": "CLI for GalaChain to manage and deploy chaincodes",
   "license": "Apache-2.0",
   "bin": {
@@ -14,7 +14,7 @@
     "/oclif.manifest.json"
   ],
   "dependencies": {
-    "@gala-chain/api": "2.5.0",
+    "@gala-chain/api": "2.5.1",
     "@noble/secp256k1": "^1.7.1",
     "@oclif/core": "^3",
     "@oclif/plugin-help": "^3",

chain-cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gala-chain/client",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "description": "GalaChain client library",
   "license": "Apache-2.0",
   "scripts": {
@@ -21,7 +21,7 @@
     "lib"
   ],
   "dependencies": {
-    "@gala-chain/api": "2.5.0",
+    "@gala-chain/api": "2.5.1",
     "axios": "^1.6.0",
     "jsonschema": "^1.4.1",
     "tslib": "^2.6.2"

chain-client/package.json

@@ -1,8 +1,8 @@
 {
   "name": "@gala-chain/connect",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "dependencies": {
-    "@gala-chain/api": "2.5.0",
+    "@gala-chain/api": "2.5.1",
     "ethers": "^6.12.1",
     "tslib": "^2.3.0",
     "bignumber.js": "9.1.2",

chain-connect/package.json

@@ -1,16 +1,16 @@
 {
   "name": "@gala-chain/test",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "description": "Unit testing and integration testing for GalaChain",
   "license": "Apache-2.0",
   "dependencies": {
-    "@gala-chain/client": "2.5.0",
+    "@gala-chain/client": "2.5.1",
     "nanoid": "^3.3.6",
     "tslib": "^2.6.2",
     "@jest/globals": "29.7.0"
   },
   "peerDependencies": {
-    "@gala-chain/api": "2.5.0",
+    "@gala-chain/api": "2.5.1",
     "bignumber.js": "*",
     "class-transformer": "0.5.1",
     "fabric-contract-api": "*",

chain-test/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gala-chain/chaincode",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "description": "Framework for building chaincodes on GalaChain",
   "license": "Apache-2.0",
   "type": "commonjs",
@@ -22,7 +22,7 @@
     "update-snapshot": "jest --updateSnapshot"
   },
   "dependencies": {
-    "@gala-chain/api": "2.5.0",
+    "@gala-chain/api": "2.5.1",
     "@grpc/grpc-js": "1.10.10",
     "fabric-contract-api": "2.5.6",
     "fabric-shim": "2.5.6",

chaincode/package.json

@@ -13,6 +13,7 @@
  * limitations under the License.
  */
 import {
+  ChainCallDTO,
   ChainObject,
   NotImplementedError,
   PK_INDEX_KEY,
@@ -33,6 +34,7 @@ import { Context } from "fabric-contract-api";
 
 import { GalaChainContext } from "../types";
 import {
+  PkInvalidSignatureError,
   PkMismatchError,
   PkMissingError,
   PkNotFoundError,
@@ -229,7 +231,6 @@ export class PublicKeyService {
     return undefined;
   }
 
-  // TODO test to verify that all user profile entries are saved
   public static async registerUser(
     ctx: GalaChainContext,
     publicKeys: string[],
@@ -515,4 +516,27 @@ export class PublicKeyService {
       }
     }
   }
+
+  /**
+   * Verifies if the data is properly signed. Throws exception instead.
+   */
+  public static async ensurePublicKeySignatureIsValid(
+    ctx: GalaChainContext,
+    userAlias: UserAlias,
+    dto: ChainCallDTO
+  ): Promise<PublicKey> {
+    const pk = await PublicKeyService.getPublicKey(ctx, userAlias);
+
+    if (pk === undefined) {
+      throw new PkMissingError(userAlias);
+    }
+
+    const isSignatureValid = dto.isSignatureValid(pk.publicKey ?? "");
+
+    if (!isSignatureValid) {
+      throw new PkInvalidSignatureError(userAlias);
+    }
+
+    return pk;
+  }
 }