You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 24, 2025. It is now read-only.
I never really used it since it was rather premature, but it was a good idea in practice (you'd have an always up-to-date dataset). We should bring it back, but I'm a little split on implementation.
I would want ADCS to be a class. But at the same time, I don't want galaxygpt to have a reference dependency on dataset-assistant, since it's meant to be a utility.
But at the same time, I don't want to have to copy-paste the code from dataset-assistant into galaxygpt.
I can only see a couple ways of properly implementing this:
Make ADCS a seperate project. Have it depend on dataset-assistant. Maybe add quartz.net to it for scheduling.
Decouple the dataset creation code from dataset-assistant, put it in galaxygpt, then have dataset-assistant depend on galaxygpt's DatasetCreator class. And bake ADCS into galaxygpt.
Combine both solutions. Have ADCS be a seperate project, but instead of referencing dataset-assistant, decouple the dataset creation logic from dataset-assistant and put it in galaxygpt. Then have ADCS depend on galaxygpt's DatasetCreator class.
I never really used it since it was rather premature, but it was a good idea in practice (you'd have an always up-to-date dataset). We should bring it back, but I'm a little split on implementation.
I would want ADCS to be a class. But at the same time, I don't want galaxygpt to have a reference dependency on dataset-assistant, since it's meant to be a utility.
But at the same time, I don't want to have to copy-paste the code from dataset-assistant into galaxygpt.
I can only see a couple ways of properly implementing this: