Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Bring back ADCS #61

@smallketchup82

Description

@smallketchup82

I never really used it since it was rather premature, but it was a good idea in practice (you'd have an always up-to-date dataset). We should bring it back, but I'm a little split on implementation.

I would want ADCS to be a class. But at the same time, I don't want galaxygpt to have a reference dependency on dataset-assistant, since it's meant to be a utility.

But at the same time, I don't want to have to copy-paste the code from dataset-assistant into galaxygpt.

I can only see a couple ways of properly implementing this:

  1. Make ADCS a seperate project. Have it depend on dataset-assistant. Maybe add quartz.net to it for scheduling.
  2. Decouple the dataset creation code from dataset-assistant, put it in galaxygpt, then have dataset-assistant depend on galaxygpt's DatasetCreator class. And bake ADCS into galaxygpt.
  3. Combine both solutions. Have ADCS be a seperate project, but instead of referencing dataset-assistant, decouple the dataset creation logic from dataset-assistant and put it in galaxygpt. Then have ADCS depend on galaxygpt's DatasetCreator class.

Metadata

Metadata

Labels

priority:highneeds to be worked on asap
No fields configured for Enhancement.

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions