Do the string -> DateTime casting inside the setter method. Remove the caster altogether and remove _typeMap

Author: Garethp

src/API/MagicMethodsTrait.php

@@ -12,8 +12,6 @@
 
 trait MagicMethodsTrait
 {
-    protected $_typeMap = [];
-
     public function __call($name, $arguments)
     {
         $callTypeIndex = 3;
@@ -42,7 +40,7 @@ public function __set($name, $value)
         }
 
         if ($this->methodExists("set" . ucfirst($name))) {
-            $this->{"set" . ucfirst($name)}($this->castValueIfNeeded(lcfirst($name), $value));
+            $this->{"set" . ucfirst($name)}($value);
             return;
         }
 
@@ -72,7 +70,6 @@ public function get($name)
     public function set($name, $value)
     {
         $name = $this->getNameInCorrectCase($name);
-        $value = $this->castValueIfNeeded($name, $value);
 
         $this->$name = $value;
 
@@ -82,7 +79,6 @@ public function set($name, $value)
     public function add($name, $value)
     {
         $name = $this->getNameInCorrectCase($name);
-        $value = $this->castValueIfNeeded($name, $value);
 
         if ($this->$name == null) {
             $this->$name = array();
@@ -105,20 +101,6 @@ public function is($name)
         return ((bool) $this->$name);
     }
 
-    public function cast($value, $type)
-    {
-        return Caster::cast($value, $type);
-    }
-
-    public function castToExchange($value, $type)
-    {
-        if (Caster::castExists($type, 'ExchangeFormat')) {
-            $value = Caster::cast($value, 'ExchangeFormat');
-        }
-
-        return $value;
-    }
-
     protected function getValidNameInCorrectCase($names)
     {
         foreach ($names as $name) {
@@ -149,20 +131,4 @@ protected function getNameInCorrectCase($name)
 
         return $name;
     }
-
-    /**
-     * @param $name
-     * @param $value
-     * @return null
-     */
-    protected function castValueIfNeeded($name, $value)
-    {
-        if (isset($this->_typeMap[$name])) {
-            $value = $this->cast($value, $this->_typeMap[$name]);
-
-            return $value;
-        }
-
-        return $value;
-    }
 }

src/API/Message/AddDelegateType.php

@@ -28,10 +28,8 @@ class AddDelegateType extends BaseDelegateType
      */
     public function addDelegateUsers(\garethp\ews\API\Type\DelegateUserType $value)
     {
-        $value = $this->castValueIfNeeded("delegateUsers", $value);
-
         if ($this->delegateUsers === null) {
-            $this->delegateUsers = array();
+                        $this->delegateUsers = array();
         }
 
         if (!is_array($this->delegateUsers)) {
@@ -62,7 +60,7 @@ public function setDelegateUsers(array|\garethp\ews\API\Type\DelegateUserType $v
         if (!is_array($value)) {
             $value = [$value];
         }
-        $this->delegateUsers = $this->castValueIfNeeded("delegateUsers", $value);
+        $this->delegateUsers = $value;
         return $this;
     }
 
@@ -82,7 +80,7 @@ public function getDeliverMeetingRequests()
      */
     public function setDeliverMeetingRequests($value)
     {
-        $this->deliverMeetingRequests = $this->castValueIfNeeded("deliverMeetingRequests", $value);
+        $this->deliverMeetingRequests = $value;
         return $this;
     }
 }

src/API/Message/ApplyConversationActionType.php

@@ -23,10 +23,8 @@ class ApplyConversationActionType extends BaseRequestType
      */
     public function addConversationActions(\garethp\ews\API\Type\ConversationActionType $value)
     {
-        $value = $this->castValueIfNeeded("conversationActions", $value);
-
         if ($this->conversationActions === null) {
-            $this->conversationActions = array();
+                        $this->conversationActions = array();
         }
 
         if (!is_array($this->conversationActions)) {
@@ -57,7 +55,7 @@ public function setConversationActions(array|\garethp\ews\API\Type\ConversationA
         if (!is_array($value)) {
             $value = [$value];
         }
-        $this->conversationActions = $this->castValueIfNeeded("conversationActions", $value);
+        $this->conversationActions = $value;
         return $this;
     }
 }