Skip to content

Commit 5d4e7b8

Browse files
committed
Fix?
1 parent bd9fd83 commit 5d4e7b8

File tree

2 files changed

+21
-22
lines changed

2 files changed

+21
-22
lines changed

main.go

+19-19
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import (
66
"fmt"
77
"github.com/pterm/pterm"
88
"os"
9-
"path"
9+
"path/filepath"
1010
"strconv"
1111
"strings"
1212
)
@@ -132,7 +132,7 @@ func scanFiles(folders []string) {
132132
for _, folder := range folders {
133133
var fingerprints []int64
134134
pterm.Info.Println("Scanning " + folder + " directory...")
135-
files, err := os.ReadDir(path.Join(*instanceDir, folder))
135+
files, err := os.ReadDir(filepath.Join(*instanceDir, folder))
136136
if err != nil {
137137
pterm.Error.Println("Failed to read "+folder+" directory\n", err)
138138
os.Exit(1)
@@ -141,7 +141,7 @@ func scanFiles(folders []string) {
141141
fileProgress, _ := pterm.DefaultProgressbar.WithTotal(len(files)).WithTitle("Reading " + folder + " directory").Start()
142142
for _, file := range files {
143143
fileProgress.UpdateTitle("Found: " + file.Name())
144-
fileHash, _ := GetFileHash(path.Join(*instanceDir, folder, file.Name()))
144+
fileHash, _ := GetFileHash(filepath.Join(*instanceDir, folder, file.Name()))
145145
fingerprints = append(fingerprints, fileHash)
146146
fileProgress.Increment()
147147
}
@@ -164,35 +164,35 @@ func scanFiles(folders []string) {
164164
func genOverrides(missingFiles []int64, folder string) {
165165
pterm.DefaultSection.Println("Generating overrides for " + folder + "...")
166166

167-
if _, err := os.Stat(path.Join(tmpDir, "overrides")); os.IsNotExist(err) {
168-
err := os.Mkdir(path.Join(tmpDir, "overrides"), os.ModePerm)
167+
if _, err := os.Stat(filepath.Join(tmpDir, "overrides")); os.IsNotExist(err) {
168+
err := os.Mkdir(filepath.Join(tmpDir, "overrides"), os.ModePerm)
169169
if err != nil {
170170
pterm.Error.Println("Failed to create overrides directory:", err)
171171
}
172172
}
173173

174174
if len(missingFiles) > 0 {
175175
pterm.Debug.Println("Adding missing files to overrides:", missingFiles)
176-
if _, err := os.Stat(path.Join(tmpDir, "overrides", folder)); os.IsNotExist(err) {
177-
err := os.Mkdir(path.Join(tmpDir, "overrides", folder), os.ModePerm)
176+
if _, err := os.Stat(filepath.Join(tmpDir, "overrides", folder)); os.IsNotExist(err) {
177+
err := os.Mkdir(filepath.Join(tmpDir, "overrides", folder), os.ModePerm)
178178
if err != nil {
179179
pterm.Error.Println(fmt.Sprintf("Failed to create overrides/%s directory:", folder), err)
180180
}
181181
}
182182

183-
files, err := os.ReadDir(path.Join(*instanceDir, folder))
183+
files, err := os.ReadDir(filepath.Join(*instanceDir, folder))
184184
if err != nil {
185185
pterm.Error.Println("Failed to read "+folder+" directory\n", err)
186186
os.Exit(1)
187187
}
188188
fileProgress, _ := pterm.DefaultProgressbar.WithTotal(len(files)).WithTitle("Reading " + folder + " directory for overrides").Start()
189189
for _, file := range files {
190-
fileHash, _ := GetFileHash(path.Join(*instanceDir, folder, file.Name()))
190+
fileHash, _ := GetFileHash(filepath.Join(*instanceDir, folder, file.Name()))
191191
if intInSlice(fileHash, missingFiles) {
192192
fileProgress.UpdateTitle("Adding to overrides: " + file.Name())
193193
pterm.Debug.Println(fmt.Sprintf("Failed to find file %s on CurseForge - generating override", file.Name()))
194-
modSrc := path.Join(*instanceDir, folder, file.Name())
195-
err = CopyFile(modSrc, path.Join(tmpDir, "overrides", folder, file.Name()))
194+
modSrc := filepath.Join(*instanceDir, folder, file.Name())
195+
err = CopyFile(modSrc, filepath.Join(tmpDir, "overrides", folder, file.Name()))
196196
if err != nil {
197197
pterm.Error.Println("Failed to copy file:", err)
198198
}
@@ -208,22 +208,22 @@ func extraIncludes() {
208208
for _, include := range buildConfig.Includes {
209209
if include != "mods" && include != "resourcepacks" {
210210
includeProgress.UpdateTitle("Adding: " + include + " to overrides")
211-
fToInclude := path.Join(*instanceDir, include)
211+
fToInclude := filepath.Join(*instanceDir, include)
212212
fi, err := os.Stat(fToInclude)
213213
if err != nil {
214214
includeProgress.UpdateTitle("Skipping adding: " + include + " to overrides")
215215
pterm.Warning.Println("Failed to read "+include+" directory\n", err)
216216
includeProgress.Increment()
217217
continue
218218
}
219-
switch mode := fi.Mode(); {
220-
case mode.IsDir():
221-
err = CopyDir(fToInclude, path.Join(tmpDir, "overrides", include))
219+
220+
if fi.IsDir() {
221+
err = CopyDir(fToInclude, filepath.Join(tmpDir, "overrides", include))
222222
if err != nil {
223223
pterm.Error.Println("Failed to copy directory:", err)
224224
}
225-
case mode.IsRegular():
226-
err = CopyFile(fToInclude, path.Join(tmpDir, "overrides", include))
225+
} else {
226+
err = CopyFile(fToInclude, filepath.Join(tmpDir, "overrides", include))
227227
if err != nil {
228228
pterm.Error.Println("Failed to copy file:", err)
229229
}
@@ -255,7 +255,7 @@ func genExport(projectFiles []FingerprintExactMatches) {
255255
pterm.Error.Println("Failed to marshal manifest:", err)
256256
os.Exit(1)
257257
}
258-
err = os.WriteFile(path.Join(tmpDir, "manifest.json"), manifestJson, 0644)
258+
err = os.WriteFile(filepath.Join(tmpDir, "manifest.json"), manifestJson, 0644)
259259
if err != nil {
260260
pterm.Error.Println("Failed to write manifest:", err)
261261
os.Exit(1)
@@ -266,7 +266,7 @@ func genExport(projectFiles []FingerprintExactMatches) {
266266
pterm.Error.Println("Failed to create output directory:", err)
267267
}
268268
}
269-
err = RecursiveZip(tmpDir, path.Join(*outputDir, *exportName+"-"+*exportVersion+".zip"))
269+
err = RecursiveZip(tmpDir, filepath.Join(*outputDir, *exportName+"-"+*exportVersion+".zip"))
270270
if err != nil {
271271
pterm.Error.Println("Failed to zip export:", err)
272272
os.Exit(1)

util.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111
"io/ioutil"
1212
"net/http"
1313
"os"
14-
"path"
1514
"path/filepath"
1615
"strings"
1716
)
@@ -87,8 +86,8 @@ func CopyDir(src string, dst string) error {
8786
return err
8887
}
8988
for _, fd := range fds {
90-
srcfp := path.Join(src, fd.Name())
91-
dstfp := path.Join(dst, fd.Name())
89+
srcfp := filepath.Join(src, fd.Name())
90+
dstfp := filepath.Join(dst, fd.Name())
9291

9392
if fd.IsDir() {
9493
if err = CopyDir(srcfp, dstfp); err != nil {

0 commit comments

Comments
 (0)