fix: switch to biome

doomsower · doomsower · commit b503629be706 · 2025-06-25T16:16:22.000-04:00
diff --git a/.commitlintrc.json b/.commitlintrc.json
diff --git a/.eslint.local.json b/.eslint.local.json
@@ -0,0 +1,5 @@
+{
+  "rules": {
+    "unused-imports/no-unused-imports": "error"
+  }
+}
diff --git a/.eslintignore b/.eslintignore
diff --git a/.eslintrc.json b/.eslintrc.json
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -22,5 +22,4 @@ jobs:
         run: |
           yarn install --frozen-lockfile
           yarn typecheck:ci
-          yarn lint:ci
-          yarn prettier:ci
+          yarn check:ci
diff --git a/.gitignore b/.gitignore
@@ -21,8 +21,6 @@ typechain/
 /logs/*.json
 *.log
 *.tsbuildinfo
-.eslintcache
-.eslint.local.json
 
 # Optimistic output
 /output
diff --git a/.prettierignore b/.prettierignore
diff --git a/.prettierrc b/.prettierrc
diff --git a/.vscode/extensions.json b/.vscode/extensions.json
@@ -1,7 +1,3 @@
 {
-  "recommendations": [
-    "esbenp.prettier-vscode",
-    "nomicfoundation.hardhat-solidity",
-    "dbaeumer.vscode-eslint"
-  ]
+  "recommendations": ["biomejs.biome"]
 }
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,13 +1,40 @@
 {
+  "[javascript]": {
+    "editor.defaultFormatter": "biomejs.biome"
+  },
+  "[javascriptreact]": {
+    "editor.defaultFormatter": "biomejs.biome"
+  },
+  "[json]": {
+    "editor.defaultFormatter": "biomejs.biome"
+  },
+  "[typescript]": {
+    "editor.defaultFormatter": "biomejs.biome"
+  },
+  "[typescriptreact]": {
+    "editor.defaultFormatter": "biomejs.biome"
+  },
+  "[yaml]": {
+    "editor.defaultFormatter": "esbenp.prettier-vscode"
+  },
+  "biome.enabled": true,
   "editor.codeActionsOnSave": {
-    "source.fixAll.eslint": "explicit"
+    "source.action.useSortedKeys.biome": "explicit",
+    "source.fixAll.biome": "explicit",
+    "source.fixAll.eslint": "never",
+    "source.organizeImports.biome": "explicit"
   },
-  "editor.defaultFormatter": "esbenp.prettier-vscode",
+  "editor.defaultFormatter": "biomejs.biome",
   "editor.formatOnSave": true,
   "editor.tabSize": 2,
-  "eslint.validate": ["javascript", "typescript"],
+  "eslint.enable": false,
   "files.eol": "\n",
-  "[json]": {
-    "editor.defaultFormatter": "esbenp.prettier-vscode"
+  "search.exclude": {
+    "**/node_modules": true,
+    "**/cache": true,
+    "**/lib": true,
+    "**/build": true,
+    "**/dist": true,
+    "**/forge-out": true
   }
 }
diff --git a/biome.json b/biome.json
@@ -0,0 +1,24 @@
+{
+  "$schema": "https://biomejs.dev/schemas/2.0.5/schema.json",
+  "extends": ["@gearbox-protocol/biome-config"],
+  "vcs": {
+    "enabled": true,
+    "clientKind": "git",
+    "useIgnoreFile": true
+  },
+  "files": {
+    "includes": [
+      "**",
+      "!node_modules",
+      "!build",
+      "!output",
+      "!.yarn",
+      "!cache",
+      "!dist",
+      "!forge-out",
+      "!lib",
+      "!contracts"
+    ],
+    "ignoreUnknown": true
+  }
+}
diff --git a/package.json b/package.json
@@ -10,10 +10,8 @@
     "build": "node esbuild.config.mjs",
     "start": "tsx --env-file .env src/index.ts | pino-pretty --colorize",
     "prepare": "husky",
-    "prettier": "prettier --write .",
-    "prettier:ci": "npx prettier --check .",
-    "lint": "eslint \"**/*.ts\" --fix",
-    "lint:ci": "eslint \"**/*.ts\"",
+    "check": "biome check --write",
+    "check:ci": "biome check",
     "typecheck:ci": "tsc --noEmit",
     "test": "vitest"
   },
@@ -23,14 +21,14 @@
   },
   "devDependencies": {
     "@aws-sdk/client-s3": "^3.835.0",
+    "@biomejs/biome": "^2.0.5",
     "@commander-js/extra-typings": "^14.0.0",
     "@commitlint/cli": "^19.8.1",
     "@commitlint/config-conventional": "^19.8.1",
+    "@gearbox-protocol/biome-config": "^1.0.0",
     "@gearbox-protocol/cli-utils": "^5.36.13",
-    "@gearbox-protocol/eslint-config": "2.0.0-next.2",
     "@gearbox-protocol/liquidator-v2-contracts": "^2.4.0",
     "@gearbox-protocol/next-contracts": "npm:@gearbox-protocol/liquidator-v2-contracts@2.5.0-next.3",
-    "@gearbox-protocol/prettier-config": "2.1.0",
     "@gearbox-protocol/sdk": "8.2.1",
     "@gearbox-protocol/types": "^1.14.8",
     "@types/node": "^24.0.3",
@@ -43,26 +41,26 @@
     "date-fns": "^4.1.0",
     "di-at-home": "^0.0.7",
     "esbuild": "^0.25.5",
-    "eslint": "^8.57.1",
     "husky": "^9.1.7",
     "lint-staged": "^16.1.2",
     "nanoid": "^5.1.5",
     "node-pty": "^1.0.0",
     "pino": "^9.7.0",
-    "prettier": "^3.6.0",
     "tsx": "4.20.3",
     "typescript": "^5.8.3",
     "viem": "^2.31.4",
     "vitest": "^3.2.4",
     "zod": "^3.25.67"
   },
-  "prettier": "@gearbox-protocol/prettier-config",
+  "commitlint": {
+    "extends": [
+      "@commitlint/config-conventional"
+    ]
+  },
   "lint-staged": {
-    "*.ts": [
-      "eslint --fix",
-      "prettier --write"
-    ],
-    "*.{json,md}": "prettier --write"
+    "*.{ts,tsx,mts,mjs,json}": [
+      "biome check --no-errors-on-unmatched --write"
+    ]
   },
   "packageManager": "yarn@4.9.2"
 }
diff --git a/src/attachSDK.ts b/src/attachSDK.ts
@@ -36,7 +36,7 @@ export default async function attachSDK(): Promise<CreditAccountsService> {
     //
     // Also, when forking anvil->anvil (when running on testnets) block.timestamp can be in future because min ts for block is 1 seconds,
     // and scripts can take dozens of blocks (hundreds for faucet). So we take min value;
-    const nowMs = new Date().getTime();
+    const nowMs = Date.now();
     if (config.optimisticTimestamp) {
       optimisticTimestamp = config.optimisticTimestamp;
     } else {
diff --git a/src/errors/ErrorHandler.ts b/src/errors/ErrorHandler.ts
@@ -186,7 +186,7 @@ export class ErrorHandler {
     let longMessage = e.message;
     if (e.cause) {
       const cause = this.#unwrapCause(e.cause as Error);
-      longMessage = longMessage + "Cause: " + cause.longMessage;
+      longMessage = `${longMessage}Cause: ${cause.longMessage}`;
     }
     return { shortMessage, longMessage };
   }
diff --git a/src/services/HealthCheckerService.ts b/src/services/HealthCheckerService.ts
@@ -22,7 +22,7 @@ export default class HealthCheckerService {
   @DI.Inject(DI.Config)
   config!: Config;
 
-  #start = Math.round(new Date().valueOf() / 1000);
+  #start = Math.round(Date.now() / 1000);
   #id = nanoid();
 
   /**
@@ -48,7 +48,7 @@ export default class HealthCheckerService {
         try {
           res.writeHead(200, { "Content-Type": "text/plain" });
           res.end(this.#metrics());
-        } catch (ex) {
+        } catch (_ex) {
           res.writeHead(500, { "Content-Type": "text/plain" });
           res.end("error");
         }
diff --git a/src/services/Scanner.ts b/src/services/Scanner.ts
@@ -131,7 +131,7 @@ export class Scanner {
         `filtered out ${before - accounts.length} restaking accounts`,
       );
     }
-    const time = Math.round((new Date().getTime() - start) / 1000);
+    const time = Math.round((Date.now() - start) / 1000);
     this.log.debug(
       `${accounts.length} accounts to liquidate${blockS}, time: ${time}s`,
     );
diff --git a/src/services/liquidate/BatchLiquidator.ts b/src/services/liquidate/BatchLiquidator.ts
@@ -261,7 +261,7 @@ export default class BatchLiquidator
     if (!this.#batchLiquidator) {
       this.logger.debug("deploying batch liquidator");
 
-      let hash = await this.client.wallet.deployContract({
+      const hash = await this.client.wallet.deployContract({
         abi: batchLiquidatorAbi,
         bytecode: BatchLiquidator_bytecode,
         args: [this.#router],
@@ -320,7 +320,7 @@ export default class BatchLiquidator
       if (!accountsByOracle.has(oracle)) {
         accountsByOracle.set(oracle, []);
       }
-      accountsByOracle.get(oracle)!.push(ca);
+      accountsByOracle.get(oracle)?.push(ca);
     }
 
     // Sort accounts within each oracle by healthFactor bin ASC, debt DESC
diff --git a/src/services/liquidate/partial/utils.ts b/src/services/liquidate/partial/utils.ts
@@ -22,8 +22,7 @@ export function humanizeOptimalLiquidation(
     flashLoanAmount:
       formatBN(data.flashLoanAmount, uDec) +
       ` ${uSymb} (${data.flashLoanAmount})`,
-    repaidAmount:
-      formatBN(data.repaidAmount, uDec) + ` ${uSymb} (${data.repaidAmount})`,
+    repaidAmount: `${formatBN(data.repaidAmount, uDec)} ${uSymb} (${data.repaidAmount})`,
     isOptimalRepayable: data.isOptimalRepayable,
   };
 }
diff --git a/src/services/notifier/messages.ts b/src/services/notifier/messages.ts
@@ -87,7 +87,7 @@ export class LowBalanceMessage extends BaseMessage implements INotifierMessage {
 
   public get markdown(): string {
     return md.build(
-      md`[${this.network}] balance of liquidator ${md.link(this.#wallet, etherscanUrl({ address: this.#wallet }, this.network))} is ${md.bold(formatBN(this.#balance, 18) + " ETH")} is below minumum of ${md.bold(formatBN(this.#minBalance, 18) + " ETH")}`,
+      md`[${this.network}] balance of liquidator ${md.link(this.#wallet, etherscanUrl({ address: this.#wallet }, this.network))} is ${md.bold(`${formatBN(this.#balance, 18)} ETH`)} is below minumum of ${md.bold(`${formatBN(this.#minBalance, 18)} ETH`)}`,
     );
   }
 }
@@ -269,7 +269,7 @@ export class LiquidationErrorMessage
   ) {
     super({ ca });
     this.#strategyAdverb = strategyAdverb;
-    this.#error = error.length > 128 ? error.slice(0, 128) + "..." : error;
+    this.#error = error.length > 128 ? `${error.slice(0, 128)}...` : error;
     this.#callsHuman = callsHuman;
     this.#skipOnFailure = skipOnFailure
       ? "Will skip further liquidation attempts"
@@ -304,7 +304,7 @@ export class BatchLiquidationErrorMessage
   constructor(accounts: CreditAccountData[], error: string) {
     super({});
     this.#accounts = accounts;
-    this.#error = error.length > 128 ? error.slice(0, 128) + "..." : error;
+    this.#error = error.length > 128 ? `${error.slice(0, 128)}...` : error;
   }
 
   public get plain(): string {
@@ -321,13 +321,13 @@ Error: ${md.inlineCode(this.#error)}`,
 }
 
 function callsPlain(calls?: string[]): string {
-  return calls ? calls.map(c => " ➤ " + c).join("\n") : "-";
+  return calls ? calls.map(c => ` ➤ ${c}`).join("\n") : "-";
 }
 
 function callsMd(calls?: string[]): Markdown {
   return calls
     ? md.join(
-        calls.map(c => " ➤ " + c),
+        calls.map(c => ` ➤ ${c}`),
         "\n",
       )
     : // prettier-ignore
diff --git a/src/services/output/BaseWriter.ts b/src/services/output/BaseWriter.ts
@@ -16,7 +16,7 @@ export default class BaseWriter {
   optimistic!: OptimisticResults;
 
   protected get filename(): string {
-    let fname = this.config.outFileName;
+    const fname = this.config.outFileName;
     if (!fname) {
       throw new Error(`out file name not specified in config`);
     }
diff --git a/src/services/swap/uniswap.ts b/src/services/swap/uniswap.ts
@@ -2,7 +2,9 @@ import { chains, type NetworkType } from "@gearbox-protocol/sdk";
 import { ierc20MetadataAbi } from "@gearbox-protocol/types/abi";
 import type { Currency } from "@uniswap/sdk-core";
 import { CurrencyAmount, Percent, Token, TradeType } from "@uniswap/sdk-core";
-import IUniswapV3PoolABI from "@uniswap/v3-core/artifacts/contracts/interfaces/IUniswapV3Pool.sol/IUniswapV3Pool.json" with { type: "json" };
+import IUniswapV3PoolABI from "@uniswap/v3-core/artifacts/contracts/interfaces/IUniswapV3Pool.sol/IUniswapV3Pool.json" with {
+  type: "json",
+};
 import type { SwapOptions } from "@uniswap/v3-sdk";
 import {
   computePoolAddress,
diff --git a/src/utils/types.ts b/src/utils/types.ts
@@ -1,14 +1,7 @@
-import type { iDataCompressorV3Abi } from "@gearbox-protocol/types/abi";
-import type { GetContractReturnType, PublicClient } from "viem";
-
 export type Numberish = number | bigint;
 export type Arrayish<T> = readonly T[] | T[];
 
+// biome-ignore lint/suspicious/noRedeclare: it's ok
 export type ArrayElementType<T> = T extends readonly (infer U)[] | (infer U)[]
   ? U
   : never;
-
-export type IDataCompressorContract = GetContractReturnType<
-  typeof iDataCompressorV3Abi,
-  PublicClient
->;
diff --git a/src/utils/typescript.ts b/src/utils/typescript.ts
@@ -7,5 +7,7 @@ export function createClassFromType<T>() {
     constructor(args: T) {
       Object.assign(this, args);
     }
-  } as new (args: T) => T;
+  } as new (
+    args: T,
+  ) => T;
 }
diff --git a/yarn.lock b/yarn.lock

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +{
 +  "rules": {
 +    "unused-imports/no-unused-imports": "error"
 +  }
 +}
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,3 @@`
`1`	`1`	`{`
`2`		`- "recommendations": [`
`3`		`- "esbenp.prettier-vscode",`
`4`		`- "nomicfoundation.hardhat-solidity",`
`5`		`- "dbaeumer.vscode-eslint"`
`6`		`- ]`
	`2`	`+ "recommendations": ["biomejs.biome"]`
`7`	`3`	`}`