Merge pull request #11 from Gearbox-protocol/pricefeed-optimisation

fix: additional price feeds fixes and cleanup

Author: 0xmikko

contracts/oracles/LPPriceFeed.sol

@@ -55,7 +55,7 @@ abstract contract LPPriceFeed is ILPPriceFeed, AbstractPriceFeed, ACLNonReentran
     /// @dev Returns upper-bounded LP token exhcange rate and its scale, reverts if rate falls below the lower bound
     /// @dev When computing LP token price, this MUST be used to get the exchange rate
     function _getValidatedLPExchangeRate() internal view returns (uint256 exchangeRate) {
-        exchangeRate = _getLPExchangeRate();
+        exchangeRate = getLPExchangeRate();
 
         uint256 lb = lowerBound;
         if (exchangeRate < lb) revert ValueOutOfRangeException();
@@ -65,7 +65,7 @@ abstract contract LPPriceFeed is ILPPriceFeed, AbstractPriceFeed, ACLNonReentran
     }
 
     /// @dev Returns LP token exchange rate, must be implemented by derived price feeds
-    function _getLPExchangeRate() internal view virtual returns (uint256 exchangeRate);
+    function getLPExchangeRate() public view virtual returns (uint256 exchangeRate);
 
     /// @dev Computes upper bound as `lowerBound * (1 + delta)`
     function _upperBound(uint256 lb) internal view returns (uint256) {
@@ -84,7 +84,7 @@ abstract contract LPPriceFeed is ILPPriceFeed, AbstractPriceFeed, ACLNonReentran
         override
         controllerOnly // F:[LPF-4]
     {
-        uint256 exchangeRate = _getLPExchangeRate();
+        uint256 exchangeRate = getLPExchangeRate();
         if (newLowerBound == 0 || exchangeRate < newLowerBound || exchangeRate > _upperBound(newLowerBound)) {
             revert IncorrectLimitsException(); // F:[LPF-4]
         }
@@ -96,7 +96,7 @@ abstract contract LPPriceFeed is ILPPriceFeed, AbstractPriceFeed, ACLNonReentran
     /// @dev Derived price feeds MUST call this in the constructor after initializing all the
     ///      state variables needed for exchange rate calculation
     function _initLimiter() internal {
-        uint256 newLowerBound = _getLPExchangeRate();
+        uint256 newLowerBound = getLPExchangeRate();
         lowerBound = newLowerBound;
         emit SetBounds(newLowerBound, _upperBound(newLowerBound));
     }

contracts/oracles/SingleAssetLPPriceFeed.sol

@@ -40,10 +40,10 @@ abstract contract SingleAssetLPPriceFeed is LPPriceFeed {
         returns (uint80, int256 answer, uint256, uint256 updatedAt, uint80)
     {
         (answer, updatedAt) = _getValidatedPrice(priceFeed, stalenessPeriod, skipCheck); // F:[OCLP-6]
-        answer = int256((_getValidatedLPExchangeRate() * uint256(answer)) / _getScale()); // F: [OAPF-3]
+        answer = int256((_getValidatedLPExchangeRate() * uint256(answer)) / getScale()); // F: [OAPF-3]
         return (0, answer, 0, updatedAt, 0);
     }
 
     /// @dev Returns LP token exchange rate scale, must be implemented by derived price feeds
-    function _getScale() internal view virtual returns (uint256 scale);
+    function getScale() public view virtual returns (uint256 scale);
 }

contracts/oracles/aave/WrappedAaveV2PriceFeed.sol

@@ -20,11 +20,11 @@ contract WrappedAaveV2PriceFeed is SingleAssetLPPriceFeed {
         _initLimiter();
     }
 
-    function _getLPExchangeRate() internal view override returns (uint256) {
+    function getLPExchangeRate() public view override returns (uint256) {
         return IWrappedATokenV2(lpToken).exchangeRate();
     }
 
-    function _getScale() internal pure override returns (uint256) {
+    function getScale() public pure override returns (uint256) {
         return WAD;
     }
 }

contracts/oracles/balancer/BPTStablePriceFeed.sol

@@ -106,7 +106,7 @@ contract BPTStablePriceFeed is LPPriceFeed {
         return (0, answer, 0, updatedAt, 0);
     }
 
-    function _getLPExchangeRate() internal view override returns (uint256) {
+    function getLPExchangeRate() public view override returns (uint256) {
         return IBalancerStablePool(lpToken).getRate();
     }
 }