fix: bug fixes

Author: 0xmikko

.gitignore

@@ -29,6 +29,6 @@ config.local.yaml
 .eslintcache
 .eslint.local.json
 *.generated.ts
-
+config.yaml
 # Optimistic output
 /output

README.md

@@ -6,7 +6,7 @@ This repository contains a bot that monitors one or more Safe addresses for crit
 - **Signing Transactions:** Monitors who signs the transactions and how many signatures have been collected.
 - **Executing Transactions:** Sends alerts when a transaction is executed.
 
-Additionally, the bot watches for any suspicious `delegateCall`. If a `delegateCall` is directed to an address other than the trusted `MultiSend` contract, the bot immediately flags it, helping to prevent attacks similar to the Bybit hack.  
+Additionally, the bot watches for any suspicious `delegateCall`. If a `delegateCall` is directed to an address other than the trusted `MultiSend` contract, the bot immediately flags it, helping to prevent attacks similar to the Bybit hack.
 
 Real-time alerts are sent to a configured Telegram channel for immediate notification.
 
@@ -51,6 +51,49 @@ docker run -v $(pwd)/config.yaml:/app/config.yaml ghcr.io/gearbox-protocol/safe-
 4. Once the bot is created, BotFather will provide you with an HTTP API token (e.g., `123456:ABC-DEF1234ghIkl-zyx57W2v1u123ew11`).
 5. Copy this token and use it as the value for `telegramBotToken` in your `config.yaml`.
 
+### Getting a Telegram Channel ID
+
+1. Create a new channel or group in Telegram.
+2. Invite your bot to the channel.
+3. Send a message to the channel.
+4. Use getUpdates (Testing Locally or Anywhere You Can Send HTTP Requests)
+
+- Make a call to the [getUpdates](https://core.telegram.org/bots/api#getupdates) endpoint of the Bot API using your bot token. For example: https://api.telegram.org/bot<YOUR_BOT_TOKEN>/getUpdates
+
+The response is a JSON that contains “messages,” “channel_posts,” “callback_query,” or similar objects, depending on how your bot receives interactions.
+
+5. Parse the JSON
+
+- Look for the `"chat"` object inside each message (e.g., `"message"` or `"edited_message"`).
+- The `"chat": { "id": ... }` field is the chat ID. For example, a response might look like:
+
+```json
+{
+  "ok": true,
+  "result": [
+    {
+      "update_id": 123456789,
+      "message": {
+        "message_id": 12,
+        "from": {
+          ...
+        },
+        "chat": {
+          "id": 987654321,
+          "first_name": "John",
+          "type": "private"
+        },
+        "date": 1643212345,
+        "text": "Hello"
+      }
+    }
+  ]
+}
+```
+
+In this snippet, 987654321 is the telegramChannelId.
+.
+
 ### Running via Docker
 
 Run the Docker container with your config file mounted using the following command:
@@ -67,4 +110,4 @@ This project is distributed under the MIT License.
 
 ## Disclaimer
 
-This software is provided "as is," without warranties or guarantees of any kind. Use it at your own risk. The maintainers and contributors are not liable for any damages or losses arising from its use. Always exercise caution and follow best security practices when managing crypto assets.
+This software is provided "as is," without warranties or guarantees of any kind. Use it at your own risk. The maintainers and contributors are not liable for any damages or losses arising from its use. Always exercise caution and follow best security practices when managing crypto assets.

src/SafeWatcher.ts

@@ -124,7 +124,7 @@ class SafeWatcher {
       detailed.operation !== 0;
 
     await this.#notificationSender?.notify({
-      type: isMalicious ? "created" : "malicious",
+      type: isMalicious ? "malicious" : "created",
       chainPrefix: this.#prefix,
       safe: this.#safe,
       tx: detailed,

src/notifications/Telegram.ts

@@ -9,7 +9,7 @@ const ACTIONS: Record<EventType, string> = {
   created: "created",
   updated: "updated",
   executed: "executed",
-  malicious: "created malicious",
+  malicious: "ALERT! ACTION REQUIRED: MALICIOUS TRANSACTION DETECTED!",
 };
 
 const NETWORKS: Record<string, string> = {