fix: sort credit accounts

Author: doomsower

src/accounts/CreditAccountsService.ts

@@ -107,7 +107,7 @@ export class CreditAccountsService extends SDKConstruct {
    * TODO: do we want to expose "reverting"?
    * TODO: do we want to expose MarketFilter in any way? If so, we need to check that the MarketFilter is compatibled with attached markets?
    * @param args
-   * @returns
+   * @returns returned credit accounts are sorted by health factor in ascending order
    */
   public async getCreditAccounts(
     args?: CreditAccountFilter,
@@ -153,7 +153,8 @@ export class CreditAccountsService extends SDKConstruct {
       } while (offset !== 0n);
     }
 
-    return allCAs;
+    // sort by health factor ascending
+    return allCAs.sort((a, b) => Number(a.healthFactor - b.healthFactor));
   }
 
   /**

src/market/pricefeeds/PriceFeedsRegister.ts

@@ -29,10 +29,6 @@ import { ZeroPriceFeedContract } from "./ZeroPriceFeed";
  * PriceFeedRegister acts as a chain-level cache to avoid creating multiple contract instances.
  * It's reused by PriceFeedFactory belonging to different markets
  *
- * ugly workaround for the face that "stalenessPeriod" is not "PriceFeed"'s attribute
- * for example, chainlink price feed can have one staleness period as a top-level oracle entry,
- * and another staleness period when it's a part of a composite price feed
- *
  **/
 export class PriceFeedRegister extends SDKConstruct {
   public readonly logger?: ILogger;