fix: add PriceFeedRegister.loadUpdatablePriceFeeds

Author: doomsower

src/sdk/abi/compressors.ts

@@ -728,6 +728,11 @@ export const iMarketCompressorAbi = [
             type: "address",
             internalType: "address",
           },
+          {
+            name: "acl",
+            type: "address",
+            internalType: "address",
+          },
           {
             name: "name",
             type: "string",
@@ -1691,6 +1696,11 @@ export const iMarketCompressorAbi = [
             type: "address",
             internalType: "address",
           },
+          {
+            name: "acl",
+            type: "address",
+            internalType: "address",
+          },
           {
             name: "name",
             type: "string",
@@ -2589,6 +2599,64 @@ export const iMarketCompressorAbi = [
     ],
     stateMutability: "view",
   },
+  {
+    type: "function",
+    name: "getUpdatablePriceFeeds",
+    inputs: [
+      {
+        name: "filter",
+        type: "tuple",
+        internalType: "struct MarketFilter",
+        components: [
+          {
+            name: "curators",
+            type: "address[]",
+            internalType: "address[]",
+          },
+          {
+            name: "pools",
+            type: "address[]",
+            internalType: "address[]",
+          },
+          {
+            name: "underlying",
+            type: "address",
+            internalType: "address",
+          },
+        ],
+      },
+    ],
+    outputs: [
+      {
+        name: "updatablePriceFeeds",
+        type: "tuple[]",
+        internalType: "struct BaseParams[]",
+        components: [
+          {
+            name: "addr",
+            type: "address",
+            internalType: "address",
+          },
+          {
+            name: "version",
+            type: "uint256",
+            internalType: "uint256",
+          },
+          {
+            name: "contractType",
+            type: "bytes32",
+            internalType: "bytes32",
+          },
+          {
+            name: "serializedParams",
+            type: "bytes",
+            internalType: "bytes",
+          },
+        ],
+      },
+    ],
+    stateMutability: "view",
+  },
   {
     type: "function",
     name: "version",

src/sdk/market/MarketFactory.ts

@@ -8,9 +8,10 @@ import { PoolFactory } from "./PoolFactory";
 import { PriceOracleContract } from "./PriceOracleContract";
 
 export class MarketFactory extends SDKConstruct {
-  public readonly riskCurator!: Address;
-  public readonly poolFactory!: PoolFactory;
-  public readonly priceOracle!: PriceOracleContract;
+  public readonly acl: Address;
+  public readonly riskCurator: Address;
+  public readonly poolFactory: PoolFactory;
+  public readonly priceOracle: PriceOracleContract;
   public readonly creditManagers: CreditFactory[] = [];
   /**
    * Original data received from compressor
@@ -21,6 +22,7 @@ export class MarketFactory extends SDKConstruct {
     super(sdk);
     this.state = marketData;
     this.riskCurator = marketData.owner;
+    this.acl = marketData.acl;
 
     for (const t of marketData.tokens) {
       sdk.tokensMeta.upsert(t.addr, t);

src/sdk/market/MarketRegister.ts

@@ -67,22 +67,34 @@ export class MarketRegister extends SDKConstruct {
       AP_MARKET_COMPRESSOR,
       3_10,
     );
-    const markets = await this.sdk.provider.publicClient.readContract({
-      address: marketCompressorAddress,
-      abi: iMarketCompressorAbi,
-      functionName: "getMarkets",
-      args: [
+    // to have correct prices we must first get all updatable price feeds
+    await this.sdk.priceFeeds.loadUpdatablePriceFeeds(curators, pools);
+    // the generate updates
+    const { txs } = await this.sdk.priceFeeds.generatePriceFeedsUpdateTxs();
+    // ...and push them using multicall before getting answers
+    const resp = await simulateMulticall(this.provider.publicClient, {
+      contracts: [
+        ...txs.map(rawTxToMulticallPriceUpdate),
         {
-          curators,
-          pools,
-          underlying: ADDRESS_0X0,
+          abi: iMarketCompressorAbi,
+          address: marketCompressorAddress,
+          functionName: "getMarkets",
+          args: [
+            {
+              curators,
+              pools,
+              underlying: ADDRESS_0X0,
+            },
+          ],
         },
       ],
-      // It's passed as ...rest in viem readContract action, but this might change
-      // @ts-ignore
-      gas: 500_000_000n,
+      allowFailure: false,
+      gas: 550_000_000n,
+      batchSize: 0, // we cannot have price updates and compressor request in different batches
     });
 
+    const markets = resp.pop() as MarketData[];
+
     for (const data of markets) {
       this.#markets.upsert(
         data.pool.baseParams.addr,

src/sdk/market/pricefeeds/AbstractPriceFeed.ts

@@ -1,4 +1,4 @@
-import type { Abi, UnionOmit } from "viem";
+import type { Abi, RequiredBy, UnionOmit } from "viem";
 
 import { ilpPriceFeedAbi } from "../../abi";
 import type { PriceFeedTreeNode } from "../../base";
@@ -8,8 +8,13 @@ import type { PriceFeedStateHuman } from "../../types";
 import { PriceFeedRef } from "./PriceFeedRef";
 import type { IPriceFeedContract, PriceFeedContractType } from "./types";
 
+export type PartialPriceFeedTreeNode = RequiredBy<
+  Partial<PriceFeedTreeNode>,
+  "baseParams"
+>;
+
 export type PriceFeedConstructorArgs<abi extends Abi | readonly unknown[]> =
-  PriceFeedTreeNode & {
+  PartialPriceFeedTreeNode & {
     abi: abi;
     name: string;
   };
@@ -23,10 +28,11 @@ export abstract class AbstractPriceFeedContract<
   /**
    * True if the contract deployed at this address implements IUpdatablePriceFeed interface
    */
-  public readonly updatable: boolean;
-  public readonly decimals: number;
-  public readonly underlyingPriceFeeds: PriceFeedRef[];
-  public readonly skipCheck: boolean;
+  #updatable?: boolean;
+  #decimals?: number;
+  #underlyingPriceFeeds?: readonly PriceFeedRef[];
+  #skipCheck?: boolean;
+
   public hasLowerBoundCap = false;
 
   constructor(sdk: GearboxSDK, args: PriceFeedConstructorArgs<abi>) {
@@ -37,13 +43,52 @@ export abstract class AbstractPriceFeedContract<
       contractType: args.baseParams.contractType,
       version: args.baseParams.version,
     });
-    this.decimals = args.decimals;
-    this.updatable = args.updatable;
-    this.skipCheck = args.skipCheck;
-    this.underlyingPriceFeeds = args.underlyingFeeds.map(
-      (address, i) =>
-        new PriceFeedRef(this.sdk, address, args.underlyingStalenessPeriods[i]),
-    );
+    this.#decimals = args.decimals;
+    this.#updatable = args.updatable;
+    this.#skipCheck = args.skipCheck;
+
+    if (args.underlyingFeeds && args.underlyingStalenessPeriods) {
+      this.#underlyingPriceFeeds = args.underlyingFeeds.map(
+        (address, i) =>
+          new PriceFeedRef(
+            this.sdk,
+            address,
+            args.underlyingStalenessPeriods![i],
+          ),
+      );
+    }
+  }
+
+  public get loaded(): boolean {
+    return this.#decimals !== undefined;
+  }
+
+  public get decimals(): number {
+    if (this.#decimals === undefined) {
+      throw new Error("price feed has been initialized with BaseParams only");
+    }
+    return this.#decimals;
+  }
+
+  public get updatable(): boolean {
+    if (this.#updatable === undefined) {
+      throw new Error("price feed has been initialized with BaseParams only");
+    }
+    return this.#updatable;
+  }
+
+  public get skipCheck(): boolean {
+    if (this.#skipCheck === undefined) {
+      throw new Error("price feed has been initialized with BaseParams only");
+    }
+    return this.#skipCheck;
+  }
+
+  public get underlyingPriceFeeds(): readonly PriceFeedRef[] {
+    if (!this.#underlyingPriceFeeds) {
+      throw new Error("price feed has been initialized with BaseParams only");
+    }
+    return this.#underlyingPriceFeeds;
   }
 
   public get priceFeedType(): PriceFeedContractType {

src/sdk/market/pricefeeds/BalancerStablePriceFeed.ts

@@ -1,12 +1,12 @@
 import { bptStablePriceFeedAbi, iBalancerStablePoolAbi } from "../../abi";
-import type { PriceFeedTreeNode } from "../../base";
 import type { GearboxSDK } from "../../GearboxSDK";
 import { AbstractLPPriceFeedContract } from "./AbstractLPPriceFeed";
+import type { PartialPriceFeedTreeNode } from "./AbstractPriceFeed";
 
 type abi = typeof bptStablePriceFeedAbi;
 
 export class BalancerStablePriceFeedContract extends AbstractLPPriceFeedContract<abi> {
-  constructor(sdk: GearboxSDK, args: PriceFeedTreeNode) {
+  constructor(sdk: GearboxSDK, args: PartialPriceFeedTreeNode) {
     super(sdk, {
       ...args,
       name: "BalancerStablePriceFeed",

src/sdk/market/pricefeeds/BalancerWeightedPriceFeed.ts

@@ -1,12 +1,12 @@
 import { bptWeightedPriceFeedAbi, iBalancerWeightedPoolAbi } from "../../abi";
-import type { PriceFeedTreeNode } from "../../base";
 import type { GearboxSDK } from "../../GearboxSDK";
 import { AbstractLPPriceFeedContract } from "./AbstractLPPriceFeed";
+import type { PartialPriceFeedTreeNode } from "./AbstractPriceFeed";
 
 type abi = typeof bptWeightedPriceFeedAbi;
 
 export class BalancerWeightedPriceFeedContract extends AbstractLPPriceFeedContract<abi> {
-  constructor(sdk: GearboxSDK, args: PriceFeedTreeNode) {
+  constructor(sdk: GearboxSDK, args: PartialPriceFeedTreeNode) {
     super(sdk, {
       ...args,
       name: "BalancerWeighedPriceFeed",

src/sdk/market/pricefeeds/BoundedPriceFeed.ts

@@ -1,15 +1,15 @@
 import { boundedPriceFeedAbi } from "../../abi";
-import type { PriceFeedTreeNode } from "../../base";
 import type { GearboxSDK } from "../../GearboxSDK";
 import type { BoundedOracleStateHuman } from "../../types";
+import type { PartialPriceFeedTreeNode } from "./AbstractPriceFeed";
 import { AbstractPriceFeedContract } from "./AbstractPriceFeed";
 
 type abi = typeof boundedPriceFeedAbi;
 
 export class BoundedPriceFeedContract extends AbstractPriceFeedContract<abi> {
   upperBound = 0n;
 
-  constructor(sdk: GearboxSDK, args: PriceFeedTreeNode) {
+  constructor(sdk: GearboxSDK, args: PartialPriceFeedTreeNode) {
     super(sdk, { ...args, name: "BoundedPriceFeed", abi: boundedPriceFeedAbi });
   }
 

src/sdk/market/pricefeeds/ChainlinkPriceFeed.ts

@@ -1,12 +1,12 @@
 import { chainlinkReadableAggregatorAbi } from "../../abi";
-import type { PriceFeedTreeNode } from "../../base";
 import type { GearboxSDK } from "../../GearboxSDK";
+import type { PartialPriceFeedTreeNode } from "./AbstractPriceFeed";
 import { AbstractPriceFeedContract } from "./AbstractPriceFeed";
 
 type abi = typeof chainlinkReadableAggregatorAbi;
 
 export class ChainlinkPriceFeedContract extends AbstractPriceFeedContract<abi> {
-  constructor(sdk: GearboxSDK, args: PriceFeedTreeNode) {
+  constructor(sdk: GearboxSDK, args: PartialPriceFeedTreeNode) {
     super(sdk, {
       ...args,
       name: "ChainlinkPriceFeed",

src/sdk/market/pricefeeds/CompositePriceFeed.ts

@@ -1,18 +1,17 @@
 import { compositePriceFeedAbi } from "../../abi";
-import type { PriceFeedTreeNode } from "../../base";
 import type { GearboxSDK } from "../../GearboxSDK";
+import type { PartialPriceFeedTreeNode } from "./AbstractPriceFeed";
 import { AbstractPriceFeedContract } from "./AbstractPriceFeed";
 import type { PriceFeedRef } from "./PriceFeedRef";
 
 type abi = typeof compositePriceFeedAbi;
 
 export class CompositePriceFeedContract extends AbstractPriceFeedContract<abi> {
-  constructor(sdk: GearboxSDK, args: PriceFeedTreeNode) {
+  constructor(sdk: GearboxSDK, args: PartialPriceFeedTreeNode) {
     super(sdk, {
       ...args,
       name: "CompositePriceFeed",
       abi: compositePriceFeedAbi,
-      decimals: 8,
     });
   }
 

src/sdk/market/pricefeeds/CurveCryptoPriceFeed.ts

@@ -1,12 +1,12 @@
 import { curveCryptoLpPriceFeedAbi, iCurvePoolAbi } from "../../abi";
-import type { PriceFeedTreeNode } from "../../base";
 import type { GearboxSDK } from "../../GearboxSDK";
 import { AbstractLPPriceFeedContract } from "./AbstractLPPriceFeed";
+import type { PartialPriceFeedTreeNode } from "./AbstractPriceFeed";
 
 type abi = typeof curveCryptoLpPriceFeedAbi;
 
 export class CurveCryptoPriceFeedContract extends AbstractLPPriceFeedContract<abi> {
-  constructor(sdk: GearboxSDK, args: PriceFeedTreeNode) {
+  constructor(sdk: GearboxSDK, args: PartialPriceFeedTreeNode) {
     super(sdk, {
       ...args,
       name: "CurveCryptoPriceFeed",