Skip to content

Commit 1ec8b15

Browse files
committed
check for proper QBuffer initialization
1 parent 97d87bd commit 1ec8b15

1 file changed

Lines changed: 13 additions & 1 deletion

File tree

src/cache.cpp

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1782,12 +1782,24 @@ void Cache::addResource(Resource &resource, GameEntry &entry,
17821782
}
17831783
QByteArray resizedData;
17841784
QBuffer b(&resizedData);
1785-
b.open(QIODevice::WriteOnly);
1785+
// Qt 5.15.18 on NixOS 25.11
1786+
if (!b.open(QIODevice::WriteOnly)) {
1787+
qWarning() << "Opening WriteOnly buffer failed with"
1788+
<< b.openMode();
1789+
}
17861790
if ((image.hasAlphaChannel() && hasAlpha(image)) ||
17871791
resource.type == "screenshot") {
17881792
addedToCache = image.save(&b, "png");
1793+
if (!addedToCache)
1794+
qWarning()
1795+
<< "Save to buffer as PNG failed. Data not "
1796+
"written to cache.";
17891797
} else {
17901798
addedToCache = image.save(&b, "jpg", config.jpgQuality);
1799+
if (!addedToCache)
1800+
qWarning()
1801+
<< "Save to buffer as JPG failed. Data not "
1802+
"written to cache.";
17911803
}
17921804
b.close();
17931805
if (imageData->size() > resizedData.size()) {

0 commit comments

Comments
 (0)