added tracerbullets to identify edgecase (#236)

Author: Gemba

src/cli.cpp

@@ -559,7 +559,7 @@ void Cli::showHint() {
 #endif
     hint = "DID YOU KNOW: " + hint;
     QString hintWrapped = StrTools::wrapText(hint);
-    hintWrapped = hintWrapped.replace(" KNOW: "," KNOW\033[0m: ");
+    hintWrapped = hintWrapped.replace(" KNOW: ", " KNOW\033[0m: ");
     printf("\033[1;33m%s\n\n", hintWrapped.toStdString().c_str());
 }
 

src/esde.cpp

@@ -29,6 +29,7 @@
 #include <QStringBuilder>
 #include <QStringList>
 #include <QTemporaryFile>
+#include <QTextStream>
 
 static const QRegularExpression RE_ALT_EMU =
     QRegularExpression("(<alternativeEmulator>)(.*?)(</"
@@ -84,26 +85,31 @@ bool Esde::loadOldGameList(const QString &gameListFileString) {
             }
             QFile invalidXmlFile = QFile(tmpFn);
             if (invalidXmlFile.open(QIODevice::ReadOnly) &&
-                esDeGamelist.open(QIODevice::ReadWrite | QIODevice::Text)) {
+                esDeGamelist.open(QIODevice::WriteOnly)) {
                 // create a standard compliant XML
                 QString part;
+                QTextStream esDeOut(&esDeGamelist);
                 bool replaced = false;
                 while (!invalidXmlFile.atEnd()) {
                     part = invalidXmlFile.read(4096);
                     if (QString tmpPart = part.remove(RE_ALT_EMU);
                         !replaced && tmpPart.length() != part.length()) {
                         replaced = true;
-                        part = tmpPart;
-                    };
-                    esDeGamelist.write(part.toStdString().c_str(),
-                                       part.length());
+                        esDeOut << tmpPart;
+                    } else {
+                        esDeOut << part;
+                    }
                 }
                 esDeGamelist.close();
                 invalidXmlFile.close();
                 qDebug() << "Gamelist now XML compliant, removed temporarily:"
                          << altEmu;
             }
+#ifdef QT_NO_DEBUG_OUTPUT
             invalidXmlFile.remove();
+#else
+            qDebug() << "Original ES-DE Gamelist retained in file" << tmpFn;
+#endif
         }
     }
     if (gameListReader.setFile(gameListFileString)) {

src/xmlreader.cpp

@@ -52,9 +52,17 @@ bool XmlReader::setFile(QString filename) {
 #endif
             result = true;
         } else {
+#ifdef QT_NO_DEBUG_OUTPUT
             qWarning() << "XML error:" << eMsg << "at line" << eLine;
         }
         f.close();
+#else
+            qCritical() << "File" << filename << " has an XML error:" << eMsg
+                        << "at line" << eLine;
+            f.close();
+            exit(1);
+        }
+#endif
     }
     return result;
 }