Extra fixes, based on code review

* Fix MARQUEE entry in retroarch.h
* Add more negative tests to testSupportedMedia
* Remove unnecessary path check in frontendExtra read

Author: SineSwiper

src/retroarch.cpp

@@ -162,16 +162,13 @@ void RetroArch::assembleList(QString &finalOutput,
 
     if (!config->frontendExtra.isEmpty()) {
         // frontendExtra is used for default_core_path and default_core_name
-        // when it contains a path separator (/). Format:
-        // "<CORE_PATH>;<CORE_NAME>"
-        if (config->frontendExtra.contains("/")) {
-            QStringList parts = config->frontendExtra.split(";");
-            if (parts.length() >= 1) {
-                corePathStr = parts[0];
-            }
-            if (parts.length() >= 2) {
-                coreNameStr = parts[1];
-            }
+        // Format: "<CORE_PATH>;<CORE_NAME>"
+        QStringList parts = config->frontendExtra.split(";");
+        if (parts.length() >= 1) {
+            corePathStr = parts[0];
+        }
+        if (parts.length() >= 2) {
+            coreNameStr = parts[1];
         }
     }
 
@@ -268,4 +265,4 @@ QString RetroArch::getWheelsFolder() {
 QString RetroArch::getTitleScreenshotsFolder() {
     return config->mediaFolder % "/Named_Titles";
 }
-*/
+*/

src/retroarch.h

@@ -46,7 +46,7 @@ class RetroArch : public AbstractFrontend {
 
     GameEntry::Types supportedMedia() override {
         return GameEntry::Types(GameEntry::COVER | GameEntry::SCREENSHOT |
-                                GameEntry::WHEEL);
+                                GameEntry::MARQUEE | GameEntry::WHEEL);
     }
 
 protected:

test/retroarch/test_retroarch.cpp

@@ -246,6 +246,9 @@ private slots:
 
         // Should NOT support MANUAL, TEXTURE, FANART, BACKCOVER
         QVERIFY(!(supported & GameEntry::MANUAL));
+        QVERIFY(!(supported & GameEntry::TEXTURE));
+        QVERIFY(!(supported & GameEntry::FANART));
+        QVERIFY(!(supported & GameEntry::BACKCOVER));
     }
 
     // Test frontend capabilities flags through public interface
@@ -388,4 +391,4 @@ private slots:
 };
 
 QTEST_MAIN(TestRetroArch)
-#include "test_retroarch.moc"
+#include "test_retroarch.moc"