Implements #208 and testcase

Author: Gemba

src/pegasus.cpp

@@ -365,13 +365,14 @@ void Pegasus::replaceColon(QString &value, const QString &gameTitle) {
         // PENDING: use sliced() instead of mid() when Qt5
         // is no longer supported (ie. RetroPie moved away from Buster)
         ctxStr = ctxStr % value.mid(begin, end - begin) % endStr;
-        value.replace(idx, 1, ".");
-        qWarning() << QString(
-                          "Description of '%1' contains a colon (:) at '%2', "
-                          "Skyscraper replaced it with '.'. Consider "
-                          "editing the description to remediate this warning.")
-                          .arg(gameTitle)
-                          .arg(ctxStr);
+        const QChar modColon = QChar(0xa789);
+        value.replace(idx, 1, modColon);
+        qInfo() << QString("Description of '%1' contains a colon (:) at '%2', "
+                           "Skyscraper replaced it with '%3' (UTF-8 Modified "
+                           "Letter Colon).")
+                       .arg(gameTitle)
+                       .arg(ctxStr)
+                       .arg(modColon);
         idx = value.indexOf(':');
     }
 }

src/pegasus.h

@@ -58,6 +58,9 @@ class Pegasus : public AbstractFrontend {
             GameEntry::MARQUEE | GameEntry::SCREENSHOT | GameEntry::TEXTURE |
             GameEntry::VIDEO | GameEntry::WHEEL);
     }
+#ifdef TESTING
+    void replaceColon(QString &value, const QString &gameTitle);
+#endif
 
 private:
     QString makeAbsolute(const QString &filePath, const QString &inputFolder);
@@ -66,7 +69,9 @@ class Pegasus : public AbstractFrontend {
     QString toPegasusFormat(const QString &key, const QString &value);
     QString addMediaFile(const QString &asset, bool useRelativePath,
                          QString mediaFile);
+#ifndef TESTING
     void replaceColon(QString &value, const QString &gameTitle);
+#endif
     QString getFilename(const QString &path);
 
     QMap<QString, QString> headerPairs;

test/pegasus/.gitignore

@@ -0,0 +1,4 @@
+Makefile
+test_pegasus
+*.o
+*.moc

test/pegasus/test_pegasus.cpp

@@ -0,0 +1,28 @@
+#include "pegasus.h"
+
+#include <QDebug>
+#include <QTest>
+
+class TestPegasus : public QObject {
+    Q_OBJECT
+
+private:
+    Settings settings;
+    Pegasus *frontend;
+
+private slots:
+    void initTestCase(){};
+
+    void testReplaceColon() {
+        frontend = new Pegasus();
+        QString in = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, "
+                     "sed do eiusmod tempor incididunt ut labore et dolore "
+                     "magna aliqua: Ut enim ad minim veniam.";
+        QString exp = QString(in).replace(":", QChar(0xa789));
+        frontend->replaceColon(in, "Didelum");
+        QCOMPARE(in, exp);
+    }
+};
+
+QTEST_MAIN(TestPegasus)
+#include "test_pegasus.moc"

test/pegasus/test_pegasus.pro

@@ -0,0 +1,30 @@
+QT += core network testlib
+TEMPLATE = app
+TARGET = test_pegasus
+DEPENDPATH += .
+INCLUDEPATH += ../../src
+CONFIG += debug
+QT += core network xml
+QMAKE_CXXFLAGS += -std=c++17
+
+CONFIG(release, debug|release):DEFINES += QT_NO_DEBUG_OUTPUT
+PREFIX = /usr/local
+DEFINES+=PREFIX=\\\"$$PREFIX\\\"
+
+include(../../VERSION.ini)
+DEFINES+=TESTING
+DEFINES+=VERSION=\\\"$$VERSION\\\"
+
+HEADERS += ../../src/pegasus.h \
+           ../../src/abstractfrontend.h \
+           ../../src/config.h \
+           ../../src/gameentry.h \
+           ../../src/platform.h
+
+SOURCES += test_pegasus.cpp \
+           ../../src/pegasus.cpp \
+           ../../src/abstractfrontend.cpp \
+           ../../src/config.cpp \
+           ../../src/gameentry.cpp \
+           ../../src/platform.cpp
+