feat(silo): fix clang-tidy configs (no comment allowed in checks), error on warnings in CMake clang-tidy option

Author: anna-parker

.clang-tidy

@@ -1,6 +1,6 @@
 ---
 WarningsAsErrors: "*"
-Checks: >
+Checks: >-
   -*,
   abseil-*,
   bugprone-*,
@@ -12,7 +12,6 @@ Checks: >
   readability-*,
   performance-*,
   readability-magic-numbers,
-# clang-analyzer-cplusplus.NewDeleteLeaks TODO(#632) readd
   -misc-non-private-member-variables-in-classes,
   -misc-include-cleaner,
   -google-readability-avoid-underscore-in-googletest-name,

CMakeLists.txt

@@ -101,7 +101,7 @@ if (NOT CMAKE_BUILD_TYPE STREQUAL Release AND BUILD_WITH_CLANG_TIDY)
     else ()
         message(STATUS "clang-tidy found: ${CLANG_TIDY_EXE}")
         message(STATUS "run clang tidy with: ${CLANG_TIDY_EXE}")
-        set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_EXE}")
+        set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_EXE};--warnings-as-errors=*")
     endif ()
 endif ()