-
Notifications
You must be signed in to change notification settings - Fork 0
Frontend TODOs #95
Copy link
Copy link
Open
Description
Description
A rough rework of the frontend has been completed, but there are a few outstanding TODOs that need to be addressed. They are listed below in order of importance. Work top down and report what you were able to get to in the PR (The ones at the very bottom are more minor and do not need to get done right now)
One blocker to this is that we have a bunch of visualizations that are still sitting in feature branches.
TODO List
- Hooks Permission Scoping: Currently the
useGetAllAthletesanduseGetAllRunsreturn everything and do not scope to the current coach. Theoretically, this is not something that needs to change on the frontend. The endpoints themselves should have context of who is making the request based on the supplied bearer token in the request. The result of this change should be that you only see seed data when logged in as the dev user, and see no data/athletes when logged in as a google user - Record Page submission: Currently, when I go to record a run and press submit, it just loops me back to the record form. The behavior should instead take me to the results of this run. Verify as well that the run is even created by this. Obviously, because no data is collected, The visualizations won't have any data. This is ok, we just need to ensure that the run is being created at all.
- Run analysis page UI improvement: The following photo shows the run analysis page. It appears really scrunched. The back button and header should be in the top left of the page. For the visualizations, decide if you want to either expand them to fill the screen, or create a grid so we see two side by side if there's enough space. Additionally, the Step-By-Step data is kind of useless and can probably just be removed.
- Visualization Differentiation: Right now, every run has the same 3 visualizations. We should instead have visualizations specific per run type (i.e. add the hurdle visualizations to their page).
- General Width on Desktop View: similar to the fix for the run analysis page (that one is priority), most all of the pages don't actually fill the space. I've attached the history page below as an example. For most all of these pages we should align our CSS patterns to make them utilize all of the space better.
- General Verbage correction: We use the word "run" all over the place and it's very general. We want to narrow in the definition and specifically say "sprint" or "hurdle" when needed.
- Logo Fix: Right now, the logo is a single PNG with the Foot and words "StrideTrack". This png should be cropped to just be the foot, and the text should be separate. The logo appears in the Login page and the Sidebar. In the sidebar, we probably don't even need the text "StrideTrack" and can just have the logo. Idk, play around with this.
- Add Favicon: Once the logo is correct, we can turn the Flying foot thing into a favicon. You can use a favicon generator to give you all of the different images and then there's just some configuration in our
index.html; Chat can describe where to put the images and how to set this up. I've used this site in the past: https://favicon.io/. - Add OG Image: Google what this is, it's pretty cool. This is the image that's used when you share a URL on different platforms (like slack or iMessage). We want to set ours to just be Stridetrack in Big letters with our logo and some colors/design or smth.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels