-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathrooms_test.go
More file actions
387 lines (307 loc) · 11.9 KB
/
rooms_test.go
File metadata and controls
387 lines (307 loc) · 11.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
package handler
import (
"context"
"errors"
"io"
"net/http/httptest"
"strings"
"testing"
"github.com/generate/selfserve/internal/errs"
"github.com/generate/selfserve/internal/models"
"github.com/gofiber/fiber/v2"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
type mockRoomsRepository struct {
findRoomsFunc func(ctx context.Context, filter *models.RoomFilters, hotelID string, cursorRoomNumber int) ([]*models.RoomWithOptionalGuestBooking, error)
findFloorsFunc func(ctx context.Context, hotelID string) ([]int, error)
}
func (m *mockRoomsRepository) FindRoomsWithOptionalGuestBookingsByFloor(ctx context.Context, filter *models.RoomFilters, hotelID string, cursorRoomNumber int) ([]*models.RoomWithOptionalGuestBooking, error) {
return m.findRoomsFunc(ctx, filter, hotelID, cursorRoomNumber)
}
func (m *mockRoomsRepository) FindAllFloors(ctx context.Context, hotelID string) ([]int, error) {
return m.findFloorsFunc(ctx, hotelID)
}
var _ RoomsRepository = (*mockRoomsRepository)(nil)
const testHotelID = "00000000-0000-0000-0000-000000000001"
func TestRoomsHandler_FilterRooms(t *testing.T) {
t.Parallel()
t.Run("returns 200 with rooms and no guests when rooms are vacant", func(t *testing.T) {
t.Parallel()
mock := &mockRoomsRepository{
findRoomsFunc: func(ctx context.Context, filter *models.RoomFilters, hotelID string, cursorRoomNumber int) ([]*models.RoomWithOptionalGuestBooking, error) {
return []*models.RoomWithOptionalGuestBooking{
{
Room: models.Room{RoomNumber: 101, Floor: 1, SuiteType: "standard", RoomStatus: "available"},
Guests: nil,
},
}, nil
},
}
app := fiber.New()
h := NewRoomsHandler(mock)
app.Post("/rooms", h.FilterRooms)
req := httptest.NewRequest("POST", "/rooms", strings.NewReader(`{}`))
req.Header.Set("Content-Type", "application/json")
req.Header.Set(hotelIDHeader, testHotelID)
resp, err := app.Test(req)
require.NoError(t, err)
assert.Equal(t, 200, resp.StatusCode)
body, _ := io.ReadAll(resp.Body)
assert.Contains(t, string(body), `"items"`)
assert.Contains(t, string(body), "101")
assert.Contains(t, string(body), "standard")
assert.Contains(t, string(body), `"has_more":false`)
})
t.Run("returns 200 with rooms including guest details when occupied", func(t *testing.T) {
t.Parallel()
jane := "Jane"
doe := "Doe"
pic := "https://example.com/jane.jpg"
mock := &mockRoomsRepository{
findRoomsFunc: func(ctx context.Context, filter *models.RoomFilters, hotelID string, cursorRoomNumber int) ([]*models.RoomWithOptionalGuestBooking, error) {
return []*models.RoomWithOptionalGuestBooking{
{
Room: models.Room{RoomNumber: 202, Floor: 2, SuiteType: "deluxe", RoomStatus: "occupied"},
Guests: []models.Guest{
{
ID: "530e8400-e458-41d4-a716-446655440000",
CreateGuest: models.CreateGuest{
FirstName: jane,
LastName: doe,
ProfilePicture: &pic,
},
},
},
},
}, nil
},
}
app := fiber.New()
h := NewRoomsHandler(mock)
app.Post("/rooms", h.FilterRooms)
req := httptest.NewRequest("POST", "/rooms", strings.NewReader(`{"floors":[2]}`))
req.Header.Set("Content-Type", "application/json")
req.Header.Set(hotelIDHeader, testHotelID)
resp, err := app.Test(req)
require.NoError(t, err)
assert.Equal(t, 200, resp.StatusCode)
body, _ := io.ReadAll(resp.Body)
assert.Contains(t, string(body), `"items"`)
assert.Contains(t, string(body), "202")
assert.Contains(t, string(body), "530e8400-e458-41d4-a716-446655440000")
assert.Contains(t, string(body), "Jane")
assert.Contains(t, string(body), "Doe")
})
t.Run("returns 200 with empty items when no rooms match filters", func(t *testing.T) {
t.Parallel()
mock := &mockRoomsRepository{
findRoomsFunc: func(ctx context.Context, filter *models.RoomFilters, hotelID string, cursorRoomNumber int) ([]*models.RoomWithOptionalGuestBooking, error) {
return []*models.RoomWithOptionalGuestBooking{}, nil
},
}
app := fiber.New()
h := NewRoomsHandler(mock)
app.Post("/rooms", h.FilterRooms)
req := httptest.NewRequest("POST", "/rooms", strings.NewReader(`{"floors":[99]}`))
req.Header.Set("Content-Type", "application/json")
req.Header.Set(hotelIDHeader, testHotelID)
resp, err := app.Test(req)
require.NoError(t, err)
assert.Equal(t, 200, resp.StatusCode)
body, _ := io.ReadAll(resp.Body)
assert.Contains(t, string(body), `"items":[]`)
assert.Contains(t, string(body), `"has_more":false`)
})
t.Run("returns has_more true and next_cursor when repo returns limit+1 items", func(t *testing.T) {
t.Parallel()
rooms := make([]*models.RoomWithOptionalGuestBooking, 6) // limit=5, repo returns 6
for i := range rooms {
rooms[i] = &models.RoomWithOptionalGuestBooking{
Room: models.Room{RoomNumber: 100 + i, Floor: 1, SuiteType: "standard", RoomStatus: "available"},
}
}
mock := &mockRoomsRepository{
findRoomsFunc: func(ctx context.Context, filter *models.RoomFilters, hotelID string, cursorRoomNumber int) ([]*models.RoomWithOptionalGuestBooking, error) {
return rooms, nil
},
}
app := fiber.New()
h := NewRoomsHandler(mock)
app.Post("/rooms", h.FilterRooms)
req := httptest.NewRequest("POST", "/rooms", strings.NewReader(`{"limit":5}`))
req.Header.Set("Content-Type", "application/json")
req.Header.Set(hotelIDHeader, testHotelID)
resp, err := app.Test(req)
require.NoError(t, err)
assert.Equal(t, 200, resp.StatusCode)
body, _ := io.ReadAll(resp.Body)
assert.Contains(t, string(body), `"has_more":true`)
assert.Contains(t, string(body), `"next_cursor"`)
})
t.Run("passes cursor, filter, and hotelID to repository", func(t *testing.T) {
t.Parallel()
var capturedFilter *models.RoomFilters
var capturedHotelID string
var capturedCursor int
mock := &mockRoomsRepository{
findRoomsFunc: func(ctx context.Context, filter *models.RoomFilters, hotelID string, cursorRoomNumber int) ([]*models.RoomWithOptionalGuestBooking, error) {
capturedFilter = filter
capturedHotelID = hotelID
capturedCursor = cursorRoomNumber
return []*models.RoomWithOptionalGuestBooking{}, nil
},
}
app := fiber.New()
h := NewRoomsHandler(mock)
app.Post("/rooms", h.FilterRooms)
req := httptest.NewRequest("POST", "/rooms", strings.NewReader(`{"cursor":"200","limit":10}`))
req.Header.Set("Content-Type", "application/json")
req.Header.Set(hotelIDHeader, testHotelID)
resp, err := app.Test(req)
require.NoError(t, err)
assert.Equal(t, 200, resp.StatusCode)
require.NotNil(t, capturedFilter)
assert.Equal(t, 10, capturedFilter.Limit)
assert.Equal(t, testHotelID, capturedHotelID)
assert.Equal(t, 200, capturedCursor)
})
t.Run("returns 400 when hotel_id header is missing", func(t *testing.T) {
t.Parallel()
mock := &mockRoomsRepository{
findRoomsFunc: func(ctx context.Context, filter *models.RoomFilters, hotelID string, cursorRoomNumber int) ([]*models.RoomWithOptionalGuestBooking, error) {
return nil, nil
},
}
app := fiber.New(fiber.Config{ErrorHandler: errs.ErrorHandler})
h := NewRoomsHandler(mock)
app.Post("/rooms", h.FilterRooms)
req := httptest.NewRequest("POST", "/rooms", strings.NewReader(`{}`))
req.Header.Set("Content-Type", "application/json")
resp, err := app.Test(req)
require.NoError(t, err)
assert.Equal(t, 400, resp.StatusCode)
})
t.Run("returns 400 when hotel_id header is invalid", func(t *testing.T) {
t.Parallel()
mock := &mockRoomsRepository{
findRoomsFunc: func(ctx context.Context, filter *models.RoomFilters, hotelID string, cursorRoomNumber int) ([]*models.RoomWithOptionalGuestBooking, error) {
return nil, nil
},
}
app := fiber.New(fiber.Config{ErrorHandler: errs.ErrorHandler})
h := NewRoomsHandler(mock)
app.Post("/rooms", h.FilterRooms)
req := httptest.NewRequest("POST", "/rooms", strings.NewReader(`{}`))
req.Header.Set("Content-Type", "application/json")
req.Header.Set(hotelIDHeader, "not-a-uuid")
resp, err := app.Test(req)
require.NoError(t, err)
assert.Equal(t, 400, resp.StatusCode)
})
// invalid cursor is handled in repository now; handler does not validate cursor
t.Run("returns 500 when repository fails", func(t *testing.T) {
t.Parallel()
mock := &mockRoomsRepository{
findRoomsFunc: func(ctx context.Context, filter *models.RoomFilters, hotelID string, cursorRoomNumber int) ([]*models.RoomWithOptionalGuestBooking, error) {
return nil, errors.New("db error")
},
}
app := fiber.New(fiber.Config{ErrorHandler: errs.ErrorHandler})
h := NewRoomsHandler(mock)
app.Post("/rooms", h.FilterRooms)
req := httptest.NewRequest("POST", "/rooms", strings.NewReader(`{}`))
req.Header.Set("Content-Type", "application/json")
req.Header.Set(hotelIDHeader, testHotelID)
resp, err := app.Test(req)
require.NoError(t, err)
assert.Equal(t, 500, resp.StatusCode)
})
t.Run("returns 400 when request body is invalid json", func(t *testing.T) {
t.Parallel()
mock := &mockRoomsRepository{
findRoomsFunc: func(ctx context.Context, filter *models.RoomFilters, hotelID string, cursorRoomNumber int) ([]*models.RoomWithOptionalGuestBooking, error) {
return nil, nil
},
}
app := fiber.New(fiber.Config{ErrorHandler: errs.ErrorHandler})
h := NewRoomsHandler(mock)
app.Post("/rooms", h.FilterRooms)
req := httptest.NewRequest("POST", "/rooms", strings.NewReader(`{`))
req.Header.Set("Content-Type", "application/json")
req.Header.Set(hotelIDHeader, testHotelID)
resp, err := app.Test(req)
require.NoError(t, err)
assert.Equal(t, 400, resp.StatusCode)
})
}
func TestRoomsHandler_GetFloors(t *testing.T) {
t.Parallel()
t.Run("returns 200 with floors", func(t *testing.T) {
t.Parallel()
mock := &mockRoomsRepository{
findFloorsFunc: func(ctx context.Context, hotelID string) ([]int, error) {
return []int{1, 2, 3}, nil
},
}
app := fiber.New(fiber.Config{ErrorHandler: errs.ErrorHandler})
h := NewRoomsHandler(mock)
app.Get("/rooms/floors", h.GetFloors)
req := httptest.NewRequest("GET", "/rooms/floors", nil)
req.Header.Set(hotelIDHeader, testHotelID)
resp, err := app.Test(req)
require.NoError(t, err)
assert.Equal(t, 200, resp.StatusCode)
body, _ := io.ReadAll(resp.Body)
assert.Contains(t, string(body), `1`)
assert.Contains(t, string(body), `2`)
assert.Contains(t, string(body), `3`)
})
t.Run("returns 400 when hotel_id header is missing", func(t *testing.T) {
t.Parallel()
mock := &mockRoomsRepository{
findFloorsFunc: func(ctx context.Context, hotelID string) ([]int, error) {
return []int{}, nil
},
}
app := fiber.New(fiber.Config{ErrorHandler: errs.ErrorHandler})
h := NewRoomsHandler(mock)
app.Get("/rooms/floors", h.GetFloors)
req := httptest.NewRequest("GET", "/rooms/floors", nil)
resp, err := app.Test(req)
require.NoError(t, err)
assert.Equal(t, 400, resp.StatusCode)
})
t.Run("returns 400 when hotel_id header is invalid", func(t *testing.T) {
t.Parallel()
mock := &mockRoomsRepository{
findFloorsFunc: func(ctx context.Context, hotelID string) ([]int, error) {
return []int{}, nil
},
}
app := fiber.New(fiber.Config{ErrorHandler: errs.ErrorHandler})
h := NewRoomsHandler(mock)
app.Get("/rooms/floors", h.GetFloors)
req := httptest.NewRequest("GET", "/rooms/floors", nil)
req.Header.Set(hotelIDHeader, "not-a-uuid")
resp, err := app.Test(req)
require.NoError(t, err)
assert.Equal(t, 400, resp.StatusCode)
})
t.Run("returns 500 when repository fails", func(t *testing.T) {
t.Parallel()
mock := &mockRoomsRepository{
findFloorsFunc: func(ctx context.Context, hotelID string) ([]int, error) {
return nil, errors.New("db error")
},
}
app := fiber.New(fiber.Config{ErrorHandler: errs.ErrorHandler})
h := NewRoomsHandler(mock)
app.Get("/rooms/floors", h.GetFloors)
req := httptest.NewRequest("GET", "/rooms/floors", nil)
req.Header.Set(hotelIDHeader, testHotelID)
resp, err := app.Test(req)
require.NoError(t, err)
assert.Equal(t, 500, resp.StatusCode)
})
}