Skip to content

Commit 025dcec

Browse files
committed
Require 'taichi>=1.7.4'.
1 parent e8d4b33 commit 025dcec

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

.github/workflows/production.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ jobs:
6767
bash -c "
6868
pip install --extra-index-url https://pypi.nvidia.com/ omniverse-kit && \
6969
pip install -e '.[dev,render,usd]' && \
70-
pytest -v --debug --forked ./tests
70+
pytest -v --dev --forked ./tests
7171
"
7272
7373
- name: Run benchmarks

genesis/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,8 +211,7 @@ def init(
211211
with redirect_stdout(_ti_outputs):
212212
ti.init(
213213
arch=ti_arch,
214-
# Debug mode was buggy and causing segfault prior to v1.7.4
215-
debug=debug and ti.__version__ >= (1, 7, 4),
214+
debug=debug,
216215
check_out_of_bound=debug,
217216
# force_scalarize_matrix=True for speeding up kernel compilation
218217
# Turning off 'force_scalarize_matrix' is causing numerical instabilities ('nan') on MacOS

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ readme = "README.md"
1010
requires-python = ">=3.10,<3.14"
1111
dependencies = [
1212
"psutil",
13-
"taichi >= 1.7.2",
13+
# Taichi debug mode has been fixed in 1.7.4
14+
"taichi >= 1.7.4",
1415
"pydantic >= 2.7.1",
1516
"numpy >= 1.26.4",
1617
"trimesh",

tests/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def pytest_addoption(parser):
148148
"--logical", action="store_true", default=False, help="Consider logical cores in default number of workers."
149149
)
150150
parser.addoption("--vis", action="store_true", default=False, help="Enable interactive viewer.")
151-
parser.addoption("--debug", action="store_true", default=False, help="Enable genesis debug mode.")
151+
parser.addoption("--dev", action="store_true", default=False, help="Enable genesis debug mode.")
152152

153153

154154
@pytest.fixture(scope="session")
@@ -277,7 +277,7 @@ def initialize_genesis(request, backend, taichi_offline_cache):
277277
from genesis.utils.misc import ALLOCATE_TENSOR_WARNING
278278

279279
logging_level = request.config.getoption("--log-cli-level")
280-
debug = request.config.getoption("--debug")
280+
debug = request.config.getoption("--dev")
281281
precision = "64" if backend == gs.cpu else "32"
282282

283283
try:

tests/test_render.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def test_segmentation(segmentation_level, particle_mode):
118118

119119

120120
@pytest.mark.required
121-
@pytest.mark.flaky(reruns=3, condition=(sys.platform == "darwin"), reason="Flaky on MacOS with CPU-based OpenGL")
121+
@pytest.mark.xfail(sys.platform == "darwin", reason="Flaky on MacOS with CPU-based OpenGL")
122122
def test_batched_offscreen_rendering(tmp_path, show_viewer, tol):
123123
scene = gs.Scene(
124124
vis_options=gs.options.VisOptions(
@@ -275,7 +275,7 @@ def test_batched_offscreen_rendering(tmp_path, show_viewer, tol):
275275

276276

277277
@pytest.mark.required
278-
@pytest.mark.flaky(reruns=3, condition=(sys.platform == "darwin"), reason="Flaky on MacOS with CPU-based OpenGL")
278+
@pytest.mark.xfail(sys.platform == "darwin", reason="Flaky on MacOS with CPU-based OpenGL")
279279
def test_render_api(show_viewer):
280280
scene = gs.Scene(
281281
show_viewer=show_viewer,

tests/test_rigid_physics.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -528,7 +528,7 @@ def test_rope_ball(gs_sim, mj_sim, gs_solver, tol):
528528
gs_sim.rigid_solver.set_dofs_position(gs_sim.rigid_solver.get_dofs_position())
529529

530530
check_mujoco_model_consistency(gs_sim, mj_sim, tol=tol)
531-
simulate_and_check_mujoco_consistency(gs_sim, mj_sim, num_steps=300, tol=5e-9)
531+
simulate_and_check_mujoco_consistency(gs_sim, mj_sim, num_steps=300, tol=1e-8)
532532

533533

534534
@pytest.mark.required

0 commit comments

Comments
 (0)