Skip to content

Commit 7b29170

Browse files
authored
[BUG FIX] Fix viewer not closed at scene destroy if running in background thread. (#2236)
1 parent fae1db4 commit 7b29170

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

genesis/ext/pyrender/viewer.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1358,8 +1358,9 @@ def start(self, auto_refresh=True):
13581358
try:
13591359
self.refresh()
13601360
except AttributeError:
1361-
# The graphical window has been closed
1362-
self.on_close()
1361+
# The graphical window has been closed manually
1362+
pass
1363+
self.on_close()
13631364
else:
13641365
self.refresh()
13651366

@@ -1373,8 +1374,9 @@ def run(self):
13731374
try:
13741375
self.refresh()
13751376
except AttributeError:
1376-
# The graphical window has been closed
1377-
self.on_close()
1377+
# The graphical window has been closed manually
1378+
pass
1379+
self.on_close()
13781380

13791381
def refresh(self):
13801382
viewer_thread = self._thread or threading.main_thread()

0 commit comments

Comments
 (0)