Skip to content

Commit b16cab4

Browse files
Milotrinceduburcqa
authored andcommitted
fix set_gravity - review comments
1 parent 3d115cf commit b16cab4

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

genesis/engine/solvers/base_solver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def build(self):
4242
@gs.assert_built
4343
def set_gravity(self, gravity, envs_idx=None):
4444
if self._gravity is None:
45-
gs.logger.warning("Gravity is not initialized, skipping set_gravity.")
45+
gs.logger.debug("Gravity is not defined, skipping `set_gravity`.")
4646
return
4747
g = np.asarray(gravity, dtype=gs.np_float)
4848
if envs_idx is None:

tests/test_rigid_physics.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2191,22 +2191,21 @@ def test_gravity(show_viewer, tol):
21912191
with np.testing.assert_raises(AssertionError):
21922192
scene.sim.set_gravity(torch.tensor([[0.0, 0.0, -10.0], [0.0, 0.0, -10.0]]), envs_idx=1)
21932193

2194-
for _ in range(10):
2195-
scene.step()
2194+
scene.step()
21962195

21972196
assert_allclose(
21982197
np.array(
21992198
[
22002199
[0.0, 0.0, 0.0],
22012200
[0.0, 0.0, 0.0],
2201+
[0.0, 0.0, -10.0],
2202+
[0.0, 0.0, 100.0],
22022203
[0.0, 0.0, -1.0],
2203-
[0.0, 0.0, 10.0],
2204-
[0.0, 0.0, -0.1],
2205-
[-0.2, 0.0, 0.0],
2206-
[-0.2, 0.0, 0.0],
2204+
[-2.0, 0.0, 0.0],
2205+
[-2.0, 0.0, 0.0],
22072206
]
22082207
),
2209-
sphere.get_vel(),
2208+
sphere.get_links_acc().squeeze(dim=1),
22102209
tol=tol,
22112210
)
22122211

0 commit comments

Comments
 (0)