Bad thumbnail handling

[etj]

Expected Behavior

• A single thumbnail file should be generated when a Resource is created.
• The thumbnail file should be removed when the Resource is deleted.

Actual Behavior

When a Document is created, two files are created, e.g.:

-rw-r--r-- 1 root root 17135 Jul 16 07:11 document-886bda39-8560-40b2-b9a0-66104147b254-thumb-e5a132a7-57b7-43d2-bcf0-52d4af6fe3e0.jpg
-rw-r--r-- 1 root root 17135 Jul 16 07:11 document-886bda39-8560-40b2-b9a0-66104147b254-thumb-e5a132a7-57b7-43d2-bcf0-52d4af6fe3e0_3ClS2qX.jpg

When the Document is removed, the files are kept.

Other Resource types should be checked.

Steps to Reproduce the Problem

1. Create a Document
2. Check the thumbnail dir for files containing the resource UUID
3. Remove the Document
4. Check if the files still exist (they do)

Specifications

• GeoNode version: master (as of 20240716)

[mattiagiupponi]

The thumb is saved twice. The first time here:

geonode/geonode/base/models.py

Line 1555 in 4b6d872

actual_name = storage_manager.save(upload_path, ContentFile(image))

Then again after cropping:

geonode/geonode/base/models.py

Lines 1574 to 1576 in 4b6d872

	with open(tmp_location, "rb+") as img:
	# Saving the img via storage manager
	storage_manager.save(storage_manager.path(upload_path), img)

This is valid for all the resources not only documents. Still to be analyzed why is not deleted

[mattiagiupponi]

tested, cannot reproduce on master