Skip to content

refactor to have a geometry type for each feature. #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor to have a geometry type for each feature. #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 61 additions & 8 deletions doc/world_builder_declarations.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,15 +170,15 @@
"items": {
"defaultSnippets": [
{
"label": "add a 'continental plate'",
"label": "add a 'continental plate coordinates'",
"body": {
"model": "continental plate",
"name": "${1:My Plate}",
"coordinates": []
}
},
{
"label": "add a 'fault'",
"label": "add a 'fault coordinates'",
"body": {
"model": "fault",
"name": "${1:My Fault}",
Expand All @@ -188,7 +188,7 @@
}
},
{
"label": "add a 'mantle layer'",
"label": "add a 'mantle layer coordinates'",
"body": {
"model": "mantle layer",
"name": "${1:My Mantle Layer}",
Expand All @@ -198,7 +198,7 @@
}
},
{
"label": "add a 'oceanic plate'",
"label": "add a 'oceanic plate coordinates'",
"body": {
"model": "oceanic plate",
"name": "${1:My Oceanic Plate}",
Expand All @@ -208,17 +208,17 @@
}
},
{
"label": "add a 'plume'",
"label": "add a 'plume coordinates'",
"body": {
"model": "plume",
"name": "${1:My Plume}",
"name": "${1:My PlumeCoordinates}",
"coordinates": [],
"temperature models": [],
"composition models": []
}
},
{
"label": "add a 'subducting plate'",
"label": "add a 'subducting plate coordinates'",
"body": {
"model": "subducting plate",
"name": "${1:My Subducting Plate}",
Expand All @@ -245,6 +245,14 @@
"continental plate"
]
},
"geometry type": {
"default value": "coordinates",
"type": "string",
"description": "The model geometry type",
"enum": [
"coordinates"
]
},
"name": {
"default value": "",
"type": "string",
Expand Down Expand Up @@ -1787,6 +1795,15 @@
"fault"
]
},
"geometry type": {
"default value": "coordinates",
"type": "string",
"description": "The model geometry type",
"enum": [
"coordinates",
"coordinates"
]
},
"name": {
"default value": "",
"type": "string",
Expand Down Expand Up @@ -4713,6 +4730,15 @@
"mantle layer"
]
},
"geometry type": {
"default value": "coordinates",
"type": "string",
"description": "The model geometry type",
"enum": [
"coordinates",
"coordinates"
]
},
"name": {
"default value": "",
"type": "string",
Expand Down Expand Up @@ -6098,6 +6124,15 @@
"oceanic plate"
]
},
"geometry type": {
"default value": "coordinates",
"type": "string",
"description": "The model geometry type",
"enum": [
"coordinates",
"coordinates"
]
},
"name": {
"default value": "",
"type": "string",
Expand Down Expand Up @@ -8151,7 +8186,7 @@
},
{
"type": "object",
"description": "Plume object. Requires properties `model` and `coordinates`.",
"description": "PlumeCoordinates object. Requires properties `model` and `coordinates`.",
"additionalProperties": false,
"required": [
"model"
Expand All @@ -8165,6 +8200,15 @@
"plume"
]
},
"geometry type": {
"default value": "coordinates",
"type": "string",
"description": "The model geometry type",
"enum": [
"coordinates",
"coordinates"
]
},
"name": {
"default value": "",
"type": "string",
Expand Down Expand Up @@ -8770,6 +8814,15 @@
"subducting plate"
]
},
"geometry type": {
"default value": "coordinates",
"type": "string",
"description": "The model geometry type",
"enum": [
"coordinates",
"coordinates"
]
},
"name": {
"default value": "",
"type": "string",
Expand Down
56 changes: 55 additions & 1 deletion doc/world_builder_declarations_closed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,15 @@
- **enum**:[continental plate]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/1/geometry type
:name: closed_features_items_oneOf_1_geometry-type

- **default value**:coordinates
- **type**:string
- **description**:The model geometry type
- **enum**:[coordinates]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/1/name
:name: closed_features_items_oneOf_1_name

Expand Down Expand Up @@ -2631,6 +2640,15 @@
- **enum**:[fault]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/2/geometry type
:name: closed_features_items_oneOf_2_geometry-type

- **default value**:coordinates
- **type**:string
- **description**:The model geometry type
- **enum**:[coordinates, coordinates]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/2/name
:name: closed_features_items_oneOf_2_name

Expand Down Expand Up @@ -6660,6 +6678,15 @@
- **enum**:[mantle layer]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/3/geometry type
:name: closed_features_items_oneOf_3_geometry-type

- **default value**:coordinates
- **type**:string
- **description**:The model geometry type
- **enum**:[coordinates, coordinates]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/3/name
:name: closed_features_items_oneOf_3_name

Expand Down Expand Up @@ -8802,6 +8829,15 @@
- **enum**:[oceanic plate]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/4/geometry type
:name: closed_features_items_oneOf_4_geometry-type

- **default value**:coordinates
- **type**:string
- **description**:The model geometry type
- **enum**:[coordinates, coordinates]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/4/name
:name: closed_features_items_oneOf_4_name

Expand Down Expand Up @@ -11987,7 +12023,7 @@
:name: closed_features_items_oneOf_5

- **type**:object
- **description**:Plume object. Requires properties `model` and `coordinates`.
- **description**:PlumeCoordinates object. Requires properties `model` and `coordinates`.
- **additionalProperties**:false
- **required**:[model]

Expand All @@ -12000,6 +12036,15 @@
- **enum**:[plume]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/5/geometry type
:name: closed_features_items_oneOf_5_geometry-type

- **default value**:coordinates
- **type**:string
- **description**:The model geometry type
- **enum**:[coordinates, coordinates]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/5/name
:name: closed_features_items_oneOf_5_name

Expand Down Expand Up @@ -12842,6 +12887,15 @@
- **enum**:[subducting plate]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/6/geometry type
:name: closed_features_items_oneOf_6_geometry-type

- **default value**:coordinates
- **type**:string
- **description**:The model geometry type
- **enum**:[coordinates, coordinates]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/6/name
:name: closed_features_items_oneOf_6_name

Expand Down
62 changes: 61 additions & 1 deletion doc/world_builder_declarations_open.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,16 @@
- **enum**:[continental plate]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/1/geometry type
:open:
:name: open_features_items_oneOf_1_geometry-type

- **default value**:coordinates
- **type**:string
- **description**:The model geometry type
- **enum**:[coordinates]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/1/name
:open:
:name: open_features_items_oneOf_1_name
Expand Down Expand Up @@ -2979,6 +2989,16 @@
- **enum**:[fault]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/2/geometry type
:open:
:name: open_features_items_oneOf_2_geometry-type

- **default value**:coordinates
- **type**:string
- **description**:The model geometry type
- **enum**:[coordinates, coordinates]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/2/name
:open:
:name: open_features_items_oneOf_2_name
Expand Down Expand Up @@ -7473,6 +7493,16 @@
- **enum**:[mantle layer]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/3/geometry type
:open:
:name: open_features_items_oneOf_3_geometry-type

- **default value**:coordinates
- **type**:string
- **description**:The model geometry type
- **enum**:[coordinates, coordinates]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/3/name
:open:
:name: open_features_items_oneOf_3_name
Expand Down Expand Up @@ -9901,6 +9931,16 @@
- **enum**:[oceanic plate]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/4/geometry type
:open:
:name: open_features_items_oneOf_4_geometry-type

- **default value**:coordinates
- **type**:string
- **description**:The model geometry type
- **enum**:[coordinates, coordinates]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/4/name
:open:
:name: open_features_items_oneOf_4_name
Expand Down Expand Up @@ -13514,7 +13554,7 @@
:name: open_features_items_oneOf_5

- **type**:object
- **description**:Plume object. Requires properties `model` and `coordinates`.
- **description**:PlumeCoordinates object. Requires properties `model` and `coordinates`.
- **additionalProperties**:false
- **required**:[model]

Expand All @@ -13528,6 +13568,16 @@
- **enum**:[plume]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/5/geometry type
:open:
:name: open_features_items_oneOf_5_geometry-type

- **default value**:coordinates
- **type**:string
- **description**:The model geometry type
- **enum**:[coordinates, coordinates]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/5/name
:open:
:name: open_features_items_oneOf_5_name
Expand Down Expand Up @@ -14467,6 +14517,16 @@
- **enum**:[subducting plate]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/6/geometry type
:open:
:name: open_features_items_oneOf_6_geometry-type

- **default value**:coordinates
- **type**:string
- **description**:The model geometry type
- **enum**:[coordinates, coordinates]
::::::::::::::::::::

::::::::::::::::::::{dropdown} /features/items/oneOf/6/name
:open:
:name: open_features_items_oneOf_6_name
Expand Down
Loading
Loading