Commit b5eabe1
nesquena-hermes
fix(nesquena#3920): apply Codex gate findings — observe #msgInner, instance-owned RO cleanup, restore .messages overflow-anchor
Codex SHIP-ONLY-WITH-FIXES (3 real issues; Codex+Opus disagreed on #1, stricter wins):
1. CORE — .messages lost overflow-anchor:none, reopening the nesquena#1360 (d21c972) streaming-scroll-anchor regression. Restored it (native anchoring stays OFF; the RO does the settle). Opus had judged this removal acceptable; took Codex's stricter call.
2. SILENT — the ResizeObserver observed #messages (the scroll container, fixed by flex layout, never resizes) instead of #msgInner (.messages-inner, the growing transcript node) → callback would never fire. Now observes #msgInner.
3. SILENT — stale RO callbacks mutated the global _settleRO, which could disconnect a newer active observer after settle re-entry. Now instance-owned: close over const ro, only clear the global when _settleRO===ro.1 parent f9055c5 commit b5eabe1
2 files changed
Lines changed: 17 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1588 | 1588 | | |
1589 | 1589 | | |
1590 | 1590 | | |
1591 | | - | |
| 1591 | + | |
1592 | 1592 | | |
1593 | 1593 | | |
1594 | 1594 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3139 | 3139 | | |
3140 | 3140 | | |
3141 | 3141 | | |
3142 | | - | |
3143 | | - | |
3144 | | - | |
| 3142 | + | |
| 3143 | + | |
| 3144 | + | |
| 3145 | + | |
| 3146 | + | |
| 3147 | + | |
| 3148 | + | |
| 3149 | + | |
| 3150 | + | |
| 3151 | + | |
| 3152 | + | |
3145 | 3153 | | |
3146 | | - | |
| 3154 | + | |
3147 | 3155 | | |
3148 | 3156 | | |
3149 | 3157 | | |
| |||
3158 | 3166 | | |
3159 | 3167 | | |
3160 | 3168 | | |
3161 | | - | |
| 3169 | + | |
3162 | 3170 | | |
3163 | 3171 | | |
3164 | 3172 | | |
3165 | | - | |
| 3173 | + | |
| 3174 | + | |
3166 | 3175 | | |
3167 | 3176 | | |
3168 | 3177 | | |
| |||
3173 | 3182 | | |
3174 | 3183 | | |
3175 | 3184 | | |
3176 | | - | |
| 3185 | + | |
3177 | 3186 | | |
3178 | 3187 | | |
3179 | 3188 | | |
| |||
0 commit comments