Enhance PDF generation logic and improve alternateFormats check in workflows

Author: pasibun

.github/workflows/build.yml

@@ -24,15 +24,21 @@ jobs:
             vnu --errors-only --skip-non-html --format json /site/snapshot.html \
             | tee $CHECK_DIR/html-validation.json
 
-
-      - name: Check for alternateFormats
+      - name: Check for alternateFormats via Node
         id: config
         run: |
-          echo "grep=false" >> $GITHUB_OUTPUT
-          if grep -q 'alternateFormats' ./js/config.js; then
-            if grep -Pzoq 'alternateFormats:\s*\[\s*\{\s*label:\s*".+?",\s*uri:\s*".+?"\s*\}\s*\]' ./js/config.js; then
-              echo "grep=true" >> $GITHUB_OUTPUT
-            fi
+          # Maak config require-baar
+          cp ./js/config.js config.js
+          echo "module.exports = { respecConfig };" >> config.js
+
+          # Laat Node bepalen of er een PDF entry is (en exitcode gebruiken)
+          if node -e "const {respecConfig}=require('./config.js');
+            const ok = Array.isArray(respecConfig.alternateFormats)
+              && respecConfig.alternateFormats.some(f => f && f.label==='pdf' && f.uri);
+            if (!ok) process.exit(1);" ; then
+            echo "grep=true" >> $GITHUB_OUTPUT
+          else
+            echo "grep=false" >> $GITHUB_OUTPUT
           fi
 
       - name: Copy pdf.js if needed
@@ -46,7 +52,7 @@ jobs:
           echo "module.exports = { respecConfig };" >> config.js
           echo "var window = {respecMermaid:{createFigures:null}};" | cat - config.js > temp && mv temp config.js
           npm install puppeteer
-          python3 -m http.server 8080 &
+          python3 -m http.server 8081 &
           rm -f *.pdf
           node pdf.js
           mv *.pdf static/
@@ -126,4 +132,4 @@ jobs:
             static/*.pdf
             media/**/*
             js/**/*
-            data/**/*
+            data/**/*

.github/workflows/pdf.js

@@ -1,40 +1,37 @@
-const config = require('./config.js');
+const config = require("./config.js");
 
 const alternateFormats = config.respecConfig.alternateFormats;
 if (alternateFormats === undefined) {
-    console.warn("\'alternateFormats\' not found.");
-}
-else {
-    const found = alternateFormats.find(element => element.label === "pdf");
-    if (found === undefined) {
-        console.warn("PDF not selected as alternate format.");
-    }
-    else if (found.uri === undefined) {
-        console.warn("PDF file name (\'uri\') missing.");
-    }
-    else {
-        const name = found.uri;
-        console.log("Printing PDF with name: " + name);
+  console.warn("'alternateFormats' not found.");
+} else {
+  const found = alternateFormats.find((element) => element.label === "pdf");
+  if (found === undefined) {
+    console.warn("PDF not selected as alternate format.");
+  } else if (found.uri === undefined) {
+    console.warn("PDF file name ('uri') missing.");
+  } else {
+    const name = found.uri;
+    console.log("Printing PDF with name: " + name);
 
-        // The following is based on code from
-        // https://www.bannerbear.com/blog/how-to-convert-html-into-pdf-with-node-js-and-puppeteer/
-        const puppeteer = require('puppeteer');
+    const puppeteer = require("puppeteer");
 
-        (async () => {
-            const browser = await puppeteer.launch();
-            const page = await browser.newPage();
-            const website_url = 'http://localhost:8080/snapshot.html';
-            await page.goto(website_url, { waitUntil: 'networkidle0' });
-            await page.emulateMediaType('print');
-            await page.addStyleTag({ content: '.sidelabel {position: absolute}' })
-            const pdf = await page.pdf({
-                path: name,
-                margin: { top: '100px', right: '50px', bottom: '100px', left: '50px' },
-                printBackground: true,
-                format: 'A4',
-            });
+    (async () => {
+      const browser = await puppeteer.launch({
+        args: ["--no-sandbox", "--disable-setuid-sandbox"],
+      });
+      const page = await browser.newPage();
+      const website_url = "http://localhost:8081/snapshot.html";
+      await page.goto(website_url, { waitUntil: "networkidle0" });
+      await page.emulateMediaType("print");
+      await page.addStyleTag({ content: ".sidelabel {position: absolute}" });
+      const pdf = await page.pdf({
+        path: name,
+        margin: { top: "100px", right: "50px", bottom: "100px", left: "50px" },
+        printBackground: true,
+        format: "A4",
+      });
 
-            await browser.close();
-        })();
-    }
+      await browser.close();
+    })();
+  }
 }