Skip to content

Commit 9646eea

Browse files
committed
Manage accels for remaining dialogs and windows.
1 parent 0e9a95e commit 9646eea

File tree

6 files changed

+47
-4
lines changed

6 files changed

+47
-4
lines changed

src/Application.vala

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -370,6 +370,14 @@ namespace Tuba {
370370
set_accels_for_action ("app.scroll-page-to-top", {});
371371
}
372372

373+
public void enable_home_accel () {
374+
set_accels_for_action ("app.scroll-page-to-top", {"Home"});
375+
}
376+
377+
public void disable_home_accel () {
378+
set_accels_for_action ("app.scroll-page-to-top", {});
379+
}
380+
373381
private void on_proxy_change (bool recover = false) {
374382
if (settings.proxy != "") {
375383
try {
@@ -675,6 +683,11 @@ namespace Tuba {
675683
// Static functions seem to avoid this peculiar behavior.
676684
// dialog.translator_credits = Build.TRANSLATOR != " " ? Build.TRANSLATOR : null;
677685
686+
app.disable_window_accels ();
687+
app.disable_nav_accels ();
688+
689+
dialog.closed.connect (on_about_closed);
690+
678691
dialog.present (main_window);
679692
680693
GLib.Idle.add (() => {
@@ -685,6 +698,11 @@ namespace Tuba {
685698
});
686699
}
687700
701+
public void on_about_closed () {
702+
app.enable_window_accels ();
703+
app.enable_nav_accels ();
704+
}
705+
688706
public Adw.AlertDialog inform (string text, string? msg = null) {
689707
var dlg = new Adw.AlertDialog (
690708
text,

src/Dialogs/NewAccount.vala

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,23 @@ public class Tuba.Dialogs.NewAccount: Adw.Window {
6262
manual_auth_label.activate_link.connect (on_manual_auth);
6363

6464
reset ();
65+
66+
app.disable_window_accels ();
67+
app.disable_nav_accels ();
68+
69+
this.close_request.connect (on_new_account_closed);
70+
6571
present ();
6672
instance_entry.grab_focus ();
6773
}
6874

75+
public bool on_new_account_closed () {
76+
app.enable_window_accels ();
77+
app.enable_nav_accels ();
78+
79+
return false;
80+
}
81+
6982
private void add_toast (string content, uint timeout = 0) {
7083
toast_overlay.add_toast (new Adw.Toast (content) {
7184
timeout = timeout

src/Dialogs/Preferences.vala

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,8 @@ public class Tuba.Dialogs.Preferences : Adw.PreferencesDialog {
205205
setup_notification_mutes ();
206206
setup_filters ();
207207
bind ();
208+
app.disable_window_accels ();
209+
app.disable_nav_accels ();
208210
closed.connect (on_window_closed);
209211
}
210212

@@ -393,6 +395,9 @@ public class Tuba.Dialogs.Preferences : Adw.PreferencesDialog {
393395

394396
if (settings.analytics) app.update_analytics.begin ();
395397
app.update_contributors.begin ();
398+
399+
app.enable_window_accels ();
400+
app.enable_nav_accels ();
396401
}
397402

398403
protected class AnalyticsDialog : Adw.Dialog {

src/Dialogs/ProfileEdit.vala

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
[GtkTemplate (ui = "/dev/geopjr/Tuba/ui/dialogs/profile_edit.ui")]
22
public class Tuba.Dialogs.ProfileEdit : Adw.Dialog {
33
~ProfileEdit () {
4+
app.enable_window_accels ();
5+
app.enable_nav_accels ();
6+
47
debug (@"Destroying ProfileEdit for $(profile.handle)");
58
}
69

@@ -106,6 +109,10 @@ public class Tuba.Dialogs.ProfileEdit : Adw.Dialog {
106109
cepbtn.visible = true;
107110
bio_row.bind_property ("expanded", cepbtn, "sensitive", GLib.BindingFlags.SYNC_CREATE);
108111
}
112+
113+
app.disable_window_accels ();
114+
app.disable_nav_accels ();
115+
109116
}
110117

111118
protected void update_style_scheme () {

src/Views/Lists.vala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,11 +251,11 @@ public class Tuba.Views.Lists : Views.Timeline {
251251
}
252252

253253
private void on_entry_focus_enter () {
254-
app.disable_nav_accels ();
254+
app.disable_home_accel ();
255255
}
256256

257257
private void on_entry_focus_leave () {
258-
app.enable_nav_accels ();
258+
app.enable_home_accel ();
259259
}
260260

261261
~Lists () {

src/Views/Search.vala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,11 @@ public class Tuba.Views.Search : Views.TabbedBase {
6161
}
6262

6363
private void on_entry_focus_enter () {
64-
app.disable_nav_accels ();
64+
app.disable_home_accel ();
6565
}
6666

6767
private void on_entry_focus_leave () {
68-
app.enable_nav_accels ();
68+
app.enable_home_accel ();
6969
}
7070

7171
private void on_entry_activated () {

0 commit comments

Comments
 (0)