Don't create user commands

[axkirillov]

Hi! I love this plugin, and I think it is the best of out of several trying to integrate aider into nvim.

I have extended it with my own commands, but I have to use workarounds because some core functionality is not exported. Like, for example, consider this user command:

		local terminal = require("nvim_aider.terminal")

		vim.api.nvim_create_user_command(
			"RunTestInAider",
			function()
				local filename = vim.fn.expand('%:t:r')
				local filepath = vim.fn.expand('%')
				terminal.send(
					"/add " .. filepath,
					config,
					false
				)
				terminal.send(
					"/run ./test.sh " .. filename,
					config,
					false
				)
				terminal.toggle()
			end,
			{}
		)

I would prefer an add_file() funtion to be available that takes a filepath, or just grabs current file, if empty
Same, for the send. Besides, I need to provide terminal config each time, because accessing the terminal directly, I bypass the config I passed to nvim_aider already.
This seems to be an issue with other functionality as well where, instead of lua api, user commands are provided, which is less flexible than a lua api would be.
Furthermore, I am generally in favor of the approach of plugins not creating user commands for the user. It pollutes the user's commands list with commands that they might not need. Instead, I find it nice, when plugins only provide a lua api, such as, or example the snacks terminal plugin which you use. Users can create their own command then, and can be provided with an example config to do so.
Let me know what you think, and I would be happy to provide PRs.

[GeorgesAlkhouri]

Hey there! Thanks for bringing this up.

I was also unhappy with the exposed Lua api so I’ll definitely bump that up in priority.

I still think user commands are valuable for a quick entry point, but I agree there can be too many. My plan is to consolidate them into a single user command with subcommands.

Config passing was also on my backlog!

I really appreciate your feedback. If you want to open a PR, feel free, and I’ll be happy to review it!

[axkirillov]

I still think user commands are valuable for a quick entry point, but I agree there can be too many. My plan is to consolidate them into a single user command with subcommands.

Actually I agree, having one main command with subcommands is a nice pattern.

[axkirillov]

I created a PR with a small refactor, it exports one of the functions that I would like to use. Just to demonstrate what I mean. If you are fine with this approach we can then go forward and export more functions.
#37

[GeorgesAlkhouri]

just to clarify, why to you need to pass config every time you all send. You could also adjust the config one time during setup call.

  		terminal.send(
  			"/add " .. filepath,
  			config,
  			false
  		)

Besides, I need to provide terminal config each time, because accessing the terminal directly, I bypass the config I passed to nvim_aider already.

[axkirillov]

I think when I use the terminal like this local terminal = require("nvim_aider.terminal") it does not use the config from the setup. That's why I specify it there all the time.

[axkirillov]

Ah, it's a mistake on my part. I placed the require call before the setup.

[axkirillov]

But see, if I use the lua api from my PR, such a thing wouldn't happen.