Skip to content

Relative paths break submit-pyrosar-gamma-workflow using --output-dir #161

Description

@truth-quark

There's a small bug with the submit-pyrosar-gamma-workflow utility. If using --output-dir <some-path> with a relative path, the workflow can break. This is shown in the error logs with an OSError like this:

  File "/g/data/yp75/<userid>/miniforge3/envs/sar-pipeline/lib/python3.12/site-packages/pyroSAR/gamma/error.py", line 71, in gammaErrorHandler
    raise errortype(err_out)
OSError: cannot open output data file: 20260318-13h45m34s-multi/data/temp/S1A__EW___A_20250419T221041/S1A_EW_GRDM_1SSH_20250419T221041_20250419T221148_058831_074A60_9416

This doesn't point to the cause being a relative path. Ideally, users should be prevented or at least warned specifically.

Tasks:

  • Update markdown docs, ask users to specify absolute paths
  • Update CLI docs to ask users to specify absolute paths
  • Determine what happens when reading output_dir var from the .toml config file
  • Add defensive code & fail fast if relative paths are used for --output-dir

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdocumentationImprovements or additions to documentationenhancementNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions