Skip to content

Commit a5b572d

Browse files
author
Gertjan Reynaert
authored
Merge pull request #87 from karify/fix/translation-and-whitelist-filepaths
Fix the path to translation and whitelist files so they can easily be renamed
2 parents d05e06e + 8d9338b commit a5b572d

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ The following keys are restricted and will be overridden by the core: `report`,
272272

273273
#### provideTranslationsFile
274274
```js
275-
const translationsFile = provideTranslationsFile(lang);
275+
const translationsFile = provideTranslationsFile(languageResults);
276276
```
277277

278278
Here you should return the translations for the specified language. This must be an object with the message id and message in a key value format.
@@ -284,7 +284,7 @@ const translationsFile = {
284284

285285
#### provideWhitelistFile
286286
```js
287-
const whitelistFile = provideWhitelistFile(lang);
287+
const whitelistFile = provideWhitelistFile(languageResults);
288288
```
289289

290290
Here you should return the whitelisted messsage ids for the specified language. This must be an array of strings.

src/core.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ export default (languages, hooks) => {
2727
languages.forEach(lang => {
2828
const langResults = provideLangTemplate(lang);
2929

30-
const file = provideTranslationsFile(lang);
31-
const whitelistFile = provideWhitelistFile(lang);
30+
const file = provideTranslationsFile(langResults);
31+
const whitelistFile = provideWhitelistFile(langResults);
3232

3333
if (!file) langResults.noTranslationFile = true;
3434
if (!whitelistFile) langResults.noWhitelistFile = true;

src/manageTranslations.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -116,15 +116,13 @@ export default ({
116116
};
117117
},
118118

119-
provideTranslationsFile: lang => {
120-
const filePath = Path.join(translationsDirectory, `${lang}.json`);
121-
const jsonFile = readFile(filePath);
119+
provideTranslationsFile: langResults => {
120+
const jsonFile = readFile(langResults.languageFilepath);
122121
return jsonFile ? JSON.parse(jsonFile) : undefined;
123122
},
124123

125-
provideWhitelistFile: lang => {
126-
const filePath = Path.join(whitelistsDirectory, `whitelist_${lang}.json`);
127-
const jsonFile = readFile(filePath);
124+
provideWhitelistFile: langResults => {
125+
const jsonFile = readFile(langResults.whitelistFilepath);
128126
return jsonFile ? JSON.parse(jsonFile) : undefined;
129127
},
130128

0 commit comments

Comments
 (0)