Commit 6cfdd27
Matthew
ci: say which busbar branch we mean, instead of '<number>/merge'
On a pull_request event `github.ref_name` is '<number>/merge', not a branch name,
so plugin-ci asked GetBusbar/busbar for a branch called '5/merge' and the sibling
checkout died with 'The process /usr/bin/git failed with exit code 1', naming
neither the ref nor the reason. Every pull request to this repo has been red on
that before running a line of the change it was testing.
`github.base_ref` is the branch the PR targets and is empty on a push, so this
means dev-against-dev and main-against-main as intended on both events.
plugin-ci.yml also now falls back with a loud warning when a ref cannot be
resolved, so this is belt and braces - but a caller should say what it means
rather than lean on a fallback.1 parent 0002c6f commit 6cfdd27
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
22 | 25 | | |
23 | 26 | | |
24 | 27 | | |
| |||
0 commit comments