Skip to content

Commit cdafe55

Browse files
committed
debug: repoint the fixed leg at the thread-lifetime commit
The RTLD_NODELETE leg is removed rather than kept as a third arm: it does not just fail, it returns the WRONG PLUGIN'S IMAGE from the signature-verified load path, and a soak that treats that as a comparison point invites someone to read its crash count as the only thing wrong with it. The leg-identity probe now counts ffi_thread references instead, so a green fixed leg still cannot be a leg that checked out the wrong tree.
1 parent 3a43aed commit cdafe55

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

.github/workflows/segv-soak-x86.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,12 @@ jobs:
2525
# UNFIXED: the exact pin the wild crashes were seen on.
2626
- leg: control
2727
busbar_ref: eac13fa3fecdd21ab3530751016a0c956e7e27b5
28-
# FIXED: the RTLD_NODELETE commit on fix/1.6.0-mysql-e2e-segv.
28+
# FIXED: the thread-lifetime commit on fix/1.6.0-plugin-thread-lifetime. Plugin code runs
29+
# only on loader-owned workers that never retire, so no thread carrying plugin TLS ever
30+
# exits. (The withdrawn RTLD_NODELETE leg is deliberately gone — it returned the wrong
31+
# plugin's image and must never be a comparison point again.)
2932
- leg: fixed
30-
busbar_ref: c015ca466c4dc5e34153c2f5ab309f95866cdf7e
33+
busbar_ref: 225e9e176ac17d6f147174aa40d82bc2172440a6
3134
name: ${{ matrix.leg }}
3235
services:
3336
mysql:
@@ -59,7 +62,8 @@ jobs:
5962
echo "leg=${{ matrix.leg }} busbar_ref=${{ matrix.busbar_ref }}"
6063
# The one line that distinguishes the two legs, printed so a green run cannot be
6164
# mistaken for a leg that silently checked out the wrong tree.
62-
grep -c RTLD_NODELETE busbarAI/crates/plugin-loader/src/lib.rs || echo "0 (unfixed loader)"
65+
echo -n "ffi_thread references in the loader: "
66+
grep -c ffi_thread busbarAI/crates/plugin-loader/src/lib.rs || echo "0 (unfixed loader)"
6367
6468
- uses: dtolnay/rust-toolchain@stable
6569

0 commit comments

Comments
 (0)