Commit 19f91e2
committed
ci: the destructive-wipe job could go green having run nothing
Two independent ways this job's only real assertion could vanish silently.
1. `cargo test <filter>` is a SUBSTRING match with NO floor. Rename the test --
dropping just `the_` from `wipes_the_entire_namespace_destructively` is
enough -- and the filter matches zero tests:
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
exit status 0
The job goes green, having stood up a dedicated valkey/valkey:8 service
container to run nothing at all, and because the test is `#[ignore]`d no other
job covers it either. The step now asserts `test result: ok. 1 passed`, so a
rename fails loudly instead of quietly deleting the coverage.
Deliberately NOT `--exact`: the `1 passed` floor is the load-bearing half and
cannot break on a guess about the module path.
2. `plugin_path()` in the plugin's e2e tests was the only one of the ten sibling
plugin repos without the `is_none() && CI -> panic!()` guard -- while
`valkey_url()` seventeen lines below it in the same file has it. Demonstrated
rather than assumed, with the cdylib absent:
running 3 tests
test admin_api_installs_the_valkey_plugin_and_writes_land_in_real_valkey ... ok
test load_and_exercise_valkey_plugin_bad_config_fails_over_abi ... ok
test load_and_exercise_valkey_plugin_persists_to_real_valkey_across_reopen ... ok
test result: ok. 3 passed; ... finished in 0.00s
Three tests "passed" in 0.00s without their subject existing. It now checks
both the uplifted target dir and target/deps (a bare `cargo test` uplifts to
neither for this crate), and refuses to skip under CI.1 parent fa9ead1 commit 19f91e2
3 files changed
Lines changed: 60 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
49 | 77 | | |
50 | 78 | | |
51 | 79 | | |
| |||
0 commit comments