Skip to content

Commit 2b14f8a

Browse files
committed
refactor: simplify drain cleanup check in add_track_subscriber
Single None check on the tuple instead of checking each element.
1 parent 2d07fff commit 2b14f8a

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

getstream/video/rtc/pc.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -208,14 +208,13 @@ def add_track_subscriber(
208208
"""Add a new subscriber to an existing track's MediaRelay."""
209209
track_data = self.track_map.get(track_id)
210210

211-
blackhole, drain_task, drain_proxy = self._video_drains.pop(
212-
track_id, (None, None, None)
213-
)
211+
video_drain = self._video_drains.pop(track_id, None)
214212

215-
if blackhole and drain_task and drain_proxy:
213+
if video_drain is not None:
214+
blackhole, drain_task, drain_proxy = video_drain
216215
task = asyncio.create_task(blackhole.stop())
217216
drain_proxy.stop()
218-
drain_task.cancel() # safety net if start() becomes long-lived in future aiortc
217+
drain_task.cancel()
219218
self._background_tasks.add(task)
220219
task.add_done_callback(self._background_tasks.discard)
221220

0 commit comments

Comments
 (0)