Documentation improvements, add converter for enchantable component

Author: eclipseisoffline

api/src/main/java/org/geysermc/geyser/api/item/custom/v2/CustomItemDefinition.java

@@ -111,16 +111,19 @@ public interface CustomItemDefinition {
      * <p>Currently, the following components are supported:</p>
      *
      * <ul>
-     *     <li>{@code minecraft:consumable}</li>
-     *     <li>{@code minecraft:equippable}</li>
-     *     <li>{@code minecraft:food}</li>
-     *     <li>{@code minecraft:max_damage}</li>
-     *     <li>{@code minecraft:max_stack_size}</li>
-     *     <li>{@code minecraft:use_cooldown}</li>
+     *     <li>{@code minecraft:consumable} ({@link DataComponent#CONSUMABLE})</li>
+     *     <li>{@code minecraft:equippable} ({@link DataComponent#EQUIPPABLE})</li>
+     *     <li>{@code minecraft:food} ({@link DataComponent#FOOD})</li>
+     *     <li>{@code minecraft:max_damage} ({@link DataComponent#MAX_DAMAGE})</li>
+     *     <li>{@code minecraft:max_stack_size} ({@link DataComponent#MAX_STACK_SIZE})</li>
+     *     <li>{@code minecraft:use_cooldown} ({@link DataComponent#USE_COOLDOWN})</li>
+     *     <li>{@code minecraft:enchantable} ({@link DataComponent#ENCHANTABLE})</li>
      * </ul>
      *
      * <p>Note: some components, for example {@code minecraft:rarity}, {@code minecraft:enchantment_glint_override}, and {@code minecraft:attribute_modifiers} are translated automatically,
      * and do not have to be specified here.</p>
+     *
+     * @see DataComponent
      */
     @NonNull DataComponentMap components();
 

core/src/main/java/org/geysermc/geyser/item/custom/ComponentConverters.java

@@ -48,6 +48,8 @@
 // However, those component classes have the same names as the MCPL ones, which causes some issues when they both have to be used in the same file.
 // One can't be imported, and as such its full qualifier (e.g. org.geysermc.mcprotocollib.protocol.data.game.item.component.Consumable) would have to be used.
 // That would be a mess to code in, and as such this code here was carefully designed to only require one set of component classes by name (the MCPL ones).
+//
+// It is VERY IMPORTANT to note that for every component in the API, a converter to MCPL must be put here (better solutions are welcome).
 public class ComponentConverters {
     private static final Map<DataComponent<?>, ComponentConverter<?>> converters = new HashMap<>();
 
@@ -88,6 +90,8 @@ public class ComponentConverters {
 
         registerConverter(DataComponent.USE_COOLDOWN, (itemMap, value) -> itemMap.put(DataComponentType.USE_COOLDOWN,
             new UseCooldown(value.seconds(), MinecraftKey.identifierToKey(value.cooldownGroup()))));
+
+        registerConverter(DataComponent.ENCHANTABLE, (itemMap, value) -> itemMap.put(DataComponentType.ENCHANTABLE, value));
     }
 
     private static <T> void registerConverter(DataComponent<T> component, ComponentConverter<T> converter) {