Skip to content

Commit 26443ff

Browse files
committed
Shade/Relocate dependencies on Fabric to avoid version warnings
1 parent f175888 commit 26443ff

File tree

2 files changed

+22
-10
lines changed

2 files changed

+22
-10
lines changed

bootstrap/mod/fabric/build.gradle.kts

+14-2
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ dependencies {
2222

2323
// These are NOT transitively included, and instead shadowed + relocated.
2424
// Avoids fabric complaining about non-SemVer versioning
25+
// TODO: re-evaluate after loom 1.6 (https://github.com/FabricMC/fabric-loom/pull/1075)
2526
shadow(libs.protocol.connection) { isTransitive = false }
2627
shadow(libs.protocol.common) { isTransitive = false }
2728
shadow(libs.protocol.codec) { isTransitive = false }
@@ -32,6 +33,13 @@ dependencies {
3233
shadow("io.netty:netty-codec-dns:4.1.103.Final") { isTransitive = false }
3334
shadow("io.netty:netty-resolver-dns-classes-macos:4.1.103.Final") { isTransitive = false }
3435

36+
// Consequences of shading + relocating mcauthlib: shadow/relocate mcpl!
37+
shadow(libs.mcprotocollib) { isTransitive = false }
38+
39+
// Since we also relocate cloudburst protocol: shade erosion common
40+
shadow(libs.erosion.common) { isTransitive = false }
41+
42+
// Permissions
3543
modImplementation(libs.fabric.permissions)
3644
include(libs.fabric.permissions)
3745
}
@@ -45,8 +53,12 @@ tasks {
4553
relocate("org.cloudburstmc.nbt", "org.geysermc.relocate.cloudburst.nbt")
4654
relocate("org.cloudburstmc.netty", "org.geysermc.relocate.cloudburst.netty")
4755
relocate("org.cloudburstmc.protocol", "org.geysermc.relocate.cloudburst.protocol")
48-
relocate("io.netty.handler.codec.dns", "org.geysermc.relocate.netty")
49-
relocate("io.netty.handler.codec.haproxy", "org.geysermc.relocate.netty")
56+
relocate("io.netty.handler.codec.dns", "org.geysermc.relocate.netty.codec-dns")
57+
relocate("io.netty.handler.codec.haproxy", "org.geysermc.relocate.netty.codec-haproxy")
58+
relocate("io.netty.resolver.dns.macos", "org.geysermc.relocate.netty.dns-macos")
59+
relocate("com.github.steveice10.mc.protocol", "org.geysermc.relocate.mcpl")
60+
relocate("com.github.steveice10.mc.auth", "org.geysermc.relocate.authlib")
61+
relocate("com.github.steveice10.packetlib", "org.geysermc.relocate.packetlib")
5062
}
5163
remapJar {
5264
archiveBaseName.set("Geyser-Fabric")

build-logic/src/main/kotlin/geyser.modded-conventions.gradle.kts

+8-8
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@ plugins {
1111
id("com.modrinth.minotaur")
1212
}
1313

14-
// These are provided by Minecraft already, no need to include them
14+
// These are provided by Minecraft/modded platforms already, no need to include them
1515
provided("com.google.code.gson", "gson")
16-
provided("com.google.guava", "*")
16+
provided("com.google.guava", ".*")
1717
provided("org.slf4j", "slf4j-api")
18-
provided("com.nukkitx.fastutil", "*")
19-
provided("org.cloudburstmc.fastutil.maps", "*")
20-
provided("org.cloudburstmc.fastutil.sets", "*")
21-
provided("org.cloudburstmc.fastutil.commons", "*")
22-
provided("org.cloudburstmc.fastutil", "*")
18+
provided("com.nukkitx.fastutil", ".*")
19+
provided("org.cloudburstmc.fastutil.maps", ".*")
20+
provided("org.cloudburstmc.fastutil.sets", ".*")
21+
provided("org.cloudburstmc.fastutil.commons", ".*")
22+
provided("org.cloudburstmc.fastutil", ".*")
2323
provided("org.checkerframework", "checker-qual")
2424
provided("io.netty", "netty-transport-classes-epoll")
2525
provided("io.netty", "netty-transport-native-epoll")
@@ -92,7 +92,7 @@ afterEvaluate {
9292
// Now: Include all transitive dependencies that aren't excluded
9393
configurations["includeTransitive"].resolvedConfiguration.resolvedArtifacts.forEach { dep ->
9494
if (!providedDependencies.contains("${dep.moduleVersion.id.group}:${dep.moduleVersion.id.name}")
95-
and !providedDependencies.contains("${dep.moduleVersion.id.group}:*")) {
95+
and !providedDependencies.contains("${dep.moduleVersion.id.group}:.*")) {
9696
println("Including dependency via JiJ: ${dep.id}")
9797
dependencies.add("include", dep.moduleVersion.id.toString())
9898
} else {

0 commit comments

Comments
 (0)