Can't boost with Firework when flying with Elytra in 1.12.2 creative

[pinkpig58]

Describe the bug

When flying with the elytra, I'm unable to use the firework to boost myself forwards.

To Reproduce

1. Put on an Elytra and grab some fireworks
2. Start flying with the Elytra
3. Attempt to use the fireworks (I use right-click)

Expected behaviour

When using the fireworks, it should boost you forwards.

Screenshots / Videos

elytra.+.firework.mp4

Server Version and Plugins

CraftBukkit version git-Spigot-79a30d7-f4830a1 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)

Plugins (3): ViaVersion, floodgate, Geyser-Spigot

Geyser Dump

https://dump.geysermc.org/Qg9E2Gh4QTUfBPZ2Jg7tGytXH997GUrL

Geyser Version

2.0.2-SNAPSHOT (git-master-238be40)

Minecraft: Bedrock Edition Version

1.18.12

Additional Context

No response

[rtm516]

Have you tried when not in creative?

(For anyone reading this on the dev team, we did add support but likely if confirmed there was a regression somewhere, see #552)

[Camotoy]

Confirmed in 1.12.2. 1.18.2 is fine though.

[Camotoy]

The core issue is, actually, that 1.12 never recognizes the player is gliding. And it does appear fine on survival.

[pinkpig58]

I can't seem to get it working in survival, either

fireworks.in.survival.mp4

[Camotoy]

Try starting not from creative flying (switch to survival, place some blocks up, then glide).

[pinkpig58]

Like this?

survivalTest.mp4

[Camotoy]

Yes, that would be it.

[Camotoy]

I took a look, but I'm not sure if I can go further at the moment. The issue is that this check: this.player.motY < 0.0D fails when we send the glide start packet, at least on creative (your survival has fireworks spawning, so that may be a different issue but I'm unable to replicate it).

[onebeastchris]

with dropped 1.12.2 support, does this even need fixing?

[Camotoy]

I still see this as a valid issue, as Geyser-Standalone still exists.