Dismounting Fake Entity

[otDan]

Describe the bug

The packets for dismounting don't seem to be translated for fake packet based entities, since trying ti dismount a fake armorstand puts the player back on it again.

To Reproduce

1. Create a fake armorstand
2. Ride the fake armorstand
3. Try dismounting the fake armorstand
4. It puts you back on the armorstand after letting you walk a bit

Expected behaviour

Let you dismount the entity without putting the player back on it again

Geyser Version

2.1.2-SNAPSHOT (git-master-505c065)

Minecraft: Bedrock Edition Device/Version

1.20.12

[otDan]

Linked video: (on java you can dismount, on bedrock you cannot)
https://github.com/GeyserMC/Geyser/assets/59731738/709856a1-fe8e-4ffb-bf3e-f17888b518d7
https://github.com/GeyserMC/Geyser/assets/59731738/6103b5a5-dc81-4f9a-ae8a-6dd504477e0c

[rtm516]

Can you provide code snippets to reproduce the issue?

[otDan]

how is this not enough information? you literally just have to spawn a packet based entity and try to dismount it when riding it, I'm not gonna send the whole code for spawning and handling actions since that's quite a lot, I can provide a dump later

[otDan]

[16:46:33 INFO] [geyser]: Could not find packet for SetEntityLinkPacket
[16:46:33 INFO] [geyser]: Could not find packet for SetEntityLinkPacket
[16:46:34 INFO] [geyser]: Could not find packet for SetEntityLinkPacket
[16:46:34 INFO] [geyser]: Could not find packet for SetEntityLinkPacket
[16:46:35 INFO] [geyser]: Could not find packet for SetEntityLinkPacket
[16:46:35 INFO] [geyser]: Spawned entity ARMOR_STAND at location (555.5, 49.5, 645.5) with id 478 (java id 6155)
[16:46:35 INFO] [geyser]: Not sure how to handle skull head item display. CompoundTag { {SkullOwner=CompoundTag(SkullOwner) { {Properties=CompoundTag(Properties) { {textures=ListTag(textures) { [CompoundTag { {Value=StringTag(Value) { eyJ0ZXh0dXJlcyI6eyJTS0lOIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvMmU1NzkzZjBjYzQwYTkzNjgyNTI3MTRiYzUyNjNhNWMzZGYyMjMzYmRkZjhhNTdlM2Q4ZDNmNTRhZjY3MjZjIn19fQ== }} }] }} }, Id=IntArrayTag(Id) { [-2074661541, -1033616041, -1940748347, -673456074] }} }} }
[16:46:36 INFO] [geyser]: Could not find packet for SetEntityLinkPacket
[16:46:36 INFO] [geyser]: Could not find packet for SetEntityLinkPacket
[16:46:37 INFO] [geyser]: Could not find packet for SetEntityLinkPacket
[16:46:38 INFO] [geyser]: Spawned entity ARMOR_STAND at location (555.5, 49.5, 645.5) with id 479 (java id 6157)
[16:46:38 INFO] [geyser]: Not sure how to handle skull head item display. CompoundTag { {SkullOwner=CompoundTag(SkullOwner) { {Properties=CompoundTag(Properties) { {textures=ListTag(textures) { [CompoundTag { {Value=StringTag(Value) { eyJ0ZXh0dXJlcyI6eyJTS0lOIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvMmU1NzkzZjBjYzQwYTkzNjgyNTI3MTRiYzUyNjNhNWMzZGYyMjMzYmRkZjhhNTdlM2Q4ZDNmNTRhZjY3MjZjIn19fQ== }} }] }} }, Id=IntArrayTag(Id) { [-2074661541, -1033616041, -1940748347, -673456074] }} }} }
[16:46:39 INFO] [geyser]: Could not find packet for SetEntityLinkPacket
[16:46:40 INFO] [geyser]: Could not find packet for SetEntityLinkPacket
[16:46:40 INFO] [geyser]: Could not find packet for SetEntityLinkPacket
[16:46:41 INFO] [geyser]: Could not find packet for SetEntityLinkPacket
[16:46:41 INFO] [geyser]: Could not find packet for SetEntityLinkPacket

also seems to spawn could not find packet for SetEntityLinkPacket whenever I try to dismount

[otDan]

any clues on what it could be?

[Kas-tle]

how is this not enough information? you literally just have to spawn a packet based entity and try to dismount it when riding it, I'm not gonna send the whole code for spawning and handling actions since that's quite a lot, I can provide a dump later

When we look into issues that other people are having one of the biggest hurdles to solving it is reproducing the issues ourselves. When you report a bug like this that involves writing a plugin to actually reproduce but then don't provide source for said plugin... not really a lot we can do. You specifically say "I'm not gonna send the whole code for spawning and handling actions since that's quite a lot". That's basically the whole point. Most of us do not have the time to write an entire plugin for the purpose of reproducing an issue.

[otDan]

how is this not enough information? you literally just have to spawn a packet based entity and try to dismount it when riding it, I'm not gonna send the whole code for spawning and handling actions since that's quite a lot, I can provide a dump later

When we look into issues that other people are having one of the biggest hurdles to solving it is reproducing the issues ourselves. When you report a bug like this that involves writing a plugin to actually reproduce but then don't provide source for said plugin... not really a lot we can do. You specifically say "I'm not gonna send the whole code for spawning and handling actions since that's quite a lot". That's basically the whole point. Most of us do not have the time to write an entire plugin for the purpose of reproducing an issue.

I obviously understand this, it's just that the code we have is a bit too much to be shared and obviously under the nda, I will try and make a little plugin when I have time off to easily reproduce it

[1111qqjzja]

This problem occurred when I used the mythicmobs plug-in to generate the model in this package.

[1111qqjzja]

Uploading Summer_Vehicles_Hyrex-zzkhpz.zip…

[1111qqjzja]

the pack link: https://114514-1306946608.cos.ap-beijing.myqcloud.com/Summer_Vehicles_Hyrex-zzkhpz.zip

[1111qqjzja]

First, use mythicmobs to spawn a vehicle, and then Bedrock Edition players ride the vehicle. Finally, there will be a problem of not being able to get off the vehicle.

[1111qqjzja]

The video download link: https://114514-1306946608.cos.ap-beijing.myqcloud.com/Record_2023-10-26-20-26-32.mp4