Custom achievements

[ChrisTVH]

Describe the bug

I put on my server a plugin called Adapt, which apart from adding skills to my server, also adds custom achievements.

What happens is that every time my players connect, they get the geyser achievement menu all in a row, it is quite annoying and invasive.

To Reproduce

1. Have a plugin that makes use of the vanilla achievement system to add your own.
2. Unlock one of these custom achievements.

Expected behaviour

Simply, I want it to come up only once when it is unlocked or that there is an option to deactivate it.

Screenshots / Videos

video.mp4

Server Version and Plugins

Adapt 1.16.4 for 1.19.2-1.21.4
Paper 1.21.1 Build 132

Geyser Dump

https://dump.geysermc.org/K6BWnFRzYYyLl8qVhjpcrm1eyfPuFckz

Geyser Version

Geyser 2.6.1-b779 (git-master-758700c)

Minecraft: Bedrock Edition Device/Version

1.21.62

Additional Context

There are also errors of not being able to translate the package, related to the achievement menus that appear:
https://mclo.gs/x3h526G

[eclipseisoffline]

Could you please send a full log file, from the start of the server, up until a ClientboundSelectAdvancementsTabPacket error appears? The log file you sent has the stack traces cut off due to the error repeating too many times.

[ChrisTVH]

Could you please send a full log file, from the start of the server, up until a ClientboundSelectAdvancementsTabPacket error appears? The log file you sent has the stack traces cut off due to the error repeating too many times.

https://mclo.gs/d2eIudb

[eclipseisoffline]

I've created a PR to resolve this - could you please try the build from PR #5396 and check if it resolves your issue? You can get this build by clicking the "Checks" tab, then clicking on "Artifacts". Note that you have to unzip the downloaded artifact to get the JAR file.

When you're testing the build, can you also please verify that the NullPointerException errors no longer appear in the logs, and that the advancements tab is still fully functional?

[ChrisTVH]

I just tried it and it works great, plus the achievement menu no longer gives errors on the console.