Fix linting errors

Author: CLHatch

.scripts/app_list_referenced.sh

@@ -6,7 +6,7 @@ app_list_referenced() {
     local APPNAME_REGEX='^[A-Z][A-Z0-9]*(__[A-Z0-9]+)?'
     local REFERENCED_APPS_REGEX="${APPNAME_REGEX}(?=__[A-Za-z0-9]\w*\s*=)"
 
-    grep --color=never -o -P "${REFERENCED_APPS_REGEX}" "${COMPOSE_ENV}" | sort -u  || true
+    grep --color=never -o -P "${REFERENCED_APPS_REGEX}" "${COMPOSE_ENV}" | sort -u || true
 }
 
 test_app_list_referenced() {

.scripts/env_format_lines.sh

@@ -7,7 +7,7 @@ env_format_lines() {
     local ENV_DEFAULT_FILE=${2-}
     local APPNAME=${3-}
     APPNAME=${APPNAME^^}
-    local appname=${APPNAME,,}
+    #local appname=${APPNAME,,}
 
     local TOP_SECTION='false'
     #notice "["
@@ -51,7 +51,7 @@ env_format_lines() {
         FORMATTED_ENV_VAR_INDEX[$VAR]=$index
     done
 
-    if [[ -n ${CURRENT_ENV_LINES[@]-} ]]; then
+    if [[ -n ${CURRENT_ENV_LINES[*]} ]]; then
         # Update the default variables
         for index in "${!CURRENT_ENV_LINES[@]}"; do
             local line=${CURRENT_ENV_LINES[index]}
@@ -60,12 +60,12 @@ env_format_lines() {
             if [[ -n ${FORMATTED_ENV_VAR_INDEX["$VAR"]-} ]]; then
                 # Variable already exists, update its value
                 VAR_INDEX=${FORMATTED_ENV_VAR_INDEX["$VAR"]-}
-                FORMATTED_ENV_LINES[$VAR_INDEX]=$line
+                FORMATTED_ENV_LINES[VAR_INDEX]=$line
                 unset 'CURRENT_ENV_LINES[index]'
             fi
         done
         CURRENT_ENV_LINES=("${CURRENT_ENV_LINES[@]-}")
-        if [[ -n ${CURRENT_ENV_LINES[@]-} ]]; then
+        if [[ -n ${CURRENT_ENV_LINES[*]} ]]; then
             if [[ ${TOP_SECTION} == true ]]; then
                 # Add a blank if there was a previous section
                 FORMATTED_ENV_LINES+=("")

.scripts/env_update.sh

@@ -8,7 +8,7 @@ env_update() {
     run_script 'appvars_lines' "" > "${ENV_LINES_FILE}"
 
     local -a UPDATED_ENV_LINES=()
-    readarray -t UPDATED_ENV_LINES < <( \
+    readarray -t UPDATED_ENV_LINES < <(
         run_script 'env_format_lines' "${ENV_LINES_FILE}" "${COMPOSE_ENV_DEFAULT_FILE}" ""
     )