Improve JSON handling and HTML encoding in API helpers (#4489)

* Improve JSON handling and HTML encoding in API helpers

Refactored WireMockAPI to use System.Text.Json for payload serialization and robust JSON parsing for stub mappings. Enhanced GenAIServiceHelper to HTML-encode error logs and multipart form data, ensuring safer handling of special characters and null values.

* Refactor error logging to use exception overload

Simplified exception handling by replacing manual error message construction and encoding with a single Reporter.ToLog call that passes the exception object, leveraging built-in logging features.

---------

Co-authored-by: tanushah <tanushah@amdocs.com>

Author: tanushahande2003

Ginger/GingerCoreNET/External/WireMock/WireMockAPI.cs

@@ -22,6 +22,7 @@ limitations under the License.
 using System;
 using System.Net.Http;
 using System.Text;
+using System.Text.Json;
 using System.Threading.Tasks;
 
 namespace Amdocs.Ginger.CoreNET.External.WireMock
@@ -99,7 +100,8 @@ public async Task<string> StartRecordingAsync(string targetUrl)
 
                 using (HttpClient client = new HttpClient())
                 {
-                    var content = new StringContent($"{{\"targetBaseUrl\": \"{targetUrl}\"}}", Encoding.UTF8, "application/json");
+                    string json = JsonSerializer.Serialize(new { targetBaseUrl = targetUrl });
+                    var content = new StringContent(json, Encoding.UTF8, "application/json");
                     HttpResponseMessage response = await client.PostAsync($"{NormalizeUrl(GingerCore.ValueExpression.PasswordCalculation(_baseUrl))}{StartRecordingEndpoint}", content);
                     response.EnsureSuccessStatusCode();
                     return await response.Content.ReadAsStringAsync();
@@ -153,7 +155,19 @@ public async Task<string> CreateStubAsync(string stubMapping, string contentType
                     {
                         contentType = "application/json";
                     }
-                    var content = new StringContent(stubMapping, Encoding.UTF8, contentType);
+
+                    string body;
+                    if (string.IsNullOrEmpty(stubMapping))
+                    {
+                        body = stubMapping;
+                    }
+                    else
+                    {
+                        using JsonDocument doc = JsonDocument.Parse(stubMapping);
+                        body = doc.RootElement.GetRawText();
+                    }
+
+                    var content = new StringContent(body, Encoding.UTF8, contentType);
                     HttpResponseMessage response = await client.PostAsync($"{NormalizeUrl(GingerCore.ValueExpression.PasswordCalculation(_baseUrl))}{MappingEndpoint}", content);
                     response.EnsureSuccessStatusCode();
                     return await response.Content.ReadAsStringAsync();
@@ -204,7 +218,18 @@ public async Task<string> UpdateStubAsync(string stubId, string stubMapping)
 
                 using (HttpClient client = new HttpClient())
                 {
-                    var content = new StringContent(stubMapping, Encoding.UTF8, "application/json");
+                    string body;
+                    if (string.IsNullOrEmpty(stubMapping))
+                    {
+                        body = stubMapping;
+                    }
+                    else
+                    {
+                        using JsonDocument doc = JsonDocument.Parse(stubMapping);
+                        body = doc.RootElement.GetRawText();
+                    }
+
+                    var content = new StringContent(body, Encoding.UTF8, "application/json");
                     HttpResponseMessage response = await client.PutAsync($"{NormalizeUrl(GingerCore.ValueExpression.PasswordCalculation(_baseUrl))}{MappingEndpoint}/{stubId}", content);
                     response.EnsureSuccessStatusCode();
                     return await response.Content.ReadAsStringAsync();

Ginger/GingerCoreNET/GenAIServices/GenAIServiceHelper.cs

@@ -22,6 +22,7 @@ limitations under the License.
 using System;
 using System.Collections.Generic;
 using System.IdentityModel.Tokens.Jwt;
+using System.Net;
 using System.Net.Http;
 using System.Threading.Tasks;
 
@@ -104,8 +105,7 @@ private async Task<bool> GetToken()
             catch (Exception ex)
             {
                 var error = "Failed to get access token";
-                Reporter.ToLog(eLogLevel.ERROR, $"{error}, Error :{ex.Message}");
-                Reporter.ToLog(eLogLevel.ERROR, $"{error}, Error :{ex.Message}, InnerException:{ex.InnerException},StackTrace:{ex.StackTrace}");
+                Reporter.ToLog(eLogLevel.ERROR, error, ex);
                 return false;
             }
         }
@@ -245,11 +245,11 @@ private MultipartFormDataContent PrepareRequestDetailsForChat(string Question)
             var content = new MultipartFormDataContent
             {
                 { new StringContent(Question), "question" },
-                { new StringContent(CredentialsCalculation(WorkSpace.Instance.Solution.AskLisaConfiguration.Account)), "account" },
-                { new StringContent(CredentialsCalculation(WorkSpace.Instance.Solution.AskLisaConfiguration.DomainType)), "domainType" },
-                { new StringContent(CredentialsCalculation(WorkSpace.Instance.Solution.AskLisaConfiguration.TemperatureLevel)), "temperatureVal" },
-                { new StringContent(CredentialsCalculation(WorkSpace.Instance.Solution.AskLisaConfiguration.MaxTokenValue)), "maxTokensVal" },
-                { new StringContent(CredentialsCalculation(WorkSpace.Instance.Solution.AskLisaConfiguration.DataPath)), "dataPath" }
+                { new StringContent(WebUtility.HtmlEncode(CredentialsCalculation(WorkSpace.Instance.Solution.AskLisaConfiguration.Account) ?? string.Empty)), "account" },
+                { new StringContent(WebUtility.HtmlEncode(CredentialsCalculation(WorkSpace.Instance.Solution.AskLisaConfiguration.DomainType) ?? string.Empty)), "domainType" },
+                { new StringContent(WebUtility.HtmlEncode(CredentialsCalculation(WorkSpace.Instance.Solution.AskLisaConfiguration.TemperatureLevel) ?? string.Empty)), "temperatureVal" },
+                { new StringContent(WebUtility.HtmlEncode(CredentialsCalculation(WorkSpace.Instance.Solution.AskLisaConfiguration.MaxTokenValue) ?? string.Empty)), "maxTokensVal" },
+                { new StringContent(WebUtility.HtmlEncode(CredentialsCalculation(WorkSpace.Instance.Solution.AskLisaConfiguration.DataPath) ?? string.Empty)), "dataPath" }
             };
             return content;
         }