Skip to content

Commit 53523ca

Browse files
authored
Merge pull request #4503 from Ginger-Automation/Merge-Master-to-Official-Release
Merge master to official release
2 parents 9d673bb + f889186 commit 53523ca

11 files changed

Lines changed: 88 additions & 48 deletions

File tree

.github/workflows/Test.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,9 @@ jobs:
126126
# ------------------------------------------------------------------------------------------------------
127127
# Run .Net Framework tests using powershell and publish the results
128128
# ------------------------------------------------------------------------------------------------------
129-
- name: Run tests for Ginger .NetFramework *Test Dlls for Windows
130-
if: (success() || failure()) && (runner.os == 'Windows') # run this step even if previous step failed and if the OS is Windows
131-
run: powershell -file "TestDotNetFrameworkGithub.ps1"
129+
# - name: Run tests for Ginger .NetFramework *Test Dlls for Windows
130+
# if: (success() || failure()) && (runner.os == 'Windows') # run this step even if previous step failed and if the OS is Windows
131+
# run: powershell -file "TestDotNetFrameworkGithub.ps1"
132132

133133
# ------------------------------------------------------------------------------------------------------
134134
# Run Standalone CLI Test

Ginger/Ginger/Actions/ActionEditPages/ActTableEditPage.xaml

Lines changed: 22 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,20 @@
1818
<Grid.ColumnDefinitions>
1919
<ColumnDefinition Width="80"/>
2020
<ColumnDefinition Width="130"/>
21-
<ColumnDefinition Width="130"/>
21+
<ColumnDefinition Width="330"/>
2222
<ColumnDefinition Width="460"/>
2323
</Grid.ColumnDefinitions>
2424
<StackPanel Grid.Row="0" Grid.Column="0" Margin="0,10,0,17">
2525
<Label HorizontalAlignment="Left" Style="{StaticResource @LabelStyle}" VerticalAlignment="Center">Column:</Label>
2626
</StackPanel>
2727
<StackPanel Grid.Row="0" Grid.Column="1" Margin="0,10,0,17">
28-
<ComboBox x:Name="cmbColSelectorValue" Height="25" SelectionChanged="ColSelectorValue_SelectionChanged" Style="{StaticResource $FlatInputComboBoxStyle}"/>
28+
<ComboBox x:Name="cmbColSelectorValue" Height="25" SelectionChanged="ColSelectorValue_SelectionChanged" Style="{StaticResource $FlatInputComboBoxStyle}"/>
2929
</StackPanel>
30-
<StackPanel Grid.Row="0" Grid.Column="2" Margin="0,10,0,17" >
31-
<ComboBox x:Name="cmbColumnValue" Grid.Column="1" Height="25" IsEditable="True" Margin="10,0,0,0" Style="{StaticResource $FlatInputComboBoxStyle}" SelectionChanged="ColumnValue_SelectionChanged" LostKeyboardFocus="ColumnValue_LostKeyboardFocus"/>
30+
<StackPanel Grid.Row="0" Grid.Column="2" Margin="0,10,15,17">
31+
<DockPanel >
32+
<Button x:Name="ColumnValueVE" DockPanel.Dock="Right" Content="..." Click="ColumnValueVE_Click" VerticalAlignment="Center" Style="{StaticResource @InputButtonStyle}" Margin="1,0,0,0" Width="30" Height="24"/>
33+
<ComboBox x:Name="cmbColumnValue" Height="25" IsEditable="True" Margin="10,0,0,0" Style="{StaticResource $FlatInputComboBoxStyle}" SelectionChanged="ColumnValue_SelectionChanged" LostKeyboardFocus="ColumnValue_LostKeyboardFocus"/>
34+
</DockPanel>
3235
</StackPanel>
3336
<StackPanel Grid.Row="1" Grid.Column="0">
3437
<Label HorizontalAlignment="Left" Style="{StaticResource @LabelStyle}" VerticalAlignment="Top">Row:</Label>
@@ -39,12 +42,11 @@
3942
<RadioButton Name="BySelectedRow" Content="Selected Row" Checked="BySelectedRow_Checked" Margin="0,5,0,5"/>
4043
<RadioButton Name="Where" Content="Where..." Checked="Where_Checked" Unchecked="Where_Unchecked" Margin="0,5,0,5"/>
4144
</StackPanel>
42-
<StackPanel Grid.Row="1" Grid.Column="2" Grid.ColumnSpan="2" Orientation="Horizontal" VerticalAlignment="Top">
45+
<StackPanel Grid.Row="1" Grid.Column="2" >
4346
<DockPanel>
44-
<ComboBox x:Name="RowSelectorValue" Width="250" Margin="10,0,0,0" IsEditable="True" IsEnabled="True" Style="{StaticResource $FlatInputComboBoxStyle}" SelectionChanged="RowSelectorValue_SelectionChanged" LostKeyboardFocus="RowSelectorValue_LostKeyboardFocus"/>
45-
<Button x:Name="RowSelectorValueVE" Content="..." Click="RowSelectorValueVE_Click" HorizontalAlignment="Left" DockPanel.Dock="Left" VerticalAlignment="Center" Style="{StaticResource @InputButtonStyle}" Margin="1,0,5,0" Width="30" Height="24"></Button>
47+
<Button x:Name="RowSelectorValueVE" DockPanel.Dock="Right" Content="..." Click="RowSelectorValueVE_Click" VerticalAlignment="Center" Style="{StaticResource @InputButtonStyle}" Margin="1,0,0,0" Width="30" Height="24"/>
48+
<ComboBox x:Name="RowSelectorValue" Margin="10,0,0,0" IsEditable="True" IsEnabled="True" Style="{StaticResource $FlatInputComboBoxStyle}" SelectionChanged="RowSelectorValue_SelectionChanged" LostKeyboardFocus="RowSelectorValue_LostKeyboardFocus"/>
4649
</DockPanel>
47-
4850
</StackPanel>
4951
<StackPanel Grid.Row="2" Grid.Column="1" x:Name="WherePanel" Visibility="Collapsed" Grid.RowSpan="1" Grid.ColumnSpan="3">
5052
<Grid Margin="0,5,0,0">
@@ -57,30 +59,32 @@
5759
<ColumnDefinition Width="130"/>
5860
<ColumnDefinition Width="200"/>
5961
</Grid.ColumnDefinitions>
60-
<ComboBox x:Name="WhereColumn" Grid.Row="0" Grid.Column="0" Style="{StaticResource $FlatInputComboBoxStyle}" Height="25" SelectionChanged="WhereColumn_SelectionChanged" Margin="10,5,0,0" />
61-
<ComboBox x:Name="WhereColumnTitle" Grid.Row="0" Grid.Column="1" Style="{StaticResource $FlatInputComboBoxStyle}" IsEditable="True" Height="25" Margin="10,5,0,0" VerticalAlignment="Top" LostKeyboardFocus="WhereColumnTitle_LostKeyboardFocus" SelectionChanged="WhereColumnTitle_SelectionChanged"/>
62-
<ComboBox x:Name="WhereProperty" Grid.Row="1" Grid.Column="0" Style="{StaticResource $FlatInputComboBoxStyle}" Height="25" Margin="10,5,0,0" SelectionChanged="WhereProperty_SelectionChanged"/>
63-
<ComboBox x:Name="WhereOperator" Grid.Row="1" Grid.Column="1" Style="{StaticResource $FlatInputComboBoxStyle}" Height="25" Margin="10,5,0,0" SelectionChanged="WhereOperator_SelectionChanged"/>
64-
65-
<Actions:UCValueExpression x:Name="WhereColumnValue" Grid.Row="1" Grid.Column="2" Height="25" Margin="10,5,0,0" LostFocus="WhereColumnValue_LostFocus" ToolTip="Enter the Value to be search by given Condition"/>
62+
<ComboBox x:Name="WhereColumn" Grid.Row="0" Grid.Column="0" Style="{StaticResource $FlatInputComboBoxStyle}" Height="25" SelectionChanged="WhereColumn_SelectionChanged" Margin="12,5,0,0"/>
63+
<DockPanel Grid.Row="0" Grid.Column="1" Grid.ColumnSpan="2" Margin="12,5,0,0">
64+
<Button x:Name="WhereColumnTitleVE" DockPanel.Dock="Right" Content="..." Click="WhereColumnTitleVE_Click" VerticalAlignment="Center" Style="{StaticResource @InputButtonStyle}" Margin="1,0,0,0" Width="30" Height="24"/>
65+
<ComboBox x:Name="WhereColumnTitle" Style="{StaticResource $FlatInputComboBoxStyle}" IsEditable="True" Height="25" VerticalAlignment="Top" LostKeyboardFocus="WhereColumnTitle_LostKeyboardFocus" SelectionChanged="WhereColumnTitle_SelectionChanged"/>
66+
</DockPanel>
67+
<ComboBox x:Name="WhereProperty" Grid.Row="1" Grid.Column="0" Style="{StaticResource $FlatInputComboBoxStyle}" Height="25" Margin="12,0,0,0" SelectionChanged="WhereProperty_SelectionChanged"/>
68+
<ComboBox x:Name="WhereOperator" Grid.Row="1" Grid.Column="1" Style="{StaticResource $FlatInputComboBoxStyle}" Height="25" Margin="12,0,0,0" SelectionChanged="WhereOperator_SelectionChanged"/>
69+
<Actions:UCValueExpression x:Name="WhereColumnValue" Grid.Row="1" Grid.Column="2" Height="25" Margin="12,12,12,12" LostFocus="WhereColumnValue_LostFocus" ToolTip="Enter the Value to be search by given Condition"/>
6670
</Grid>
6771
</StackPanel>
68-
<Label Grid.Row="3" Grid.Column="0" Content="Description:" Style="{StaticResource @LabelStyle}" HorizontalAlignment="Stretch" Margin="0,10,0,0"/>
72+
<Label Grid.Row="3" Grid.Column="0" Content="Description:" Style="{StaticResource @LabelStyle}" HorizontalAlignment="Stretch" Margin="0,10,0,0"/>
6973
<StackPanel Grid.Row="3" Grid.Column="1" x:Name="DescriptionPanel" Visibility="Visible" Margin="0,10,0,0" Grid.RowSpan="1" Grid.ColumnSpan="3">
7074
<Grid Margin="0,0,0,0">
7175
<Grid.RowDefinitions>
7276
<RowDefinition Height="70"/>
7377
</Grid.RowDefinitions>
74-
<DockPanel x:Name="Description" Background="{StaticResource $BackgroundColor_White}" Grid.Row="1" >
78+
<DockPanel x:Name="Description" Background="{StaticResource $BackgroundColor_White}" Grid.Row="1">
7579
<ScrollViewer Background="White">
76-
<TextBlock x:Name="txtDescription" TextWrapping="Wrap" Style="{StaticResource @TextBlockStyle}" DockPanel.Dock="Top" Background="#FFEFEFF2"></TextBlock>
80+
<TextBlock x:Name="txtDescription" TextWrapping="Wrap" Style="{StaticResource @TextBlockStyle}" DockPanel.Dock="Top" Background="#FFEFEFF2"/>
7781
</ScrollViewer>
7882
</DockPanel>
7983
</Grid>
8084
</StackPanel>
8185
<StackPanel x:Name="ControlActionPanle" Grid.Row="4" Grid.ColumnSpan="3">
8286
<Label HorizontalAlignment="Left" Style="{StaticResource @LabelStyle}">Selected Operation:</Label>
83-
<ComboBox x:Name="ControlActionComboBox" Style="{StaticResource $FlatInputComboBoxStyle}"></ComboBox>
87+
<ComboBox x:Name="ControlActionComboBox" Style="{StaticResource $FlatInputComboBoxStyle}"/>
8488
</StackPanel>
8589
</Grid>
8690
</Page>

Ginger/Ginger/Actions/ActionEditPages/ActTableEditPage.xaml.cs

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -793,5 +793,29 @@ private void RowSelectorValueVE_Click(object sender, RoutedEventArgs e)
793793
w.ShowAsWindow(eWindowShowStyle.Dialog);
794794
RowSelectorValue.Text = mAct.LocateRowValue;
795795
}
796+
797+
private void ColumnValueVE_Click(object sender, RoutedEventArgs e)
798+
{
799+
ValueExpressionEditorPage w = new ValueExpressionEditorPage(mAct, ActTableElement.Fields.LocateColTitle, Context.GetAsContext(mAct.Context));
800+
w.ShowAsWindow(eWindowShowStyle.Dialog);
801+
cmbColumnValue.Text = mAct.LocateColTitle;
802+
SetDescriptionDetails();
803+
if (eBaseWindow.Equals(BaseWindow.WindowExplorer))
804+
{
805+
UpdateRelatedActions();
806+
}
807+
}
808+
809+
private void WhereColumnTitleVE_Click(object sender, RoutedEventArgs e)
810+
{
811+
ValueExpressionEditorPage w = new ValueExpressionEditorPage(mAct, ActTableElement.Fields.WhereColumnTitle, Context.GetAsContext(mAct.Context));
812+
w.ShowAsWindow(eWindowShowStyle.Dialog);
813+
WhereColumnTitle.Text = mAct.WhereColumnTitle;
814+
SetDescriptionDetails();
815+
if (eBaseWindow.Equals(BaseWindow.WindowExplorer))
816+
{
817+
UpdateRelatedActions();
818+
}
819+
}
796820
}
797821
}

Ginger/Ginger/Drivers/DriversConfigsEditPages/UFTCredentialsDialog.xaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@
270270
<StackPanel Orientation="Vertical" Margin="0,0,12,0">
271271
<Label Content="OS Type" Style="{StaticResource $LabelStyle}" />
272272
<ComboBox x:Name="xAppOsTypeCombo" Width="160" SelectionChanged="AppFilters_SelectionChanged" Style="{StaticResource $FlatInputComboBoxStyle}" />
273-
</StackPanel>
273+
</StackPanel>
274274
<StackPanel Orientation="Horizontal" HorizontalAlignment="Right" VerticalAlignment="Bottom">
275275
<UserControls:ucButton x:Name="xRefreshAppsBtn"
276276
ButtonType="RoundTextAndImageButton"
@@ -415,9 +415,9 @@
415415
</ListBox.ItemTemplate>
416416
</ListBox>
417417
</StackPanel>
418-
</Border>
419-
</StackPanel>
420-
</ScrollViewer>
418+
</Border>
419+
</StackPanel>
420+
</ScrollViewer>
421421

422422
</StackPanel>
423423
</TabItem>

Ginger/Ginger/Ginger.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -749,7 +749,7 @@
749749
<PackageReference Include="LiteDB" Version="5.0.21" />
750750
<PackageReference Include="LiveCharts.Wpf.NetCore3" Version="0.9.8" />
751751
<PackageReference Include="log4net" Version="2.0.15" />
752-
<PackageReference Include="Magick.NET-Q16-AnyCPU" Version="14.13.0" />
752+
<PackageReference Include="Magick.NET-Q16-AnyCPU" Version="14.13.1" />
753753
<PackageReference Include="Microsoft.Extensions.AI.OpenAI" Version="10.3.0" />
754754
<PackageReference Include="Microsoft.IdentityModel.JsonWebTokens" Version="8.15.0" />
755755
<PackageReference Include="Microsoft.IdentityModel.Tokens" Version="8.15.0" />

Ginger/GingerCoreCommon/GingerCoreCommon.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@
1111
<TargetFramework>net10.0</TargetFramework>
1212
<RootNamespace>Amdocs.Ginger.Common</RootNamespace>
1313

14-
<AssemblyVersion>26.5.0.0</AssemblyVersion>
15-
<FileVersion>26.5.0.0</FileVersion>
14+
<AssemblyVersion>26.6.0.0</AssemblyVersion>
15+
<FileVersion>26.6.0.0</FileVersion>
1616

1717
<PackageId>Ginger.Core.Common</PackageId>
1818
<Authors>Amdocs</Authors>
1919
<Company>Amdocs</Company>
2020
<Product>Ginger by Amdocs</Product>
2121
<Copyright>Copyright © 2014-2026 European Support Limited</Copyright>
22-
<Version>2026.5.0.0</Version>
22+
<Version>2026.6.0.0</Version>
2323
<Title>Ginger Core Common</Title>
2424
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
2525
</PropertyGroup>

Ginger/GingerCoreNET/Database/DatabaseOperations.cs

Lines changed: 27 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -417,25 +417,35 @@ public Boolean Connect(bool displayErrorPopup = false)
417417
break;
418418

419419
case eDBTypes.PostgreSQL:
420-
string postgreSQLHost = TNSCalculated;
421-
int? port = null;
422-
if (TNSCalculated.Contains(':', StringComparison.Ordinal))
420+
var pg = new NpgsqlConnectionStringBuilder();
421+
if (string.IsNullOrEmpty(ConnectionStringCalculated))
423422
{
424-
var parts = TNSCalculated.Split(':', 2);
425-
postgreSQLHost = parts[0];
426-
if (int.TryParse(parts[1], out int p)) port = p;
427-
}
428-
ValidateHostPort(postgreSQLHost, port);
423+
string postgreSQLHost = TNSCalculated;
424+
int? port = null;
425+
if (TNSCalculated.Contains(':', StringComparison.Ordinal))
426+
{
427+
var parts = TNSCalculated.Split(':', 2);
428+
postgreSQLHost = parts[0];
429+
if (int.TryParse(parts[1], out int p)) port = p;
430+
}
431+
ValidateHostPort(postgreSQLHost, port);
429432

430-
var pg = new NpgsqlConnectionStringBuilder
433+
pg = new NpgsqlConnectionStringBuilder
434+
{
435+
Host = postgreSQLHost,
436+
Database = Database.Name ?? string.Empty,
437+
Username = UserCalculated,
438+
Password = EncryptionHandler.DecryptwithKey(PassCalculated)
439+
};
440+
if (port.HasValue) pg.Port = port.Value;
441+
}
442+
else
431443
{
432-
Host = postgreSQLHost,
433-
Database = Database.Name ?? string.Empty,
434-
Username = UserCalculated,
435-
Password = EncryptionHandler.DecryptwithKey(PassCalculated)
436-
};
437-
if (port.HasValue) pg.Port = port.Value;
438-
Database.ConnectionString = pg.ConnectionString;
444+
pg = new NpgsqlConnectionStringBuilder
445+
{
446+
ConnectionString = GetConnectionString()
447+
};
448+
}
439449

440450
oConn = new NpgsqlConnection(pg.ConnectionString);
441451
oConn.Open();
@@ -1045,4 +1055,4 @@ public string GetRecordCount(string SQL)
10451055
}
10461056

10471057
}
1048-
}
1058+
}

Ginger/GingerCoreNET/GingerCoreNET.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@
293293

294294
<PackageReference Include="log4net" Version="2.0.15" />
295295

296-
<PackageReference Include="Magick.NET-Q16-AnyCPU" Version="14.13.0" />
296+
<PackageReference Include="Magick.NET-Q16-AnyCPU" Version="14.13.1" />
297297

298298
<PackageReference Include="MailKit" Version="4.14.1" />
299299

Ginger/GingerCoreNET/Run/GingerExecutionEngine.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4515,6 +4515,7 @@ public void RunBusinessFlow(BusinessFlow businessFlow, bool standaloneExecution
45154515

45164516
if (standaloneExecution)
45174517
{
4518+
WorkSpace.Instance.PlugInsManager.CloseAllRunningPluginProcesses();
45184519
IsRunning = false;
45194520
Status = RunsetStatus;
45204521
}

Ginger/GingerCoreNET/Run/RunsetExecutor.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -730,6 +730,7 @@ public async Task RunRunset(bool doContinueRun = false)
730730
Reporter.ToLog(eLogLevel.INFO, string.Format("######## Doing {0} Execution Cleanup", GingerDicser.GetTermResValue(eTermResKey.RunSet)));
731731
//CloseAllAgents();
732732
CloseAllEnvironments();
733+
WorkSpace.Instance.PlugInsManager.CloseAllRunningPluginProcesses();
733734
Reporter.ToLog(eLogLevel.INFO, string.Format("########################## {0} Execution Ended", GingerDicser.GetTermResValue(eTermResKey.RunSet)));
734735
}
735736
catch (Exception ex)

0 commit comments

Comments
 (0)