Merge pull request #4383 from Ginger-Automation/CodeQL-OracleDBAlertFix

Not using GetConnectionString method

Author: rathimayur

Ginger/GingerCoreNET/Database/DatabaseOperations.cs

@@ -364,7 +364,9 @@ public Boolean Connect(bool displayErrorPopup = false)
                                 Provider = "msdaora"
                             };
 
-                            oleDbconnectionStringBuilder.ConnectionString = GetConnectionString();
+                            String deCryptValue = EncryptionHandler.DecryptwithKey(PassCalculated);
+
+                            oleDbconnectionStringBuilder.ConnectionString = ConnectionStringCalculated.Replace("{USER}", UserCalculated).Replace("{PASS}", string.IsNullOrEmpty(deCryptValue) ? PassCalculated : deCryptValue);
 
                             oConn = OleDbFactory.Instance.CreateConnection();
                             oConn.ConnectionString = oleDbconnectionStringBuilder.ConnectionString;