#348 avoid download errors (#349)

Author: GioF71

Dockerfile

@@ -20,24 +20,29 @@ RUN if [ "${USE_APT_PROXY}" = "Y" ]; then \
         echo "Building without apt proxy"; \
     fi
 
+# copy assets
+RUN mkdir -p /app/assets/sourceforge
+COPY app/assets/sourceforge/*tar.gz /app/assets/sourceforge/
+
 RUN mkdir -p /app/bin
 
-# copy installer files
+# create install directory and set if as workdir
 RUN mkdir -p /app/install
+WORKDIR /app/install
 
+# install dependencies
 COPY install/install-dep.sh /app/install/
-COPY install/installer.sh /app/install/
-COPY install/remove-dep.sh /app/install/
-
-RUN chmod u+x /app/install/*.sh
-
+RUN chmod u+x /app/install/install-dep.sh
 RUN /app/install/install-dep.sh
 
-WORKDIR /app/install
-
 # execute installation
+COPY install/installer.sh /app/install/
+RUN chmod u+x /app/install/installer.sh
 RUN /app/install/installer.sh
 
+# remove unnecessary dependencies
+COPY install/remove-dep.sh /app/install/
+RUN chmod u+x /app/install/remove-dep.sh
 RUN /app/install/remove-dep.sh
 
 RUN rm /app/install/install-dep.sh
@@ -55,6 +60,9 @@ RUN rm -rf /var/lib/apt/lists/*
 # remove scripts
 RUN rm -Rf /app/install
 
+# remove sourceforge assets
+RUN rm -Rf /app/assets/sourceforge
+
 FROM scratch
 COPY --from=base / /
 

app/assets/sourceforge/squeezelite-2.0.0.1524-armel.tar.gz

@@ -10,6 +10,7 @@ Older build might be dropped in order to save space on docker-hub and incur in l
 
 Date|Type|Description
 :---|:---|:---
+2025-11-10|Maintenance|Avoid download errors by including sf binaries (see [#348](https://github.com/GioF71/squeezelite-docker/issues/348))
 2025-08-26|Bugfix|Stick to bookworm until bugs are addressed, also avoid silent errors (see [#345](https://github.com/GioF71/squeezelite-docker/issues/345) and [#344](https://github.com/GioF71/squeezelite-docker/issues/344))
 2025-08-10|Maintenance|Fixed r2 build, would not find libasound2
 2025-06-30|Improvement|Complete support for alsa equalizer plugin, we do not require to create a custom asound.conf file anymore (see [#338](https://github.com/GioF71/squeezelite-docker/issues/338))

app/assets/sourceforge/squeezelite-2.0.0.1541-aarch64.tar.gz

@@ -24,53 +24,43 @@ arch_amd64=x86_64
 arch_arm_v7=armv7l
 arch_arm_v8=aarch64
 
-url_left="https://sourceforge.net/projects/lmsclients/files/squeezelite/linux/"
-url_right="/download"
+declare -A alsa_file_dict
+alsa_file_dict[$arch_amd64]="squeezelite-2.0.0.1541-x86_64.tar.gz"
+alsa_file_dict[$arch_arm_v8]="squeezelite-2.0.0.1541-aarch64.tar.gz"
+alsa_file_dict[$arch_arm_v7]="squeezelite-2.0.0.1541-armhf.tar.gz"
 
-declare -A url_middle_alsa_dict
-url_middle_alsa_dict[$arch_amd64]="squeezelite-2.0.0.1541-x86_64.tar.gz"
-url_middle_alsa_dict[$arch_arm_v7]="squeezelite-2.0.0.1541-armhf.tar.gz"
-url_middle_alsa_dict[$arch_arm_v8]="squeezelite-2.0.0.1541-aarch64.tar.gz"
-
-declare -A url_middle_pulse_dict
-url_middle_pulse_dict[$arch_amd64]="squeezelite-pulse-2.0.0.1541-x86_64.tar.gz"
-url_middle_pulse_dict[$arch_arm_v7]="squeezelite-pulse-1.9.9.1392-armhf.tar.gz"
-url_middle_pulse_dict[$arch_arm_v8]="squeezelite-pulse-2.0.0.1541-aarch64.tar.gz"
+declare -A pulse_file_dict
+pulse_file_dict[$arch_amd64]="squeezelite-pulse-2.0.0.1541-x86_64.tar.gz"
+pulse_file_dict[$arch_arm_v8]="squeezelite-pulse-2.0.0.1541-aarch64.tar.gz"
 
 if [[ "${BUILD_MODE}" == "sf" ]]; then
-    apt-get install wget -y
-    #ARCH=`uname -m`
-    mkdir /assets
-    mkdir -p /assets/sourceforge
     if [[ "${BINARY_MODE}" == "full" ]] || [[ "${BINARY_MODE}" == "alsa" ]]; then
-        SL_URL=${url_middle_alsa_dict["${ARCH}"]};
-        if [[ -n "${url_left}${SL_URL}${url_right}" ]]; then
-            echo "Found Alsa version for architecture ${ARCH}, downloading ..."
-            wget "${url_left}${SL_URL}${url_right}" -O /assets/sourceforge/squeezelite.tar.gz
-            mkdir /assets/sourceforge/expanded
-            tar xzvf /assets/sourceforge/squeezelite.tar.gz -C /assets/sourceforge/expanded
-            ls -la /assets/sourceforge/expanded/
-            mv /assets/sourceforge/expanded/squeezelite $OUTPUT_FILE
+        SL_ALSA_FILENAME=${alsa_file_dict["${ARCH}"]};
+        if [[ -n "${SL_ALSA_FILENAME}" ]]; then
+            echo "Found Alsa version for architecture ${ARCH}, decompressing ..."
+            mkdir -p /app/assets/sourceforge/expanded
+            tar xzvf "/app/assets/sourceforge/${SL_ALSA_FILENAME}" -C /app/assets/sourceforge/expanded
+            ls -la /app/assets/sourceforge/expanded/
+            mv /app/assets/sourceforge/expanded/squeezelite $OUTPUT_FILE
         else
-            echo "NOT Found Alsa version for architecture ${ARCH}. This was mandatory, exiting!"
+            echo "NOT Found Alsa version for architecture ${ARCH}, exiting!"
             exit 1
         fi
     fi
     if [[ "${BINARY_MODE}" == "full" ]] || [[ "${BINARY_MODE}" == "pulse" ]]; then
-        SL_URL_PULSE=${url_middle_pulse_dict["${ARCH}"]};
-        if [[ -n "${url_left}${SL_URL_PULSE}${url_right}" ]]; then
-            echo "Found PulseAudio version for architecture ${ARCH}, downloading ..."
-            wget "${url_left}${SL_URL_PULSE}${url_right}" -O /assets/sourceforge/squeezelite-pulse.tar.gz
-            mkdir /assets/sourceforge/expanded-pulse
-            tar xzvf /assets/sourceforge/squeezelite-pulse.tar.gz -C /assets/sourceforge/expanded-pulse
-            ls -la /assets/sourceforge/expanded-pulse/
-            mv /assets/sourceforge/expanded-pulse/squeezelite $OUTPUT_FILE_PULSE
+        SL_PULSE_FILENAME=${pulse_file_dict["${ARCH}"]};
+        if [[ -n "${SL_PULSE_FILENAME}" ]]; then
+            echo "Found PulseAudio version for architecture ${ARCH}, decompressing ..."
+            mkdir -p /app/assets/sourceforge/expanded-pulse
+            tar xzvf "/app/assets/sourceforge/${SL_PULSE_FILENAME}" -C /app/assets/sourceforge/expanded-pulse
+            ls -la /app/assets/sourceforge/expanded-pulse/
+            mv /app/assets/sourceforge/expanded-pulse/squeezelite $OUTPUT_FILE_PULSE
         else
-            echo "NOT Found PulseAudio version for architecture ${ARCH}. This was not mandatory."
+            echo "NOT Found PulseAudio version for architecture ${ARCH}, exiting!"
+            exit 1
         fi
     fi
     # cleanup
-    apt-get purge wget -y
     apt-get autoremove -y
     rm -Rf /assets
 elif [[ "${BUILD_MODE}" == "r2" ]]; then