Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Write a review icon fades gray after highlight #2055

Open
@Huddie

Description

@Huddie

If this is to denote “clicked” maybe we switch it to after the cell was selected instead of highlighted

Bug Report Dump (Auto-generated)
Version 1.22.0 (1533487686)
Device: iPhone 6s (iOS 11.4.1)
TestFlight: true

Activity

rnystrom

rnystrom commented on Aug 6, 2018

@rnystrom
Member

🤔 can you explain this a bit more? The cell should have a selection state. What’s the actual issue here?

Sent with GitHawk

Huddie

Huddie commented on Aug 6, 2018

@Huddie
CollaboratorAuthor

So if you were to press the cell but not click it.

  1. Press cell (but don’t click it)
  2. Move finger off cell.

The icon turns gray as if you had actually pressed it.

Not major on the least bit but I assume it’s a quick fix. I can look into it.

Sent with GitHawk

rnystrom

rnystrom commented on Aug 6, 2018

@rnystrom
Member

Oh ya that’s just the cell highlight state. Pretty typical UX of iOS apps

Sent with GitHawk

Huddie

Huddie commented on Aug 6, 2018

@Huddie
CollaboratorAuthor

@rnystrom Looking at the settings VC it seems that its caused by the image being set to render as template and the tint color being set to a gray.

Not sure why it doesn't render gray in the beginning.

rnystrom

rnystrom commented on Aug 7, 2018

@rnystrom
Member

Oh strange, it’s always gray to me

Sent with GitHawk

Huddie

Huddie commented on Aug 7, 2018

@Huddie
CollaboratorAuthor

Here’s what I get. Doesn’t really make a difference but just thought I’d log it so it’s known.

GitHawk Upload by Huddie

Sent with GitHawk

rnystrom

rnystrom commented on Aug 7, 2018

@rnystrom
Member

@Huddie do you have some accessibility options enabled? Why do your switches have extra icons? iOS 11.4?

Sent with GitHawk

Huddie

Huddie commented on Aug 7, 2018

@Huddie
CollaboratorAuthor

@rnystrom Ya I have the accessibility for switches. Idk I kinda like it. Is that what’s causing it?
And yes iOS 11.4.1

Sent with GitHawk

rnystrom

rnystrom commented on Aug 7, 2018

@rnystrom
Member

I’m not sure tbh

Sent with GitHawk

BasThomas

BasThomas commented on Aug 8, 2018

@BasThomas
Collaborator

Settings > General > Accessibility > On/Off Labels. Supported by all UISwitches. Been there since iOS 7 I think?

Huddie

Huddie commented on Aug 8, 2018

@Huddie
CollaboratorAuthor

I turned it off , didn’t change anything. Not sure if that helps.

Sent with GitHawk

BasThomas

BasThomas commented on Aug 8, 2018

@BasThomas
Collaborator

Don't think that is related

4 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    🎨 designChanges to the design of the app🐛 bugUnintended behaviour within the app

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @rnystrom@BasThomas@Huddie

        Issue actions

          Write a review icon fades gray after highlight · Issue #2055 · GitHawkApp/GitHawk