Tapping “source code wrap” button permits quotes in code to be changed to curly quotes

[benguild]

I pasted some code into a comment and tapped the code wrap button for backticks, but the quotes all flipped.

Bug Report Dump (Auto-generated)

Version 1.22.0 (1534395229)
Device: iPhone X (iOS 12.1)
TestFlight: false

[rnystrom]

Can you give us some steps on how exactly to reproduce this?

[benguild]

Just paste in something like this:

<script>var test = ""</script>

Highlight it, then press the </> button. If it doesn't do it, highlight it again and do it again, or enter some text around it and try it again.

[BasThomas]

Can you check if you have Smart Punctuation turned on in Settings > General > Keyboard?

[rnystrom]

Doesn't repro for me

[benguild]

@rnystrom I think the quotes are already angled in your screenshots.

[benguild]

@BasThomas Yes, "Smart Punctuation" is enabled as it's generally the default, no? I had an issue with this on a macOS editor once but they were able to resolve it without affecting other word processors/text input except when dealing with code, and this is probably the way to go.

[rnystrom]

I haven’t changed my kb from the factory setting 🤷‍♀️

Do you know how they resolved it?

_{Sent with GitHawk}

[BasThomas]

I mean we can get a reference to the text, then reiterate over it and replace previously normal quotes that became angled quotes with normal ones if they are within a code block?

That sounds like a lot of effort though. 😛

_{Sent with GitHawk}

[benguild]

I'm not sure but regardless it seems like smart punctuation is going to cause problems on macOS or iOS when dealing with files that are code or in markdown with embedded code.

[benguild]

This also happens when pasting in HTML from other issues:

[Huddie]

Pretty sure this issue was mentioned in the past

_{Sent with GitHawk}

[benguild]

One possible solution would be to have a markdown editor mode for posts that does not do this. Unless you for sure want fancy punctuation, it’s safer to turn off for anything that supports markdown or html. -- iPhoneから送信