Adding reaction to last comment when keyboard present #2

[Huddie]

Describe the bug
If you're in an issue and try to add a reaction to the last comment while the keyboard is displayed, the reaction menu appears but in the wrong place. See video below.

This is similar to #2015 back when we had the old reaction menu.

To Reproduce
Steps to reproduce the behavior:

1. Open an issue that you must scroll to see all comments
2. Activate keyboard (Start typing a reply)
3. Scroll to bottom
4. Tap to add reaction to the last comment
5. See error

Expected behavior
The reaction menu should appear near the last comment.

Screenshots

[rnystrom]

Dang. Any ideas how to fix? I guess the ContextMenu needs to layout when the kb resigns or something?

_{Sent with GitHawk}

[Huddie]

Yup I think that’s the problem as well.

Maybe:

• Set up a listener on the keyboard: https://developer.apple.com/documentation/uikit/uikeyboarddidhidenotification. Inside the method that gets called check to see if we’re waiting to display the reaction menu. If we are, display
• When someone taps add reaction we check to see if keyboard is active, if so, indicate a reaction is waiting and resign keyboard (this will cause the listener to activate and in turn call open the reaction appropriately when finished. If keyboard isn’t active, do what we already do

_{Sent with GitHawk}

[rnystrom]

I wonder if this is more elegantly handled in ContextMenu? I imagine this would break for anyone using the lib.

[Huddie]

Give an option to have the menu move with the keyboard?

_{Sent with GitHawk}

[rnystrom]

That actually does exist, but I have a feeling its to do w/ the scrollview or something.