Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Adding reaction goes to end of list #2403

Open
@Sherlouk

Description

When a reaction is added (tested using double tap to add, haven't validated for normal tap to add) it gets added to the end of list of reactions.

If I already have a reaction (e.g. 🎉) and then add one (e.g. 👍) it will be ordered 🎉 👍 in GitHawk UI. If I leave the issue and then re-enter it, it gets ordered based on a hardcoded array so that it renders 👍 🎉 (this is the same as GitHub's UI).

It's a very minor bug but when we insert a new reaction, we should place it respecting the order of reactions as determined in this array:

private let reactions: [ReactionContent] = [
.thumbsUp,
.hooray,
.thumbsDown,
.heart,
.laugh,
.confused
]

Metadata

Assignees

No one assigned

    Labels

    ✨ good first issueAn issue suitable for someone looking to get familiar with the codebase🎨 designChanges to the design of the app

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions