Skip to content

Commit fdf179a

Browse files
committed
workflows: use English review conclusions
1 parent b248890 commit fdf179a

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/scripts/pr-review/test.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ const workflowSource = fs.readFileSync(
5555
"utf8",
5656
);
5757
assert.match(workflowSource, /const conclusion = findingCount === 0/);
58-
assert.match(workflowSource, /'# PASS'/);
59-
assert.match(workflowSource, /`# FAIL /);
58+
assert.match(workflowSource, /'# Conclusion: PASS'/);
59+
assert.match(workflowSource, /`# Conclusion: FAIL \(\$\{findingCount\} actionable finding/);
6060
assert.match(
6161
workflowSource,
6262
/let body = \[\n\s+conclusion,\n\s+'## 🤖 OpenAI PR review'/,

.github/workflows/codex-openai-review.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -960,8 +960,8 @@ jobs:
960960
].join('\n\n');
961961
const findingCount = inlineFindings.length + summaryFindings.length;
962962
const conclusion = findingCount === 0
963-
? '# ✅ 结论:通过(PASS'
964-
: `# ❌ 结论:不通过(FAIL,发现 ${findingCount} 个可操作问题)`;
963+
? '# ✅ Conclusion: PASS'
964+
: `# ❌ Conclusion: FAIL (${findingCount} actionable finding${findingCount === 1 ? '' : 's'} found)`;
965965
let usageDetails = '';
966966
try {
967967
const usageData = JSON.parse(process.env.USAGE_JSON || '{}');

0 commit comments

Comments
 (0)