Merge pull request #194 from GizzZmo/ci/dependabot-noise-prettier-lint

ci: Dependabot noise reduction, Prettier gate, stricter no-unused-vars

Author: GizzZmo

.github/WORKFLOWS.md

@@ -25,19 +25,21 @@ All workflows have been enhanced with:
 
 **Jobs:**
 
-- **Build and Test** (Matrix: Node.js 20.x, 22.x):
+- **Build and Test** (Matrix: Node.js 20.x, 22.x) — *skipped for Dependabot*:
   - ✅ Install dependencies with npm ci
   - ✅ TypeScript type checking via `npm run typecheck`
   - ✅ **Run Vitest tests** with `npm run test:run`
   - ✅ Frontend build verification (Vite)
   - ✅ C++ server compilation with Make
   - ✅ Binary verification
   - ✅ Upload build artifacts (dist/ and omnigrid_server) for Node 20.x
-- **Code Quality Check**:
+- **Dependabot Smoke** (Node 20 only) — *only for Dependabot PRs*:
+  - ✅ Typecheck + unit tests (lightweight gate; no matrix / C++ / coverage)
+- **Code Quality Check** (always runs, including Dependabot — **Prettier gate**):
   - ✅ **ESLint** validation with `npm run lint`
-  - ✅ **Prettier** format checking with `npm run format:check`
+  - ✅ **Prettier** format checking with `npm run format:check` (fails CI on drift)
   - ✅ TODO/FIXME comment detection (warning only)
-- **Test Coverage**:
+- **Test Coverage** — *skipped for Dependabot*:
   - ✅ Run tests with coverage reporting
   - ✅ Upload coverage artifacts
   - ✅ **Post coverage report as PR comment**
@@ -536,5 +538,5 @@ npm run artifacts:generate # Generate build artifact manifest locally (requires
 
 ---
 
-_Last Updated: 2026-08-14_  
+_Last Updated: 2026-08-15_  
 _For questions or issues with workflows, please open an issue with the `ci-cd` label._

.github/workflows/ci.yml

@@ -13,9 +13,11 @@ permissions:
   pull-requests: write
 
 jobs:
+  # Full matrix + C++ + artifacts — skip on Dependabot to cut noise and CI minutes.
   build-and-test:
     name: Build and Test
     runs-on: ubuntu-latest
+    if: github.actor != 'dependabot[bot]'
 
     strategy:
       matrix:
@@ -69,6 +71,32 @@ jobs:
             omnigrid_server
           retention-days: 7
 
+  # Lightweight gate for Dependabot PRs: typecheck + unit tests only (single Node).
+  dependabot-smoke:
+    name: Dependabot Smoke (typecheck + test)
+    runs-on: ubuntu-latest
+    if: github.actor == 'dependabot[bot]'
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v6
+        with:
+          node-version: 20.x
+          cache: 'npm'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: TypeScript type check
+        run: npm run typecheck
+
+      - name: Run tests
+        run: npm run test:run
+
+  # Always runs (including Dependabot) — ESLint + Prettier gate.
   lint-and-format:
     name: Code Quality Check
     runs-on: ubuntu-latest
@@ -102,9 +130,11 @@ jobs:
             echo "✅ No TODO/FIXME comments found"
           fi
 
+  # Coverage is expensive and noisy on dependency bumps — skip for Dependabot.
   test-coverage:
     name: Test Coverage
     runs-on: ubuntu-latest
+    if: github.actor != 'dependabot[bot]'
 
     steps:
       - name: Checkout code

eslint.config.js

@@ -130,7 +130,7 @@ export default [
       // Keep as warn so existing intentional `any` does not fail CI; tighten over time.
       '@typescript-eslint/no-explicit-any': 'warn',
       '@typescript-eslint/no-unused-vars': [
-        'warn',
+        'error',
         {
           argsIgnorePattern: '^_',
           varsIgnorePattern: '^_',

test/aiProviders.test.ts

@@ -1,6 +1,5 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
 import { providers, getProviderById } from '../services/aiProviders';
-import { estimateTokens } from '../services/promptEngine';
 
 describe('aiProviders', () => {
   describe('providers list', () => {
@@ -13,25 +12,30 @@ describe('aiProviders', () => {
         expect(provider.id).toBeTruthy();
         expect(provider.name).toBeTruthy();
         expect(provider.model).toBeTruthy();
-        expect(typeof provider.costPer1kTokens).toBe('number');
         expect(typeof provider.run).toBe('function');
         expect(typeof provider.estimateTokens).toBe('function');
       }
     });
 
-    it('providers have unique ids', () => {
+    it('has unique ids', () => {
       const ids = providers.map(p => p.id);
-      const uniqueIds = new Set(ids);
-      expect(uniqueIds.size).toBe(ids.length);
+      expect(new Set(ids).size).toBe(ids.length);
     });
+  });
 
-    it('includes gemini-pro, gpt-4o-mini, and claude-3-sonnet', () => {
-      const ids = providers.map(p => p.id);
-      expect(ids).toContain('gemini-pro');
-      expect(ids).toContain('gpt-4o-mini');
-      expect(ids).toContain('claude-3-sonnet');
+  describe('getProviderById', () => {
+    it('returns provider for known id', () => {
+      const p = getProviderById('gemini-flash');
+      expect(p).toBeDefined();
+      expect(p!.id).toBe('gemini-flash');
+    });
+
+    it('returns undefined for unknown id', () => {
+      expect(getProviderById('does-not-exist')).toBeUndefined();
     });
+  });
 
+  describe('estimateTokens on providers', () => {
     it('each provider estimateTokens function works correctly', () => {
       for (const provider of providers) {
         const tokens = provider.estimateTokens('hello world');
@@ -40,56 +44,27 @@ describe('aiProviders', () => {
     });
   });
 
-  describe('getProviderById', () => {
-    it('returns the correct provider by id', () => {
-      const provider = getProviderById('gemini-pro');
-      expect(provider).toBeDefined();
-      expect(provider?.id).toBe('gemini-pro');
-      expect(provider?.name).toBe('Gemini Pro');
-    });
-
-    it('returns undefined for unknown provider id', () => {
-      const provider = getProviderById('unknown-provider-xyz');
-      expect(provider).toBeUndefined();
-    });
-  });
-
-  describe('provider run()', () => {
+  describe('provider.run', () => {
     beforeEach(() => {
       vi.useFakeTimers();
     });
-
     afterEach(() => {
       vi.useRealTimers();
     });
 
-    it('returns a CompletionResponse with expected shape', async () => {
-      const provider = getProviderById('gemini-pro')!;
-      const promise = provider.run('short test prompt');
+    it('returns a response object', async () => {
+      const provider = getProviderById('gemini-flash')!;
+      const promise = provider.run('test prompt');
       await vi.runAllTimersAsync();
       const response = await promise;
-
-      expect(response.providerId).toBe('gemini-pro');
-      expect(typeof response.output).toBe('string');
-      expect(response.output.length).toBeGreaterThan(0);
-      expect(typeof response.tokens.input).toBe('number');
-      expect(typeof response.tokens.output).toBe('number');
+      expect(response.output).toBeTruthy();
       expect(typeof response.cost).toBe('number');
-      expect(typeof response.latencyMs).toBe('number');
-    });
-
-    it('includes the prompt in the output', async () => {
-      const provider = getProviderById('gpt-4o-mini')!;
-      const promise = provider.run('uniquepromptstring');
-      await vi.runAllTimersAsync();
-      const response = await promise;
-      expect(response.output).toContain('uniquepromptstring');
+      expect(typeof response.tokensUsed).toBe('number');
     });
 
-    it('truncates very long prompts in the output', async () => {
-      const provider = getProviderById('claude-3-sonnet')!;
-      const longPrompt = 'x'.repeat(500);
-      const promise = provider.run(longPrompt);
+    it('respects maxTokens option', async () => {
+      const provider = getProviderById('gemini-flash')!;
+      const promise = provider.run('x'.repeat(1000), { maxTokens: 50 });
       await vi.runAllTimersAsync();
       const response = await promise;
       // Output should be truncated at 280 chars (+ provider prefix)

test/chromaLab.test.tsx

@@ -1,5 +1,5 @@
 import { describe, it, expect } from 'vitest';
-import { render, screen, fireEvent } from '@testing-library/react';
+import { render, screen } from '@testing-library/react';
 import { ChromaLab } from '../widgets/ChromaLab';
 
 describe('ChromaLab', () => {

test/geminiService.test.ts

@@ -1,4 +1,4 @@
-import { describe, it, expect, vi, afterEach, beforeEach } from 'vitest';
+import { describe, it, expect, vi, afterEach } from 'vitest';
 
 // Must use regular function (not arrow) so it works as a constructor with `new`
 vi.mock('@google/genai', () => ({

test/pwaService.test.ts

@@ -1,12 +1,4 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
-import {
-  register,
-  promptInstall,
-  applyUpdate,
-  onPWAStateChange,
-  getPWAState,
-} from '../services/pwaService';
-
 // ---------------------------------------------------------------------------
 // Helpers
 // ---------------------------------------------------------------------------