Skip to content
This repository was archived by the owner on Aug 17, 2024. It is now read-only.
This repository was archived by the owner on Aug 17, 2024. It is now read-only.

[BUG] Definitions for filter and where functions missing boolean option #135

Open
@ajdaling

Description

@ajdaling

Typings for filter and where functions are missing boolean option for condition. Using these functions as described in the documentation:

df.filter(row => row.get('column1') >= 3)

throws the following TS error: Type 'boolean' is not assignable to type 'DataFrame | Record<string, any>'.ts(2322)

Function definitions need to be updated to:
where(condition: (row: any) => DataFrame | Record<string, any> | boolean): DataFrame;
filter(condition: (row: any) => DataFrame | Record<string, any> | boolean): DataFrame;

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions