Fixing scripts

Author: Volte6

_datafiles/sample-scripts/mobs/item-gold-quest.js

@@ -46,7 +46,7 @@ function onAsk(mob, room, eventDetails) {
         //
         // Search the text they inputted for the "ask" command for one of the questStartSubjects
         //
-        match = UtilFindMatchIn(eventDetails.askText, questStartSubjects);
+        var match = UtilFindMatchIn(eventDetails.askText, questStartSubjects);
 
         if ( match.found ) {
 
@@ -66,7 +66,7 @@ function onAsk(mob, room, eventDetails) {
     // By this point in the script we know they've at least started the quest
     // Lets see if they are asking any follow up questions for more info.
     //
-    match = UtilFindMatchIn(eventDetails.askText, questInfoSubjects);
+    var match = UtilFindMatchIn(eventDetails.askText, questInfoSubjects);
     if ( match.found ) {
         mob.Command("emote thinks hard for a moment.");
         mob.Command("say You can get sharp sticks from a shop, and gold from selling objects, or possibly killing bad guys and looting them.");
@@ -170,7 +170,7 @@ function onGive(mob, room, eventDetails) {
             //
             // If they gave too much gold, lets give them back the change.
             //
-            excessGold = eventDetails.gold - REQUIRED_GOLD_AMOUNT;
+            var excessGold = eventDetails.gold - REQUIRED_GOLD_AMOUNT;
             if ( excessGold > 0 ) {
                 mob.Command("say Here's your change.");
                 mob.Command("give "+String(excessGold)+" gold " + user.ShorthandId()); // Give it to the player using shorthand

_datafiles/world/default/mobs/frostfang/scripts/2-guard-hungry.js

@@ -137,10 +137,10 @@ function onIdle(mob, room) {
 
     if ( sizeAfter != sizeBefore ) {
         if ( sizeAfter == 0 ) {
+            mob.SetTempData('playersTold', null);
+        } else {
             mob.SetTempData('playersTold', playersTold);
         }
-    } else {
-        mob.SetTempData('playersTold', null);
     }
 
     action = round % 3;

_datafiles/world/default/mobs/frostfang/scripts/26-frostfang_citizen-rattrap.js

@@ -19,7 +19,7 @@ function onAsk(mob, room, eventDetails) {
 
             mob.Command("say Thanks for picking it up!");
 
-            user.GetParty().GiveQuest("7-gettrap");
+            user.GetParty().GiveQuest("7-tradetrap");
 
             return true;
         }

_datafiles/world/default/mobs/frostfang/scripts/39-elara.js

@@ -68,7 +68,7 @@ function onGive(mob, room, eventDetails) {
         mob.Command("emote Shows you some useful gestures.");
         mob.Command("say Check your <ansi fg=\"command\">spellbook</ansi>.");
 
-        party = user.GetParty().LearnSpell("illum");
+        user.GetParty().LearnSpell("illum");
 
         return true;
     }

_datafiles/world/default/mobs/whispering_wastes/scripts/27-hermit-winterfire.js

@@ -47,7 +47,7 @@ function onGive(mob, room, eventDetails) {
     }
 
     if (eventDetails.item) {
-        if (eventDetails.item.ItemId != 4) {
+        if (eventDetails.item.ItemId == 4) {
             mob.Command("say Finally! My winterfire crystal! Thank you so much!");
             user.GetParty().GiveQuest("5-end");
             return true;

_datafiles/world/default/rooms/frostfang/35.js

@@ -2,6 +2,12 @@
 
 const magic_phrase = "zyphrial lumara vorthos";
 
+// EventFlags constants
+const EventFlags = {
+    CmdSkipScripts: 1,
+    CmdBlockInputUntilComplete: 2
+};
+
 function onCommand_west(rest, user, room) {
 
     if ( !user.HasQuest("3-end") ) {

_datafiles/world/default/spells/sparks.js

@@ -42,12 +42,12 @@ function onMagic(sourceActor, targetActors) {
             SendRoomMessage(roomId, sourceName+' stops chanting and lets loose a shower of sparks, hitting '+targetName+'.', sourceUserId, targetUserId);
 
             // Tell the target about the dmg
-            SendUserMessage(targetUserId, sourceName+' stops chanting fires a shower of sparks at you, hitting for <ansi fg="damage">'+dmgAmtStr+' damage</ansi>.');
+            SendUserMessage(targetUserId, sourceName+' stops chanting and fires a shower of sparks at you, hitting for <ansi fg="damage">'+dmgAmtStr+' damage</ansi>.');
 
         } else {
 
             // Tell the cast they did it to themselves
-            SendUserMessage(sourceUserId, 'You stop chanting and fires a shower of sparks at yourself, doing <ansi fg="damage">'+dmgAmtStr+' damage</ansi>.');
+            SendUserMessage(sourceUserId, 'You stop chanting and fire a shower of sparks at yourself, doing <ansi fg="damage">'+dmgAmtStr+' damage</ansi>.');
 
             // Tell the room about the dmg, except the source and target
             SendRoomMessage(roomId, sourceName+' stops chanting and fires a shower of sparks at themselves, hurting themselves.', sourceUserId, targetUserId);

_datafiles/world/default/spells/tameskill.js

@@ -91,7 +91,7 @@ function onWait(sourceActor, targetActor) {
             break;
         default:
             SendUserMessage(sourceActor.UserId(), '<ansi fg="219">You whistle several times, changing your pitch ever so slightly.</ansi>');
-            SendRoomMessage(sourceActor.GetRoomId(), `<ansi fg="219">`+sourceActor.GetCharacterName(true)+' whistles several times, changing your pitch ever so slightly.</ansi>', sourceActor.UserId());
+            SendRoomMessage(sourceActor.GetRoomId(), `<ansi fg="219">`+sourceActor.GetCharacterName(true)+' whistles several times, changing their pitch ever so slightly.</ansi>', sourceActor.UserId());
     }
 
 }